Skip to content

Commit b88ea8b

Browse files
committed
Merge tag 'v2.17.2' of github.com:salesforce-ux/design-system-internal into spring-22-opensource
2 parents 138ea73 + e973d77 commit b88ea8b

File tree

9 files changed

+49
-12
lines changed

9 files changed

+49
-12
lines changed

RELEASENOTES.general.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- On release, add general notes here. In time the legacy release notes will be add to this -->
33

4-
## 2.17.1 - January 6, 2021
4+
## 2.17.2 - January 20, 2022
5+
6+
## 2.17.1 - January 6, 2022
57

68
## 2.17.0 - December 16, 2021
79

RELEASENOTES.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,20 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
33

4-
## Release 2.17.1 - January 6, 2021
4+
## Release 2.17.2 - January 20, 2022
5+
6+
## Components
7+
### [Buttons](https://www.lightningdesignsystem.com/components/buttons)
8+
#### Added
9+
- Added `--slds-c-icon-color-foreground` Styling Hook to Button with Icon variant to accurately apply icon color updates
10+
- Due to how the Lightning Base Component is configured, this is required to allow CSS Custom Property reassignment to function within Button Icons
11+
12+
## Release 2.17.1 - January 6, 2022
13+
14+
## Components
15+
### [Cards](https://www.lightningdesignsystem.com/components/cards)
16+
#### Changed
17+
- Fixed annotation for Einstein themed cards (`.slds-einstein-header__figure`)
518

619
## Release 2.17.0 - December 16, 2021
720

@@ -45,8 +58,6 @@
4558
- Added `slds` as the default namespace with `sds` fallbacks for Styling Hooks.
4659
- Added reassignment of Styling Hooks for component states.
4760
- Added clarification about card header icon assistive text.
48-
#### Changed
49-
- Fixed annotation for Einstein themed cards (`.slds-einstein-header__figure`)
5061

5162
### [Checkbox](https://www.lightningdesignsystem.com/components/checkbox)
5263
#### Added

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"CSS"
99
],
1010
"homepage": "https://lightningdesignsystem.com",
11-
"version": "2.17.1",
11+
"version": "2.17.2",
1212
"author": "Salesforce",
1313
"bugs": {
1414
"url": "https://github.com/salesforce-ux/design-system/issues"

ui/_config.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
///
1010
/// @type String
1111
/// @access private
12-
$app-version: "2.17.1";
12+
$app-version: "2.17.2";
1313

1414
/// Debug mode (uncomment to activate)
1515
/// Turn on to output deprecation warnings during development

ui/components/button-icons/base/example.jsx

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
import React from 'react';
55
import ButtonIcon, { HintParent } from '../';
6+
import {Button} from '../../buttons/base/example';
7+
import SvgIcon from '../../../shared/svg-icon';
68

79
export default [
810
{
@@ -57,5 +59,18 @@ export let examples = [
5759
/>
5860
</HintParent>
5961
)
62+
},
63+
{
64+
id: 'button-icon-lbc-mismatch',
65+
label: 'Button Icon - LBC Mismatch',
66+
element: (
67+
<Button className="slds-button_icon slds-button_icon-border">
68+
<SvgIcon
69+
sprite="utility"
70+
symbol="clock"
71+
className="slds-button__icon slds-icon-text-error"
72+
/>
73+
</Button>
74+
)
6075
}
6176
];

ui/components/buttons/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,17 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.17.2
8+
9+
### Added
10+
- Added `--slds-c-icon-color-foreground` Styling Hook to Button with Icon variant to accurately apply icon color updates
11+
- Due to how the Lightning Base Component is configured, this is required to allow CSS Custom Property reassignment to function within Button Icons
712
## 2.17.0
813

914
### Added
1015
- Added Styling Hooks for Stateful Button and Dual Stateful Button.
1116
- Added missing `slds`-namespaced Styling Hooks (originally added in 2.16.0)
17+
1218
## 2.16.0
1319

1420
### Added

ui/components/buttons/base/_index.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,8 @@ a.slds-button--inverse:focus {
569569
*/
570570
.slds-button__icon {
571571
@include square($square-icon-medium-content-alt);
572-
fill: currentColor;
572+
// Aura and LBC Button Icon components were created with a mix of approaches: partially with how Button Icon works and partially with Button _with_ Icon. Because of this, state classes (success/warning/error) within a Button Icon would never get the correct color, as this previously was hardcoded to `currentColor`. This is the least-invasive approach for remediation.
573+
fill: var(--slds-c-icon-color-foreground, currentColor);
573574
}
574575

575576
/**

ui/components/cards/RELEASENOTES.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.17.1
8+
9+
### Changed
10+
11+
- Fixed annotation for Einstein themed cards (`.slds-einstein-header__figure`)
12+
713
## 2.17.0
814

915
### Added
@@ -12,10 +18,6 @@
1218
- Added reassignment of Styling Hooks for component states.
1319
- Added clarification about card header icon assistive text.
1420

15-
### Changed
16-
17-
- Fixed annotation for Einstein themed cards (`.slds-einstein-header__figure`)
18-
1921
## 2.15.1
2022

2123
### Added

0 commit comments

Comments
 (0)