Skip to content

Commit cc237f2

Browse files
kflournoy-sfAlexis Córdova
andauthored
fix(scss notation): fix & notation for tiles (#4995)
Co-authored-by: Alexis Córdova <[email protected]>
1 parent 2cb2a8f commit cc237f2

File tree

5 files changed

+55
-30
lines changed

5 files changed

+55
-30
lines changed

RELEASENOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
#### Changed
2020
- Removed `@noflip` annotation from nubbins to make RTL behavior consistent
2121

22+
### [Tiles](https://www.lightningdesignsystem.com/components/tiles)
23+
#### Added
24+
- Added annotations for tile board CSS classes.
25+
2226
## Release 2.17.3 - January 27, 2022
2327

2428
## Components

ui/components/tiles/RELEASENOTES.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,8 @@
44

55
<!-- ## [Unreleased] -->
66

7-
<!-- ## [VERSION] -->
7+
## 2.18.0
8+
9+
### Added
10+
11+
- Added annotations for tile board CSS classes.

ui/components/tiles/_doc.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
* @base
99
* @name tiles
10-
* @selector .slds-tile
10+
* @selector .slds-tile, .slds-tile_board
1111
* @support dev-ready
1212
* @category structure
1313
* @type data-display

ui/components/tiles/base/_index.scss

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,36 +15,37 @@
1515
+ .slds-tile {
1616
margin-top: $spacing-x-small;
1717
}
18+
}
1819

19-
/**
20-
* @selector .slds-tile__detail
21-
* @restrict .slds-tile div
22-
*/
23-
&__detail {
24-
position: relative;
25-
}
20+
/**
21+
* @selector .slds-tile__detail
22+
* @restrict .slds-tile div
23+
*/
24+
.slds-tile__detail {
25+
position: relative;
26+
}
2627

27-
/**
28-
* @selector .slds-tile__meta
29-
* @restrict .slds-tile div
30-
*/
31-
&__meta {
32-
color: $color-text-default;
33-
}
28+
/**
29+
* @selector .slds-tile__meta
30+
* @restrict .slds-tile div
31+
*/
32+
.slds-tile__meta {
33+
color: $color-text-default;
3434
}
3535

3636
.slds-tile_board,
3737
.slds-tile--board {
3838
position: relative;
3939

40-
&__icon {
41-
@include square($square-icon-medium-content);
42-
position: absolute;
43-
bottom: $spacing-xx-small;
44-
right: $spacing-xx-small;
45-
}
46-
4740
.slds-has-alert {
4841
padding-right: $spacing-large;
4942
}
5043
}
44+
45+
.slds-tile_board__icon,
46+
.slds-tile--board__icon {
47+
@include square($square-icon-medium-content);
48+
position: absolute;
49+
bottom: $spacing-xx-small;
50+
right: $spacing-xx-small;
51+
}

ui/components/tiles/board/_index.scss

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,34 @@
11
// Copyright (c) 2015-present, salesforce.com, inc. All rights reserved
22
// Licensed under BSD 3-Clause - see LICENSE.txt or git.io/sfdc-license
33

4+
/**
5+
* @summary Initializes tile board
6+
*
7+
* @name tile-board
8+
* @selector .slds-tile_board
9+
* @restrict article
10+
* @support dev-ready
11+
* @variant
12+
*/
13+
414
.slds-tile_board,
515
.slds-tile--board {
616
position: relative;
717

8-
&__icon {
9-
@include square($square-icon-medium-content);
10-
position: absolute;
11-
bottom: $spacing-xx-small;
12-
right: $spacing-xx-small;
13-
}
14-
1518
.slds-has-alert {
1619
padding-right: $spacing-large;
1720
}
1821
}
22+
23+
/**
24+
* @summary Tile board icon
25+
* @selector .slds-tile_board__icon
26+
* @restrict .slds-tile_board span
27+
*/
28+
.slds-tile_board__icon,
29+
.slds-tile--board__icon {
30+
@include square($square-icon-medium-content);
31+
position: absolute;
32+
bottom: $spacing-xx-small;
33+
right: $spacing-xx-small;
34+
}

0 commit comments

Comments
 (0)