chore(merge): 2.19.0 Winter 23 ➡️ Spring 23 (#5080)

Dottenpixel · web-flow · commit d20eadb0afa9 · 2022-09-08T01:36:12.000-07:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -19,6 +19,7 @@ orbs:
   node: circleci/node@4.7.0
   heroku: circleci/heroku@1.2.2
   browser-tools: circleci/browser-tools@1.1.3
+  gh: circleci/github-cli@2.1.0
 
 executors:
   slds-executor:
@@ -194,17 +195,6 @@ commands:
               fi
             fi
 
-  install-gh-cli:
-    description: 'Install Github CLI'
-    steps:
-      - run:
-          name: Install Github CLI
-          command: |
-            sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-key C99B11DEB97541F0
-            sudo apt-add-repository https://cli.github.com/packages
-            sudo apt update
-            sudo apt install gh
-
   launch-static-storybook:
     description: 'Launch local static Storybook server'
     steps:
@@ -231,7 +221,7 @@ jobs:
     steps:
       - checkout
       - run: mkdir -p workspace
-      - install-gh-cli
+      - gh/install
       - get-pr-number
 
       - run:
@@ -350,7 +340,7 @@ jobs:
       - attach_workspace:
           at: workspace
 
-      - install-gh-cli
+      - gh/install
 
       - run:
           name: 'Github: attach artifact to release'
@@ -452,7 +442,7 @@ jobs:
             heroku buildpacks -a ${PUBLISH_STORYBOOK_TO} | grep "https://github.com/salesforce-ux/heroku-buildpack-nginx.git#dse" || heroku buildpacks:set https://github.com/salesforce-ux/heroku-buildpack-nginx.git#dse -a ${PUBLISH_STORYBOOK_TO}
             heroku builds:create --source-tar workspace/storybook.tar.gz -a ${PUBLISH_STORYBOOK_TO}
 
-      - install-gh-cli
+      - gh/install
       - run:
           name: Set Github deployments to "success"
           command: |
@@ -520,7 +510,7 @@ jobs:
             heroku buildpacks -a ${HEROKU_APP_NAME} | grep "https://github.com/salesforce-ux/heroku-buildpack-nginx.git#dse" || heroku buildpacks:set https://github.com/salesforce-ux/heroku-buildpack-nginx.git#dse -a ${HEROKU_APP_NAME}
             heroku builds:create --source-tar site-next.tar.gz -a ${HEROKU_APP_NAME}
 
-      - install-gh-cli
+      - gh/install
       - run:
           name: Set Github deployments to "success"
           command: |
@@ -537,7 +527,7 @@ jobs:
     steps:
       - checkout
       - run: mkdir -p workspace
-      - install-gh-cli
+      - gh/install
       - get-pr-number
 
       - persist_to_workspace:
diff --git a/RELEASENOTES.general.md b/RELEASENOTES.general.md
@@ -1,7 +1,9 @@
 <!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
 <!-- On release, add general notes here. In time the legacy release notes will be add to this -->
 
-## 2.19.0 - Upcoming
+## 2.20.0 - Upcoming
+
+## 2.19.0 - August 11, 2022
 
 - Updated icons to `v10.4.0`
   - Standard Set:
@@ -55,7 +57,7 @@
     - Added `transport_walking`
     - Added `utility`
     - Added `water`
-  
+
 - BRAND updates to below colors of the palette
   - `PALETTE_GREEN_20`: `#1C3326`
   - `PALETTE_GREEN_40`: `#396547`
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -1,7 +1,9 @@
 <!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
 <!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
 
-## Release 2.19.0 - Upcoming
+## Release 2.20.0 - Upcoming
+
+## Release 2.19.0 - August 11, 2022
 
 - Updated icons to `v10.4.0`
   - Standard Set:
@@ -55,15 +57,14 @@
     - Added `transport_walking`
     - Added `utility`
     - Added `water`
-
 - BRAND updates to below colors of the palette
   - `PALETTE_GREEN_20`: `#1C3326`
   - `PALETTE_GREEN_40`: `#396547`
   - `PALETTE_HOT_ORANGE_20`: `#4A2413`
   - `PALETTE_INDIGO_20`: `#321D71`
   - `PALETTE_PURPLE_80`: `#D7BFF2`
   - `PALETTE_VIOLET_20`: `#481A54`
-  
+
 ## Components
 ### [Dynamic Icons](https://www.lightningdesignsystem.com/components/dynamic-icons)
 #### Changed
@@ -77,6 +78,10 @@
 #### Changed
 - Added tabindex to Footless example for programmatic focus use case.
 
+### [Progress Bar](https://www.lightningdesignsystem.com/components/progress-bar)
+#### Added
+- Added example for Success under States
+
 ### [Tabs](https://www.lightningdesignsystem.com/components/tabs)
 #### Added
 - Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
diff --git a/design-tokens/extensions/ui-force/image-paths.yml b/design-tokens/extensions/ui-force/image-paths.yml
@@ -10,14 +10,14 @@ props:
   BANNER_GROUP_DEFAULT_IMAGE:
     value: ''
   USER_DEFAULT_AVATAR:
-    value: '/assets/images/profile_avatar_200.png'
+    value: '/profile_avatar_200.png'
   USER_DEFAULT_AVATAR_MEDIUM:
-    value: '/assets/images/profile_avatar_160.png'
+    value: '/profile_avatar_160.png'
   USER_DEFAULT_AVATAR_SMALL:
-    value: '/assets/images/profile_avatar_96.png'
+    value: '/profile_avatar_96.png'
   GROUP_DEFAULT_AVATAR:
-    value: '/assets/images/group_avatar_200.png'
+    value: '/group_avatar_200.png'
   GROUP_DEFAULT_AVATAR_MEDIUM:
-    value: '/assets/images/group_avatar_160.png'
+    value: '/group_avatar_160.png'
   GROUP_DEFAULT_AVATAR_SMALL:
-    value: '/assets/images/group_avatar_96.png'
+    value: '/group_avatar_96.png'
diff --git a/design-tokens/themes/oneSalesforce/ui-force/background-color.yml b/design-tokens/themes/oneSalesforce/ui-force/background-color.yml
@@ -26,10 +26,10 @@ props:
   POPOVER_WALKTHROUGH_COLOR_BACKGROUND_ALT:
     value: '{!PALETTE_BLUE_50}'
   POPOVER_WALKTHROUGH_HEADER_IMAGE:
-    value: '/assets/images/popovers/popover-header.png'
+    value: '/popovers/popover-header.png'
     type: string
   POPOVER_WALKTHROUGH_ALT_IMAGE:
-    value: '/assets/images/popovers/popover-action.png'
+    value: '/popovers/popover-action.png'
     type: string
   POPOVER_WALKTHROUGH_ALT_NUBBIN_COLOR_BACKGROUND:
     value: '{!PALETTE_BLUE_50}'
diff --git a/design-tokens/themes/oneSalesforce/ui-force/image-paths.yml b/design-tokens/themes/oneSalesforce/ui-force/image-paths.yml
@@ -7,8 +7,8 @@ global:
 props:
   ## BANNERS
   BRAND_BAND_DEFAULT_IMAGE:
-    value: '/assets/images/themes/oneSalesforce/banner-brand-default.png'
+    value: '/themes/oneSalesforce/banner-brand-default.png'
   BANNER_USER_DEFAULT_IMAGE:
-    value: '/assets/images/themes/oneSalesforce/banner-user-default.png'
+    value: '/themes/oneSalesforce/banner-user-default.png'
   BANNER_GROUP_DEFAULT_IMAGE:
-    value: '/assets/images/themes/oneSalesforce/banner-group-public-default.png'
+    value: '/themes/oneSalesforce/banner-group-public-default.png'
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -8,7 +8,7 @@
     "CSS"
   ],
   "homepage": "https://lightningdesignsystem.com",
-  "version": "2.19.0-beta.1",
+  "version": "2.20.0-dev",
   "author": "Salesforce",
   "bugs": {
     "url": "https://github.com/salesforce-ux/design-system/issues"
diff --git a/scripts/gulp/plugins/data-uri.js b/scripts/gulp/plugins/data-uri.js
@@ -2,7 +2,7 @@ const fs = require('fs');
 const mime = require('mime');
 const path = require('path');
 
-const root = path.resolve(__dirname, '../../../');
+const root = path.resolve(__dirname, '../../../assets/images');
 
 module.exports = (opts = {}) => {
   return {
diff --git a/ui/_config.scss b/ui/_config.scss
@@ -9,7 +9,7 @@
 ///
 /// @type String
 /// @access private
-$app-version: "2.18.1";
+$app-version: "2.19.0";
 
 /// Debug mode (uncomment to activate)
 /// Turn on to output deprecation warnings during development
diff --git a/ui/components/avatar/RELEASENOTES.md b/ui/components/avatar/RELEASENOTES.md
@@ -2,6 +2,12 @@
 
 # Avatar Release Notes
 
+## 2.19
+
+### Fixed
+
+- Fixed base group image, group image medium and group image small hardcoded image paths
+
 ## 2.17.0
 
 ### Added
diff --git a/ui/components/avatar/base/_index.scss b/ui/components/avatar/base/_index.scss
@@ -33,7 +33,7 @@
    * @restrict .slds-avatar
    */
   &.slds-avatar_group-image-small {
-    background: url($group-default-avatar-small) top left / cover no-repeat;
+    background: url($static-image-path + $group-default-avatar-small) top left / cover no-repeat;
   }
 
   /**
@@ -43,7 +43,7 @@
    * @restrict .slds-avatar
    */
   &.slds-avatar_group-image-medium {
-    background: url($group-default-avatar-medium) top left / cover no-repeat;
+    background: url($static-image-path + $group-default-avatar-medium) top left / cover no-repeat;
   }
 
   /**
@@ -53,7 +53,7 @@
    * @restrict .slds-avatar
    */
   &.slds-avatar_group-image-large {
-    background: url($group-default-avatar) top left / cover no-repeat;
+    background: url($static-image-path + $group-default-avatar) top left / cover no-repeat;
   }
 
   /**
@@ -63,7 +63,7 @@
    * @restrict .slds-avatar
    */
   &.slds-avatar_profile-image-small {
-    background: url($user-default-avatar-small) top left / cover no-repeat;
+    background: url($static-image-path + $user-default-avatar-small) top left / cover no-repeat;
   }
 
   /**
@@ -73,7 +73,7 @@
    * @restrict .slds-avatar
    */
   &.slds-avatar_profile-image-medium {
-    background: url($user-default-avatar-medium) top left / cover no-repeat;
+    background: url($static-image-path + $user-default-avatar-medium) top left / cover no-repeat;
   }
 
   /**
@@ -83,7 +83,7 @@
    * @restrict .slds-avatar
    */
   &.slds-avatar_profile-image-large {
-    background: url($user-default-avatar) top left / cover no-repeat;
+    background: url($static-image-path + $user-default-avatar) top left / cover no-repeat;
   }
 }
 
diff --git a/ui/components/brand-band/RELEASENOTES.md b/ui/components/brand-band/RELEASENOTES.md
@@ -2,6 +2,12 @@
 
 # Brand Band Release Notes
 
+## 2.19
+
+### Fixed
+
+- Fixed base brand band, brand band group and brand band user hardcoded image paths
+
 <!-- ## [Unreleased] -->
 
 <!-- ## [VERSION] -->
diff --git a/ui/components/brand-band/base/_index.scss b/ui/components/brand-band/base/_index.scss
@@ -28,7 +28,7 @@
     bottom: 0;
     left: 0;
     background-image:
-      url($brand-band-default-image),
+      url($static-image-path + $brand-band-default-image),
       linear-gradient(to top, $brand-background-dark-transparent 0, $brand-background-dark);
     background-repeat: repeat-x;
     background-position: top left;
@@ -154,7 +154,7 @@
    * @group image
    */
   &.slds-brand-band_group:before {
-    background-image: url($banner-group-default-image);
+    background-image: url($static-image-path + $banner-group-default-image);
   }
 
   /**
@@ -166,7 +166,7 @@
    * @group image
    */
   &.slds-brand-band_user:before {
-    background-image: url($banner-user-default-image);
+    background-image: url($static-image-path + $banner-user-default-image);
   }
 
   // White page for iframes
diff --git a/ui/components/einstein-header/RELEASENOTES.md b/ui/components/einstein-header/RELEASENOTES.md
@@ -2,6 +2,12 @@
 
 # Einstein Header Release Notes
 
+## 2.19
+
+### Fixed
+
+- Fixed base header and header figure hardcoded image paths
+
 <!-- ## [Unreleased] -->
 
 <!-- ## [VERSION] -->
diff --git a/ui/components/einstein-header/base/_index.scss b/ui/components/einstein-header/base/_index.scss
@@ -5,7 +5,7 @@
 .slds-einstein-header {
   position: relative;
   background-color: $einstein-header-background-color;
-  background-image: url($einstein-header-background);
+  background-image: url($static-image-path + $einstein-header-background);
   background-repeat: no-repeat;
   background-position: left top;
   background-size: cover;
@@ -28,7 +28,7 @@
   .slds-einstein-header__figure:last-child {
     margin-bottom: calc((#{$spacing-small} + 5px) * -1);
     height: rem(76px);
-    background-image: url($einstein-header-figure);
+    background-image: url($static-image-path + $einstein-header-figure);
     background-position: right bottom;
     background-repeat: no-repeat;
   }
diff --git a/ui/components/einstein-header/tokens/background-color.yml b/ui/components/einstein-header/tokens/background-color.yml
@@ -8,10 +8,10 @@ imports:
 - "../../../../design-tokens/aliases/color-palettes.yml"
 props:
   EINSTEIN_HEADER_BACKGROUND:
-    value: '/assets/images/einstein-headers/einstein-header-background.svg'
+    value: '/einstein-headers/einstein-header-background.svg'
     type: string
   EINSTEIN_HEADER_FIGURE:
-    value: '/assets/images/einstein-headers/einstein-figure.svg'
+    value: '/einstein-headers/einstein-figure.svg'
     type: string
   EINSTEIN_HEADER_BACKGROUND_COLOR:
     value: '{!PALETTE_CLOUD_BLUE_80}'
diff --git a/ui/components/global-header/RELEASENOTES.md b/ui/components/global-header/RELEASENOTES.md
@@ -2,6 +2,12 @@
 
 # Global Header Release Notes
 
+## 2.19
+
+### Fixed
+
+- Fixed hardcoded base global header logo image path
+
 <!-- ## [Unreleased] -->
 ## 2.12.3
 
diff --git a/ui/components/global-header/base/_index.scss b/ui/components/global-header/base/_index.scss
@@ -96,7 +96,7 @@
 .slds-global-header__logo {
   width: rem(200px);
   height: rem(40px);
-  background-image: url($brand-logo-image);
+  background-image: url($static-image-path + $brand-logo-image);
   background-size: contain;
   background-repeat: no-repeat;
   background-position: left center;
diff --git a/ui/components/global-header/tokens/background-color.yml b/ui/components/global-header/tokens/background-color.yml
@@ -11,5 +11,5 @@ props:
     value: '{!PALETTE_NEUTRAL_100}'
     comment: Global Header background color
   BRAND_LOGO_IMAGE:
-    value: '/assets/images/logo-noname.svg'
+    value: '/logo-noname.svg'
     type: string
diff --git a/ui/components/popovers/RELEASENOTES.md b/ui/components/popovers/RELEASENOTES.md
diff --git a/ui/components/popovers/walkthrough/_deprecate.scss b/ui/components/popovers/walkthrough/_deprecate.scss
diff --git a/ui/components/progress-bar/RELEASENOTES.md b/ui/components/progress-bar/RELEASENOTES.md
diff --git a/ui/components/progress-bar/base/example.jsx b/ui/components/progress-bar/base/example.jsx
diff --git a/ui/components/progress-bar/docs.mdx b/ui/components/progress-bar/docs.mdx
diff --git a/ui/components/welcome-mat/RELEASENOTES.md b/ui/components/welcome-mat/RELEASENOTES.md
diff --git a/ui/components/welcome-mat/base/_index.scss b/ui/components/welcome-mat/base/_index.scss
diff --git a/ui/components/welcome-mat/tokens/color.yml b/ui/components/welcome-mat/tokens/color.yml
