chore(merge): 2.18.1 Summer 22 ➡️ Winter 23 (#5064)

Author: Dottenpixel

.circleci/config.yml

@@ -445,11 +445,6 @@ jobs:
             export PUBLISH_STORYBOOK_TO=${HEROKU_RELEASE_STORYBOOK_APP_NAME}
             else
             export PUBLISH_STORYBOOK_TO=${REVIEW_APP_NAME}
-            export EXISTING_REVIEW_APP=$(heroku apps:info -a ${REVIEW_APP_NAME} --json | jq -r ".app.name")
-            if [[ ${EXISTING_REVIEW_APP} == "" ]]; then
-              heroku apps:create ${REVIEW_APP_NAME} -t sfdc-uxe-slds
-              heroku pipelines:add slds -a ${REVIEW_APP_NAME} -s development
-            fi
             fi
             echo "=============================="
             echo ${PUBLISH_STORYBOOK_TO}
@@ -467,11 +462,6 @@ jobs:
               gh api ${STATUS_URL} -f state=success -f environment_url=${SITE_URL} -H "Accept: application/vnd.github.ant-man-preview+json"
             done
 
-      - run:
-          name: Create comment with link to review app
-          command: |
-            gh api --method POST -H "Accept: application/vnd.github.v3+json" /repos/salesforce-ux/design-system-internal/issues/${PR_NUMBER}/comments -f body="[Storybook Review app](https://${REVIEW_APP_NAME}.herokuapp.com) is ready for [${CIRCLE_SHA1}](https://github.com/salesforce-ux/design-system-internal/commit/${CIRCLE_SHA1})"
-
   # Build & publish SLDS site (review app or upcoming/core-main/core-patch)
   publish-site:
     executor: slds-executor
@@ -527,11 +517,6 @@ jobs:
             echo "=============================="
             echo ${HEROKU_APP_NAME}
             echo "=============================="
-            export EXISTING_REVIEW_APP=$(heroku apps:info -a ${HEROKU_APP_NAME} --json | jq -r ".app.name")
-            if [[ ${EXISTING_REVIEW_APP} == "" ]]; then
-              heroku apps:create ${HEROKU_APP_NAME} -t sfdc-uxe-slds
-              heroku pipelines:add slds-site-previews -a ${HEROKU_APP_NAME} -s development
-            fi
             heroku buildpacks -a ${HEROKU_APP_NAME} | grep "https://github.com/salesforce-ux/heroku-buildpack-nginx.git#dse" || heroku buildpacks:set https://github.com/salesforce-ux/heroku-buildpack-nginx.git#dse -a ${HEROKU_APP_NAME}
             heroku builds:create --source-tar site-next.tar.gz -a ${HEROKU_APP_NAME}
 
@@ -545,14 +530,6 @@ jobs:
               gh api ${STATUS_URL} -f state=success -f environment_url=${SITE_URL} -H "Accept: application/vnd.github.ant-man-preview+json"
             done
 
-      - set-github-pr-number
-      - run:
-          name: Create comment with link to review app
-          command: |
-            export HEROKU_APP_NAME=$(cat workspace/heroku-app-name.txt)
-
-            gh api --method POST -H "Accept: application/vnd.github.v3+json" /repos/salesforce-ux/design-system-internal/issues/${PR_NUMBER}/comments -f body="[SLDS Site Review app](https://${HEROKU_APP_NAME}.herokuapp.com) is ready for [${CIRCLE_SHA1}](https://github.com/salesforce-ux/design-system-internal/commit/${CIRCLE_SHA1})"
-
   vrt-init:
     executor: slds-executor
     resource_class: small

RELEASENOTES.general.md

@@ -1,6 +1,12 @@
 <!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
 <!-- On release, add general notes here. In time the legacy release notes will be add to this -->
 
+## 2.18.1 - June 22, 2022
+
+- Corrected typos in blueprints:
+  - components/checkbox
+  - components/vertical-navigation
+
 ## 2.18.0 - May 6, 2022
 
 - Removed `&_` shorthand from numerous selectors in SCSS files

RELEASENOTES.md

@@ -1,7 +1,7 @@
 <!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
 <!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
 
-## Release 2.19.0 - June 1, 2022
+## Release 2.19.0 - June 22, 2022
 
 ## Components
 ### [Dynamic Icons](https://www.lightningdesignsystem.com/components/dynamic-icons)
@@ -16,6 +16,12 @@
 #### Added
 - Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
 
+## Release 2.18.1 - June 22, 2022
+
+- Corrected typos in blueprints:
+  - components/checkbox
+  - components/vertical-navigation
+
 ## Release 2.18.0 - May 6, 2022
 
 - Removed `&_` shorthand from numerous selectors in SCSS files

package-lock.json

@@ -8,7 +8,7 @@
     "CSS"
   ],
   "homepage": "https://lightningdesignsystem.com",
-  "version": "2.18.0",
+  "version": "2.18.1",
   "author": "Salesforce",
   "bugs": {
     "url": "https://github.com/salesforce-ux/design-system/issues"

package.json

@@ -9,7 +9,7 @@
 ///
 /// @type String
 /// @access private
-$app-version: "2.18.0";
+$app-version: "2.18.1";
 
 /// Debug mode (uncomment to activate)
 /// Turn on to output deprecation warnings during development

ui/_config.scss

@@ -17,7 +17,13 @@ const errorId = 'error_01';
 /// ////////////////////////////////////////
 
 let Fieldset = props => (
-  <fieldset className={classNames('slds-form-element', props.className)}>
+  <fieldset
+    className={classNames(
+      'slds-form-element',
+      { 'slds-is-required': props.required },
+      props.className
+    )}
+  >
     {props.children}
   </fieldset>
 );
@@ -144,7 +150,7 @@ export let Group = props => (
 );
 
 export let GroupRequired = props => (
-  <Fieldset>
+  <Fieldset required>
     <Legend>
       <abbr className="slds-required" title="required">
         *
@@ -159,7 +165,7 @@ export let GroupRequired = props => (
 );
 
 export let GroupError = props => (
-  <Fieldset className="slds-has-error">
+  <Fieldset required className="slds-has-error">
     <Legend>
       <abbr className="slds-required" title="required">
         *

ui/components/checkbox/base/example.jsx

@@ -30,7 +30,7 @@ export default [
             hasHiddenLabel
           >
             <SvgIcon
-              className="slds-icon slds-input__icon slds-input__icon_right slds-icon-text-default"
+              className="slds-icon slds-input__icon slds-input__icon_left slds-icon-text-default"
               sprite="utility"
               symbol="search"
             />