feat(combobox): Replace input in select/read-only Comboboxes (#4696)

* make DeprecatedComboboxInput and build tests

* update and fix multi-entity combobox tests to use examples

* refactor DeprecatedComboboxInputElement

* put input styles into mixins

* faux input wip

* build out ComboboxFauxInput

* add activedescendent to select-only

* rename onFocus prop and new class to slds-input-faux

* add estimated min-width to faux input

* use button instead of div for non-input element

* update styles and attributes for button as artificial input

* refactor RTE combobox size class

* fix faux input touch and color styles

* rename 'faux' to 'mock'

* update release notes and docs

* convert object switcher to mock

* fix handler error

* annotation revs

* fix styles for IE

* going back to 'faux'

* rename component to ComboboxInputFaux and add truncation

* rename 'readonly' prop to 'selectOnly'

* add 'selectOnly' props to base Combobox

* relabel Base stories with 'select-only'

* update release notes

* remove tabindex

* update release notes

* update snaps

* update aria-labelledby

* remove combobox role from select-only

* update docs

Author: Dottenpixel

RELEASENOTES.general.md

@@ -3,6 +3,18 @@
 
 ## 2.16.0 - Upcoming
 
+- In accordance with ARIA 1.2 guidance, the `input` was replaced with `button` within these components that contain select-only comboboxes:
+  - Datetime Picker
+  - Docked Composer
+  - Dynamic Menu
+  - Expression
+  - Global Header
+  - List builder
+  - Lookups
+  - Picklist
+  - Rich Text Editor
+  - Timepicker
+
 - Added SLDS scope customizer tool: `npm run slds:customizer`
 
 ## 2.15.8 - May 27, 2021

RELEASENOTES.md

@@ -3,14 +3,30 @@
 
 ## Release 2.16.0 - Upcoming
 
+- In accordance with ARIA 1.2 guidance, the `input` was replaced with `button` within these components that contain select-only comboboxes:
+  - Datetime Picker
+  - Docked Composer
+  - Dynamic Menu
+  - Expression
+  - Global Header
+  - List builder
+  - Lookups
+  - Picklist
+  - Rich Text Editor
+  - Timepicker
+- Added SLDS scope customizer tool: `npm run slds:customizer`
+
 ## Components
 ### [Accordion](https://www.lightningdesignsystem.com/components/accordion)
 ## Added
 - Added link to accessibility keyboard interaction guidelines.
 
 ### [Combobox](https://www.lightningdesignsystem.com/components/combobox)
 #### Changed
-- Updated to ARIA 1.2 compliance where these attributes are moved to the text input: `role="combobox"`, `aria-expanded`, `aria-haspopup="listbox"`.
+- Changed `slds-combobox__input` element from `input` to `button` per ARIA 1.2 guidance for select-only comboboxes.
+- Updated to ARIA 1.2 compliance where these attributes are moved to the input, or button in the case of select-only: `role="combobox"`, `aria-expanded`, `aria-haspopup="listbox"`.
+- Changed `@restrict` annotation of `.slds-combobox__input` from `.slds-combobox input` to `.slds-combobox__form-element input, .slds-combobox__form-element button`
+- Changed `@restrict` annotation of `.slds-combobox__input-value` from `.slds-combobox input` to `.slds-combobox__input`
 
 ### [Datepickers](https://www.lightningdesignsystem.com/components/datepickers)
 #### Added
@@ -32,6 +48,14 @@
 #### Changed
 - Removed the usage of the deprecated combobox. The Dynamic Menu now uses the current combobox.
 
+### [Form Element](https://www.lightningdesignsystem.com/components/form-element)
+#### Fixed
+- Correctly position help text under the corresponding input when in horizontal layout.
+
+### [Input](https://www.lightningdesignsystem.com/components/input)
+#### Added
+- Created new class `slds-input_faux` to style read-only "inputs" where necessary for accessibility best practices, like combobox.
+
 ### [List Builder](https://www.lightningdesignsystem.com/components/list-builder)
 #### Changed
 - Removed the usage of the deprecated combobox. The List Builder now uses the current combobox.
@@ -43,7 +67,7 @@
 
 ### [Picklist](https://www.lightningdesignsystem.com/components/picklist)
 #### Changed
-Removed the usage of the deprecated combobox. The Picklist now uses the current combobox.
+- Removed the usage of the deprecated combobox. The Picklist now uses the current combobox.
 
 ### [Progress Bar](https://www.lightningdesignsystem.com/components/progress-bar)
 #### Added

ui/components/combobox/RELEASENOTES.md

@@ -8,7 +8,14 @@
 
 ### Changed
 
-- Updated to ARIA 1.2 compliance where these attributes are moved to the text input: `role="combobox"`, `aria-expanded`, `aria-haspopup="listbox"`.
+- Changed `slds-combobox__input` element from `input` to `button` per ARIA 1.2 guidance for select-only comboboxes.
+
+- Updated to ARIA 1.2 compliance where these attributes are moved to the input, or button in the case of select-only: `role="combobox"`, `aria-expanded`, `aria-haspopup="listbox"`.
+
+- Changed `@restrict` annotation of `.slds-combobox__input` from `.slds-combobox input` to `.slds-combobox__form-element input, .slds-combobox__form-element button`
+
+- Changed `@restrict` annotation of `.slds-combobox__input-value` from `.slds-combobox input` to `.slds-combobox__input`
+
 
 ## 2.13.1