Skip to content

Commit 40a26bb

Browse files
committed
Merge pull request #237 from salesforce-ux/im-exclude-react-dom-in-build-config
Don't bundle react with dist files
2 parents 73023f2 + 4833609 commit 40a26bb

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"lint": "eslint --config=./.eslintrc components",
99
"pages": "webpack --config webpack.config.github.js",
1010
"compile": "scripts/compile",
11+
"dist": "scripts/dist",
1112
"test": "scripts/test --single-run",
1213
"postinstall": "node scripts/postinstall",
1314
"icons": "node scripts/inline-icons.js",

scripts/compile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,5 @@ rm -rf lib/
44
mkdir -p lib/
55

66
BABEL="babel -d lib/ components/"
7-
BUILD="webpack --devtool source-map --config webpack.config.build.js"
87

98
eval $BABEL
10-
#eval $BUILD
11-
#eval "MINIFY=1 $BUILD"

scripts/dist

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
rm -rf dist/
2+
mkdir -p dist/
3+
4+
BUILD="webpack --devtool source-map --config webpack.config.build.js"
5+
6+
eval $BUILD
7+
eval "MINIFY=1 $BUILD"

webpack.config.build.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ module.exports = {
2525
},
2626
externals: {
2727
'react': 'React',
28+
'react-dom': 'ReactDOM',
2829
'react/addons': 'React'
2930
},
3031
resolve: {

0 commit comments

Comments
 (0)