fix: remove redundant optional chaining on process.env which is breaking testing (#5459)

jhefferman-sfdc · web-flow · commit 6ce708ae869e · 2025-08-15T10:11:30.000-06:00
* fix: remove redundant optional chaining on process.env which is breaking tests

* fix: remove redundant optional chaining on process.env which is breaking tests
diff --git a/packages/@lwc/ssr-client-utils/src/index.ts b/packages/@lwc/ssr-client-utils/src/index.ts
@@ -62,6 +62,12 @@ export function registerLwcStyleComponent() {
 }
 
 // Only used in LWC's Karma tests
-if (typeof process !== 'undefined' && process?.env?.NODE_ENV === 'test-karma-lwc') {
+// See PR-5281 for precedence on extra guards
+if (
+    typeof process === 'object' &&
+    typeof process?.env === 'object' &&
+    process.env &&
+    process.env.NODE_ENV === 'test-karma-lwc'
+) {
     (window as any).__lwcClearStylesheetCache = () => stylesheetCache.clear();
 }

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,12 @@ export function registerLwcStyleComponent() {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`// Only used in LWC's Karma tests`
`65`		`-if (typeof process !== 'undefined' && process?.env?.NODE_ENV === 'test-karma-lwc') {`
	`65`	`+// See PR-5281 for precedence on extra guards`
	`66`	`+if (`
	`67`	`+ typeof process === 'object' &&`
	`68`	`+ typeof process?.env === 'object' &&`
	`69`	`+ process.env &&`
	`70`	`+ process.env.NODE_ENV === 'test-karma-lwc'`
	`71`	`+) {`
`66`	`72`	`(window as any).__lwcClearStylesheetCache = () => stylesheetCache.clear();`
`67`	`73`	`}`