chore: bump vitest deps (#5622)

* chore: bump vitest deps

* chore: fix linting errors

Author: jmsjtu

package.json

@@ -34,9 +34,6 @@
         "release:publish": "./scripts/release/publish.sh",
         "release:publish:canary": "nx release publish --registry https://registry.npmjs.org --tag canary"
     },
-    "//": {
-        "vitest": "Pinning to v3.2.4 since v4 upgrade is breaking some tests"
-    },
     "devDependencies": {
         "@commitlint/cli": "^20.1.0",
         "@eslint/js": "9.39.1",
@@ -53,10 +50,10 @@
         "@swc/helpers": "~0.5.17",
         "@types/babel__core": "^7.20.5",
         "@types/node": "^22.19.1",
-        "@vitest/coverage-v8": "3.2.4",
-        "@vitest/eslint-plugin": "1.4.3",
-        "@vitest/spy": "4.0.13",
-        "@vitest/ui": "3.2.4",
+        "@vitest/coverage-v8": "4.0.14",
+        "@vitest/eslint-plugin": "1.5.1",
+        "@vitest/spy": "4.0.14",
+        "@vitest/ui": "4.0.14",
         "bytes": "^3.1.2",
         "es-module-lexer": "^1.7.0",
         "eslint": "9.39.1",
@@ -77,7 +74,7 @@
         "tslib": "^2.8.1",
         "typescript": "5.8.2",
         "typescript-eslint": "8.47.0",
-        "vitest": "3.2.4"
+        "vitest": "4.0.14"
     },
     "lint-staged": {
         "*.{js,mjs,ts,only,skip}": "eslint --cache",

packages/@lwc/compiler/src/transformers/__tests__/transform-html.spec.ts

@@ -79,11 +79,7 @@ describe('transformSync', () => {
                 ...config,
             });
             expect(warnings!.length).toBe(0);
-            if (expected) {
-                expect(code).toContain('<img');
-            } else {
-                expect(code).not.toContain('<img');
-            }
+            expect(code.includes('<img')).toBe(expected);
         });
     });
 

packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts

@@ -60,11 +60,8 @@ describe('object rest spread', () => {
             });
 
             expect(code).toContain('b: 1');
-            if (apiVersion === 59) {
-                expect(code).not.toContain('...a');
-            } else {
-                expect(code).toContain('...a');
-            }
+            const shouldContainSpread = apiVersion !== 59;
+            expect(code.includes('...a')).toBe(shouldContainSpread);
         });
     });
 });

packages/@lwc/errors/src/compiler/__tests__/error-info.spec.ts

@@ -65,13 +65,15 @@ it('errors with strictLevel have correct DiagnosticLevel.Fatal value', () => {
 
     // Check GENERIC_COMPILER_ERROR
     if (fatalErrorCodes.includes(GENERIC_COMPILER_ERROR.code)) {
+        // eslint-disable-next-line vitest/no-conditional-expect
         expect(GENERIC_COMPILER_ERROR.strictLevel).toBe(DiagnosticLevel.Fatal);
     }
 
     // Check all other errors
     Object.entries(errors).forEach(([_key, map]) => {
         Object.entries(map).forEach(([_label, info]) => {
             if (fatalErrorCodes.includes(info.code)) {
+                // eslint-disable-next-line vitest/no-conditional-expect
                 expect(info.strictLevel).toBe(DiagnosticLevel.Fatal);
             }
         });

packages/@lwc/features/src/__tests__/setFeatureFlag.spec.ts

@@ -36,10 +36,13 @@ describe('setFeatureFlag', () => {
                     // @ts-expect-error Explicitly testing JS behavior that violates TS types
                     setFeatureFlag('PLACEHOLDER_TEST_FLAG', 'foo');
                 };
+
                 if (env === 'production') {
                     callback();
+                    // eslint-disable-next-line vitest/no-conditional-expect
                     expect(error).toHaveBeenCalledExactlyOnceWith(expectedError);
                 } else {
+                    // eslint-disable-next-line vitest/no-conditional-expect
                     expect(callback).toThrowError(expectedError);
                 }
 
@@ -64,12 +67,16 @@ describe('setFeatureFlag', () => {
                 expect(lwcRuntimeFlags.PLACEHOLDER_TEST_FLAG).toEqual(true);
                 setFeatureFlag('PLACEHOLDER_TEST_FLAG', false);
                 if (env === 'production') {
+                    // eslint-disable-next-line vitest/no-conditional-expect
                     expect(error).toHaveBeenCalledExactlyOnceWith(
                         'Failed to set the value "false" for the runtime feature flag "PLACEHOLDER_TEST_FLAG". "PLACEHOLDER_TEST_FLAG" has already been set with the value "true".'
                     );
+                    // eslint-disable-next-line vitest/no-conditional-expect
                     expect(lwcRuntimeFlags.PLACEHOLDER_TEST_FLAG).toEqual(true);
                 } else {
+                    // eslint-disable-next-line vitest/no-conditional-expect
                     expect(error).not.toHaveBeenCalled();
+                    // eslint-disable-next-line vitest/no-conditional-expect
                     expect(lwcRuntimeFlags.PLACEHOLDER_TEST_FLAG).toEqual(false);
                 }
             });

packages/@lwc/integration-wtr/package.json

@@ -17,8 +17,8 @@
         "@lwc/synthetic-shadow": "8.26.0",
         "@types/chai": "^5.2.3",
         "@types/jasmine": "^5.1.13",
-        "@vitest/expect": "^4.0.13",
-        "@vitest/spy": "^4.0.13",
+        "@vitest/expect": "^4.0.14",
+        "@vitest/spy": "^4.0.14",
         "@web/dev-server-import-maps": "^0.2.1",
         "@web/dev-server-rollup": "^0.6.4",
         "@web/test-runner": "^0.20.2",

packages/@lwc/rollup-plugin/src/__tests__/enableStaticContentOptimization/enableStaticContentOptimization.spec.ts

@@ -50,10 +50,6 @@ describe('enableStaticContentOptimization:', () => {
     it.for(configs)('$name', async ({ opts, expected }) => {
         const { code, warnings } = await runRollup('fixtures/basic/basic.js', opts);
         expect(warnings).toEqual([]);
-        if (expected) {
-            expect(code).toContain('<img');
-        } else {
-            expect(code).not.toContain('<img');
-        }
+        expect(code.includes('<img')).toBe(expected);
     });
 });

packages/@lwc/ssr-compiler/src/__tests__/dynamic-imports.spec.ts

@@ -50,6 +50,7 @@ describe('dynamic imports', () => {
             };
 
             if (strictSpecifier && !isStrict) {
+                // eslint-disable-next-line vitest/no-conditional-expect
                 expect(callback).toThrowError(/LWC1121/);
                 return;
             } else {
@@ -65,8 +66,10 @@ describe('dynamic imports', () => {
             ]);
 
             if (loader) {
+                // eslint-disable-next-line vitest/no-conditional-expect
                 expect(imports).toEqual(importsWithLoader);
             } else {
+                // eslint-disable-next-line vitest/no-conditional-expect
                 expect(imports).not.toEqual(importsWithLoader);
             }
         }

packages/@lwc/template-compiler/src/__tests__/index.spec.ts

@@ -79,11 +79,7 @@ describe('parse', () => {
             const template = `<template><img src="http://example.com/img.png" crossorigin="anonymous"></template>`;
             const { code, warnings } = compile(template, '', config);
             expect(warnings.length).toBe(0);
-            if (expected) {
-                expect(code).toContain('<img');
-            } else {
-                expect(code).not.toContain('<img');
-            }
+            expect(code.includes('<img')).toBe(expected);
         });
     });
 });

packages/lwc/__tests__/default-exports.spec.ts

@@ -66,7 +66,9 @@ describe('default exports are not forgotten', () => {
                 `^export \\{ default \\} from '@lwc/${pkg}';$`,
                 'm'
             );
+            // eslint-disable-next-line vitest/no-conditional-expect
             expect(readPackageFile(pkg, '.d.ts')).toMatch(exportDefaultFromPackage);
+            // eslint-disable-next-line vitest/no-conditional-expect
             expect(readPackageFile(pkg, '.js')).toMatch(exportDefaultFromPackage);
         }
     });