Removing default values for version

Author: DaisyModi

iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/client/IamClient.java

@@ -29,7 +29,7 @@
  *
  * // Create policy
  * PolicyDocument policy = PolicyDocument.builder()
- *     .version("2024-01-01")
+ *     .version("2012-10-17")  // Use provider-specific version (AWS example)
  *     .statement("StorageAccess")
  *         .effect("Allow")
  *         .addAction("storage:GetObject")

iam/iam-client/src/main/java/com/salesforce/multicloudj/iam/model/PolicyDocument.java

@@ -17,7 +17,7 @@
  * <p>Usage example:
  * <pre>
  * PolicyDocument policy = PolicyDocument.builder()
- *     .version("2024-01-01")
+ *     .version("2012-10-17")  // Use provider-specific version (AWS example)
  *     .statement("StorageAccess")
  *         .effect("Allow")
  *         .addAction("storage:GetObject")
@@ -76,7 +76,7 @@ public String toString() {
      * Builder class for PolicyDocument.
      */
     public static class Builder {
-        private String version = "2024-01-01";
+        private String version;
         private final List<Statement> statements = new ArrayList<>();
         private Statement.Builder currentStatementBuilder;
 
@@ -86,7 +86,7 @@ private Builder() {
         /**
          * Sets the policy version.
          *
-         * @param version the policy version (default: "2024-01-01")
+         * @param version the policy version (required)
          * @return this Builder instance
          */
         public Builder version(String version) {
@@ -232,10 +232,13 @@ public Builder addStatement(Statement statement) {
          * Builds and returns a PolicyDocument instance.
          *
          * @return a new PolicyDocument instance
-         * @throws InvalidArgumentException if no statements are defined
+         * @throws InvalidArgumentException if version or statements are missing
          */
         public PolicyDocument build() {
             finalizeCurrentStatement();
+            if (version == null || version.trim().isEmpty()) {
+                throw new InvalidArgumentException("version is required");
+            }
             if (statements.isEmpty()) {
                 throw new InvalidArgumentException("at least one statement is required");
             }

iam/iam-client/src/test/java/com/salesforce/multicloudj/iam/model/PolicyDocumentTest.java

@@ -15,6 +15,8 @@
  */
 public class PolicyDocumentTest {
 
+    private static final String TEST_VERSION = "TEST_VERSION";
+
     @Test
     public void testPolicyDocumentBuilder() {
         PolicyDocument policy = PolicyDocument.builder()
@@ -46,6 +48,7 @@ public void testPolicyDocumentBuilder() {
     @Test
     public void testMultipleStatements() {
         PolicyDocument policy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .statement("ReadAccess")
                 .effect("Allow")
                 .addAction("storage:GetObject")
@@ -73,6 +76,7 @@ public void testAddCompleteStatement() {
             .build();
 
         PolicyDocument policy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .addStatement(statement)
             .build();
 
@@ -87,10 +91,24 @@ public void testEmptyPolicyThrowsException() {
         });
     }
 
+    @Test
+    public void testMissingVersionThrowsException() {
+        assertThrows(InvalidArgumentException.class, () -> {
+            PolicyDocument.builder()
+                .statement("TestStatement")
+                    .effect("Allow")
+                    .addAction("storage:GetObject")
+                    .addResource("storage://test-bucket/*")
+                .endStatement()
+                .build();
+        });
+    }
+
     @Test
     public void testStatementWithoutEffectThrowsException() {
         assertThrows(InvalidArgumentException.class, () -> {
             PolicyDocument.builder()
+                .version(TEST_VERSION)
                 .statement("TestStatement")
                     .addAction("storage:GetObject")
                 .endStatement()
@@ -102,6 +120,7 @@ public void testStatementWithoutEffectThrowsException() {
     public void testStatementWithoutActionsThrowsException() {
         assertThrows(InvalidArgumentException.class, () -> {
             PolicyDocument.builder()
+                .version(TEST_VERSION)
                 .statement("TestStatement")
                     .effect("Allow")
                 .endStatement()
@@ -125,19 +144,21 @@ public void testVersionHandling() {
 
         // Test default version
         PolicyDocument defaultVersionPolicy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .statement("TestStatement")
                 .effect("Allow")
                 .addAction("storage:GetObject")
                 .addResource("storage://test-bucket/*")
             .endStatement()
             .build();
 
-        assertEquals("2024-01-01", defaultVersionPolicy.getVersion());
+        assertEquals(TEST_VERSION, defaultVersionPolicy.getVersion());
     }
 
     @Test
     public void testBuilderMethodsWithMultipleValues() {
         PolicyDocument policy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .statement("TestStatement")
                 .effect("Allow")
                 .addAction("storage:GetObject")
@@ -213,6 +234,7 @@ public void testBuilderStateValidation() {
     @Test
     public void testAddNullStatement() {
         PolicyDocument policy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .addStatement(null)
             .statement("ValidStatement")
                 .effect("Allow")
@@ -235,6 +257,7 @@ public void testMixingAddStatementAndBuilder() {
             .build();
 
         PolicyDocument policy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .addStatement(preBuiltStatement)
             .statement("BuiltInline")
                 .effect("Allow")
@@ -311,6 +334,7 @@ public void testPolicyDocumentToString() {
     public void testEndStatementWithoutCurrentStatement() {
         // endStatement() should be safe to call even when no statement is being built
         PolicyDocument policy = PolicyDocument.builder()
+            .version(TEST_VERSION)
             .endStatement() // This should do nothing
             .statement("TestStatement")
                 .effect("Allow")