chore: remove test cases and improve error handling

Author: EstebanRomero84

src/commands/agent/validate/authoring-bundle.ts

@@ -19,7 +19,6 @@ import { SfCommand, Flags } from '@salesforce/sf-plugins-core';
 import { Messages, SfError } from '@salesforce/core';
 import { MultiStageOutput } from '@oclif/multi-stage-output';
 import { Agent, findAuthoringBundle } from '@salesforce/agents';
-import { Duration, sleep } from '@salesforce/kit';
 import { colorize } from '@oclif/core/ux';
 import { throwAgentCompilationError } from '../../../common.js';
 import { FlaggablePrompt, promptForAgentFiles } from '../../../flags.js';
@@ -104,8 +103,6 @@ export default class AgentValidateAuthoringBundle extends SfCommand<AgentValidat
       mso.skipTo('Validating Authoring Bundle');
       const targetOrg = flags['target-org'];
       const conn = targetOrg.getConnection(flags['api-version']);
-      // Call Agent.compileAgent() API
-      await sleep(Duration.seconds(2));
       const result = await Agent.compileAgentScript(
         conn,
         readFileSync(join(authoringBundleDir, `${apiName}.agent`), 'utf8')
@@ -123,12 +120,13 @@ export default class AgentValidateAuthoringBundle extends SfCommand<AgentValidat
       // Handle validation errors
       const err = SfError.wrap(error);
       let count = 0;
-      const formattedError = err.message
+      const rawError = err.message ? err.message : err.name;
+      const formattedError = rawError
         .split('\n')
         .map((line) => {
           count += 1;
           const type = line.split(':')[0];
-          const rest = line.substring(line.indexOf(':')).trim();
+          const rest = line.includes(':') ? line.substring(line.indexOf(':')).trim() : '';
           return `- ${colorize('red', type)}${rest}`;
         })
         .join('\n');

test/commands/agent/validate/authoring-bundle.test.ts

@@ -23,57 +23,11 @@ import AgentValidateAuthoringBundle, {
 import { throwAgentCompilationError } from '../../../../src/common.js';
 
 describe('Agent Validate Authoring Bundle', () => {
-  describe('command configuration', () => {
-    it('should have correct summary', () => {
-      expect(AgentValidateAuthoringBundle.summary).to.equal('Validate an Agent Authoring Bundle');
-    });
-
-    it('should require project', () => {
-      expect(AgentValidateAuthoringBundle.requiresProject).to.be.true;
-    });
-
-    it('should have correct flags', () => {
-      const flags = AgentValidateAuthoringBundle.flags;
-      expect(flags).to.have.property('target-org');
-      expect(flags).to.have.property('api-version');
-      expect(flags).to.have.property('api-name');
-    });
-  });
-
-  describe('flag validation', () => {
-    it('should validate API name format', () => {
-      const prompts = AgentValidateAuthoringBundle['FLAGGABLE_PROMPTS'];
-
-      // Valid API names
-      expect(prompts['api-name'].validate('ValidApiName')).to.equal(true);
-      expect(prompts['api-name'].validate('Valid_Api_Name_123')).to.equal(true);
-      expect(prompts['api-name'].validate('aa')).to.equal(true);
-      expect(prompts['api-name'].validate('MyAgent_Test_1')).to.equal(true);
-
-      // Invalid API names - empty
-      expect(prompts['api-name'].validate('')).to.equal('Invalid API name.');
-
-      // Invalid API names - starts with invalid character
-      expect(prompts['api-name'].validate('Invalid-Name')).to.equal('Invalid API name.');
-      expect(prompts['api-name'].validate('123StartsWithNumber')).to.equal('Invalid API name.');
-      expect(prompts['api-name'].validate('_StartsWithUnderscore')).to.equal('Invalid API name.');
-      expect(prompts['api-name'].validate('-StartsWithDash')).to.equal('Invalid API name.');
-
-      // Invalid API names - too long
-      expect(prompts['api-name'].validate('a'.repeat(81))).to.equal('API name cannot be over 80 characters.');
-
-      // Invalid API names - invalid characters
-      expect(prompts['api-name'].validate('Invalid.Name')).to.equal('Invalid API name.');
-      expect(prompts['api-name'].validate('Invalid Name')).to.equal('Invalid API name.');
-      expect(prompts['api-name'].validate('Invalid@Name')).to.equal('Invalid API name.');
-    });
-  });
-
   describe('prompt configuration', () => {
     it('should have correct prompt messages', () => {
       const prompts = AgentValidateAuthoringBundle['FLAGGABLE_PROMPTS'];
 
-      expect(prompts['api-name'].message).to.equal('API name of the Agent Authoring Bundle to validate.');
+      expect(prompts['api-name'].message).to.equal('API name of the authoring bundle you want to validate.');
       expect(prompts['api-name'].promptMessage).to.equal('API name of the authoring bundle to validate');
     });
   });