Merge pull request #273 from salesforcecli/devScripts2023-11-05

refactor: devScripts update

Author: svc-cli-bot

package.json

@@ -16,37 +16,17 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^4.0.16",
     "@salesforce/cli-plugins-testkit": "^4.4.10",
-    "@salesforce/dev-config": "^4.1.0",
-    "@salesforce/dev-scripts": "^5.12.2",
+    "@salesforce/dev-scripts": "^6.0.3",
     "@salesforce/plugin-command-reference": "^3.0.45",
     "@salesforce/plugin-deploy-retrieve": "^1.19.0",
-    "@salesforce/prettier-config": "^0.0.3",
     "@salesforce/ts-sinon": "^1.4.17",
     "@salesforce/ts-types": "^2.0.7",
     "@swc/core": "1.3.30",
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.62.0",
-    "chai": "^4.3.10",
-    "eslint": "^8.53.0",
-    "eslint-config-prettier": "^8.10.0",
-    "eslint-config-salesforce": "^2.0.2",
-    "eslint-config-salesforce-license": "^0.2.0",
-    "eslint-config-salesforce-typescript": "^2.0.0",
-    "eslint-plugin-header": "^3.1.1",
-    "eslint-plugin-import": "^2.29.0",
-    "eslint-plugin-jsdoc": "^46.8.2",
     "eslint-plugin-sf-plugin": "^1.16.12",
-    "husky": "^7.0.4",
-    "mocha": "^9.1.3",
-    "nyc": "^15.1.0",
     "oclif": "^3.17.2",
-    "prettier": "^2.8.8",
-    "pretty-quick": "^3.1.0",
     "shx": "^0.3.4",
-    "sinon": "10.0.0",
-    "ts-node": "^10.0.0",
-    "typescript": "^5.2.2",
-    "wireit": "^0.14.1"
+    "ts-node": "^10.9.1",
+    "typescript": "^5.2.2"
   },
   "engines": {
     "node": ">=16.0.0"

src/commands/apex/run/test.ts

@@ -234,18 +234,22 @@ const validateFlags = async (
   synchronous?: boolean,
   testLevel?: TestLevel
 ): Promise<TestLevel> => {
-  if (synchronous && (suiteNames || (classNames?.length && classNames.length > 1))) {
+  if (synchronous && (Boolean(suiteNames) || (classNames?.length && classNames.length > 1))) {
     return Promise.reject(new Error(messages.getMessage('syncClassErr')));
   }
 
-  if ((tests || classNames || suiteNames) && testLevel && testLevel !== 'RunSpecifiedTests') {
+  if (
+    (Boolean(tests) || Boolean(classNames) || suiteNames) &&
+    testLevel &&
+    testLevel.toString() !== 'RunSpecifiedTests'
+  ) {
     return Promise.reject(new Error(messages.getMessage('testLevelErr')));
   }
 
   if (testLevel) {
     return testLevel;
   }
-  if (classNames || suiteNames || tests) {
+  if (Boolean(classNames) || Boolean(suiteNames) || tests) {
     return TestLevel.RunSpecifiedTests;
   }
   return TestLevel.RunLocalTests;

src/reporters/testReporter.ts

@@ -5,7 +5,6 @@
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
 import {
-  ApexTestRunResultStatus,
   HumanReporter,
   JUnitReporter,
   OutputDirConfig,
@@ -64,7 +63,7 @@ export class TestReporter {
     }
 
     try {
-      if (result.summary && result.summary.outcome === ApexTestRunResultStatus.Failed) {
+      if (result.summary && result.summary.outcome === 'Failed') {
         process.exitCode = FAILURE_EXIT_CODE;
       }
       switch (options['result-format']) {