Skip to content

Commit 6182906

Browse files
chore: fix bug
2 parents 9f56c4d + 903a481 commit 6182906

File tree

6 files changed

+77
-46
lines changed

6 files changed

+77
-46
lines changed

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,21 @@
1+
## [3.22.22](https://github.com/salesforcecli/plugin-deploy-retrieve/compare/3.22.21...3.22.22) (2025-06-07)
2+
3+
### Bug Fixes
4+
5+
- **deps:** bump @salesforce/plugin-info from 3.4.63 to 3.4.65 ([941ee6f](https://github.com/salesforcecli/plugin-deploy-retrieve/commit/941ee6f500649fd463f409c93ab1cbefffcc2947))
6+
7+
## [3.22.21](https://github.com/salesforcecli/plugin-deploy-retrieve/compare/3.22.20...3.22.21) (2025-06-07)
8+
9+
### Bug Fixes
10+
11+
- **deps:** bump @salesforce/source-tracking from 7.3.25 to 7.4.0 ([20e60bf](https://github.com/salesforcecli/plugin-deploy-retrieve/commit/20e60bf2ae71a141397c6d6be0517328dd1cef7a))
12+
13+
## [3.22.20](https://github.com/salesforcecli/plugin-deploy-retrieve/compare/3.22.19...3.22.20) (2025-06-07)
14+
15+
### Bug Fixes
16+
17+
- **deps:** bump @salesforce/apex-node from 8.1.29 to 8.1.30 ([4abdbd0](https://github.com/salesforcecli/plugin-deploy-retrieve/commit/4abdbd0f355b36a4b4ed8181d9dd9c3bf8c7606e))
18+
119
## [3.22.19](https://github.com/salesforcecli/plugin-deploy-retrieve/compare/3.22.18...3.22.19) (2025-05-31)
220

321
### Bug Fixes

README.md

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ FLAG DESCRIPTIONS
141141
If you specify this flag, don’t specify --metadata or --source-dir.
142142
```
143143

144-
_See code: [src/commands/project/convert/mdapi.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/convert/mdapi.ts)_
144+
_See code: [src/commands/project/convert/mdapi.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/convert/mdapi.ts)_
145145

146146
## `sf project convert source`
147147

@@ -214,7 +214,7 @@ FLAG DESCRIPTIONS
214214
Override the api version used for api requests made by this command
215215
```
216216

217-
_See code: [src/commands/project/convert/source.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/convert/source.ts)_
217+
_See code: [src/commands/project/convert/source.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/convert/source.ts)_
218218

219219
## `sf project convert source-behavior`
220220

@@ -273,7 +273,7 @@ EXAMPLES
273273
$ sf project convert source-behavior --behavior decomposePermissionSetBeta --dry-run --preserve-temp-dir
274274
```
275275

276-
_See code: [src/commands/project/convert/source-behavior.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/convert/source-behavior.ts)_
276+
_See code: [src/commands/project/convert/source-behavior.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/convert/source-behavior.ts)_
277277

278278
## `sf project delete source`
279279

@@ -413,7 +413,7 @@ FLAG DESCRIPTIONS
413413
- Separate the test names with spaces: --tests Test1 Test2 "Test With Space"
414414
```
415415

416-
_See code: [src/commands/project/delete/source.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/delete/source.ts)_
416+
_See code: [src/commands/project/delete/source.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/delete/source.ts)_
417417

418418
## `sf project delete tracking`
419419

@@ -450,7 +450,7 @@ EXAMPLES
450450
$ sf project delete tracking --target-org my-scratch
451451
```
452452

453-
_See code: [src/commands/project/delete/tracking.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/delete/tracking.ts)_
453+
_See code: [src/commands/project/delete/tracking.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/delete/tracking.ts)_
454454

455455
## `sf project deploy cancel`
456456

@@ -522,7 +522,7 @@ FLAG DESCRIPTIONS
522522
project deploy report".
523523
```
524524

525-
_See code: [src/commands/project/deploy/cancel.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/cancel.ts)_
525+
_See code: [src/commands/project/deploy/cancel.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/cancel.ts)_
526526

527527
## `sf project deploy preview`
528528

@@ -605,7 +605,7 @@ FLAG DESCRIPTIONS
605605
All child components are included. If you specify this flag, don’t specify --metadata or --source-dir.
606606
```
607607

608-
_See code: [src/commands/project/deploy/preview.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/preview.ts)_
608+
_See code: [src/commands/project/deploy/preview.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/preview.ts)_
609609

610610
## `sf project deploy quick`
611611

@@ -689,7 +689,7 @@ FLAG DESCRIPTIONS
689689
deploy report".
690690
```
691691

692-
_See code: [src/commands/project/deploy/quick.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/quick.ts)_
692+
_See code: [src/commands/project/deploy/quick.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/quick.ts)_
693693

694694
## `sf project deploy report`
695695

@@ -781,7 +781,7 @@ FLAG DESCRIPTIONS
781781
--coverage-formatters lcov --coverage-formatters clover
782782
```
783783

784-
_See code: [src/commands/project/deploy/report.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/report.ts)_
784+
_See code: [src/commands/project/deploy/report.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/report.ts)_
785785

786786
## `sf project deploy resume`
787787

@@ -866,7 +866,7 @@ FLAG DESCRIPTIONS
866866
--coverage-formatters lcov --coverage-formatters clover
867867
```
868868

869-
_See code: [src/commands/project/deploy/resume.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/resume.ts)_
869+
_See code: [src/commands/project/deploy/resume.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/resume.ts)_
870870

871871
## `sf project deploy start`
872872

@@ -1102,7 +1102,7 @@ FLAG DESCRIPTIONS
11021102
--coverage-formatters lcov --coverage-formatters clover
11031103
```
11041104

1105-
_See code: [src/commands/project/deploy/start.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/start.ts)_
1105+
_See code: [src/commands/project/deploy/start.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/start.ts)_
11061106

11071107
## `sf project deploy validate`
11081108

@@ -1275,7 +1275,7 @@ FLAG DESCRIPTIONS
12751275
--coverage-formatters lcov --coverage-formatters clover
12761276
```
12771277

1278-
_See code: [src/commands/project/deploy/validate.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/deploy/validate.ts)_
1278+
_See code: [src/commands/project/deploy/validate.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/deploy/validate.ts)_
12791279

12801280
## `sf project generate manifest`
12811281

@@ -1371,7 +1371,7 @@ EXAMPLES
13711371
$ sf project generate manifest --from-org [email protected] --excluded-metadata StandardValueSet
13721372
```
13731373

1374-
_See code: [src/commands/project/generate/manifest.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/generate/manifest.ts)_
1374+
_See code: [src/commands/project/generate/manifest.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/generate/manifest.ts)_
13751375

13761376
## `sf project list ignored`
13771377

@@ -1413,7 +1413,7 @@ EXAMPLES
14131413
$ sf project list ignored --source-dir package.xml
14141414
```
14151415

1416-
_See code: [src/commands/project/list/ignored.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/list/ignored.ts)_
1416+
_See code: [src/commands/project/list/ignored.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/list/ignored.ts)_
14171417

14181418
## `sf project reset tracking`
14191419

@@ -1462,7 +1462,7 @@ EXAMPLES
14621462
$ sf project reset tracking --revision 30
14631463
```
14641464

1465-
_See code: [src/commands/project/reset/tracking.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/reset/tracking.ts)_
1465+
_See code: [src/commands/project/reset/tracking.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/reset/tracking.ts)_
14661466

14671467
## `sf project retrieve preview`
14681468

@@ -1516,7 +1516,7 @@ FLAG DESCRIPTIONS
15161516
production orgs.
15171517
```
15181518

1519-
_See code: [src/commands/project/retrieve/preview.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/retrieve/preview.ts)_
1519+
_See code: [src/commands/project/retrieve/preview.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/retrieve/preview.ts)_
15201520

15211521
## `sf project retrieve start`
15221522

@@ -1689,6 +1689,6 @@ FLAG DESCRIPTIONS
16891689
If you specify this flag, don’t specify --metadata or --source-dir.
16901690
```
16911691

1692-
_See code: [src/commands/project/retrieve/start.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.19/src/commands/project/retrieve/start.ts)_
1692+
_See code: [src/commands/project/retrieve/start.ts](https://github.com/salesforcecli/plugin-deploy-retrieve/blob/3.22.22/src/commands/project/retrieve/start.ts)_
16931693

16941694
<!-- commandsstop -->

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"name": "@salesforce/plugin-deploy-retrieve",
33
"description": "deploy and retrieve commands for sf",
4-
"version": "3.22.19",
4+
"version": "3.22.22",
55
"author": "Salesforce",
66
"bugs": "https://github.com/forcedotcom/cli/issues",
77
"dependencies": {
88
"@inquirer/prompts": "^7.5.3",
99
"@oclif/core": "^4.3.0",
1010
"@oclif/multi-stage-output": "^0.8.13",
11-
"@salesforce/apex-node": "^8.1.29",
11+
"@salesforce/apex-node": "^8.1.30",
1212
"@salesforce/core": "^8.11.1",
1313
"@salesforce/kit": "^3.2.3",
14-
"@salesforce/plugin-info": "^3.4.63",
14+
"@salesforce/plugin-info": "^3.4.65",
1515
"@salesforce/sf-plugins-core": "^12.2.2",
1616
"@salesforce/source-deploy-retrieve": "^12.19.7",
17-
"@salesforce/source-tracking": "^7.3.25",
17+
"@salesforce/source-tracking": "^7.4.0",
1818
"@salesforce/ts-types": "^2.0.12",
1919
"ansis": "^3.17.0",
2020
"terminal-link": "^3.0.0"
@@ -29,7 +29,7 @@
2929
"@salesforce/ts-sinon": "^1.4.30",
3030
"cross-env": "^7.0.3",
3131
"eslint-plugin-sf-plugin": "^1.20.24",
32-
"oclif": "^4.17.46",
32+
"oclif": "^4.18.0",
3333
"ts-node": "^10.9.2",
3434
"typescript": "^5.8.3"
3535
},

src/utils/deploy.ts

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -141,16 +141,20 @@ export async function executeDeploy(
141141
await deploy.start();
142142
}
143143
} else {
144-
// instantiate source tracking
145-
// stl will decide, based on the org's properties, what needs to be done
146-
const stl = await SourceTracking.create({
147-
org,
148-
// mdapi format deploys don't require a project, but at this point we need one
149-
project: project ?? (await SfProject.resolve()),
150-
subscribeSDREvents: true,
151-
ignoreConflicts: opts['ignore-conflicts'],
152-
});
153-
registry = stl.registry;
144+
let stl: SourceTracking | undefined;
145+
if (!opts['source-dir'] && !opts.manifest && !opts.metadata && !opts['dry-run']) {
146+
// instantiate source tracking
147+
// stl will decide, based on the org's properties, what needs to be done
148+
stl = await SourceTracking.create({
149+
org,
150+
// mdapi format deploys don't require a project, but at this point we need one
151+
project: project ?? (await SfProject.resolve()),
152+
subscribeSDREvents: true,
153+
ignoreConflicts: opts['ignore-conflicts'],
154+
});
155+
registry = stl.registry;
156+
}
157+
154158
componentSet = await buildComponentSet(opts, stl);
155159
if (componentSet.size === 0) {
156160
if (opts['source-dir'] ?? opts.manifest ?? opts.metadata ?? throwOnEmpty) {

test/commands/deploy/metadata.nut.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77

88
import { fileURLToPath } from 'node:url';
99
import { SourceTestkit } from '@salesforce/source-testkit';
10+
import { execCmd } from '@salesforce/cli-plugins-testkit';
11+
import { expect } from 'chai';
12+
import { type DeployResultJson } from '../../../src/utils/types.js';
1013

1114
describe('deploy metadata NUTs', () => {
1215
let testkit: SourceTestkit;
@@ -27,6 +30,12 @@ describe('deploy metadata NUTs', () => {
2730
await testkit.deploy({ args: '--source-dir force-app' });
2831
await testkit.expect.filesToBeDeployed(['force-app/**/*'], ['force-app/test/**/*']);
2932
});
33+
34+
it('--source-dir --dry-run should NOT affect source-tracking', async () => {
35+
execCmd('project:deploy:start --dry-run --source-dir force-app', { ensureExitCode: 0 });
36+
const actual = execCmd<DeployResultJson>('project:deploy:start --json', { ensureExitCode: 0 }).jsonOutput; // should deploy everything since previous attempt was --dry-run
37+
expect(actual?.result?.numberComponentsDeployed).to.be.greaterThan(1);
38+
});
3039
});
3140

3241
describe('--metadata flag', () => {

yarn.lock

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1422,7 +1422,7 @@
14221422
resolved "https://registry.yarnpkg.com/@rtsao/scc/-/scc-1.1.0.tgz#927dd2fae9bc3361403ac2c7a00c32ddce9ad7e8"
14231423
integrity sha512-zt6OdqaDoOnJ1ZYsCYGt9YmWzDXl4vQdKTyJev62gFhRGKdx7mcT54V9KIjg+d2wi9EXsPvAPKe7i7WjfVWB8g==
14241424

1425-
"@salesforce/apex-node@^8.1.29":
1425+
"@salesforce/apex-node@^8.1.30":
14261426
version "8.1.30"
14271427
resolved "https://registry.yarnpkg.com/@salesforce/apex-node/-/apex-node-8.1.30.tgz#6a746561394f39f8e2b4935e2449f0ea1d08bf5c"
14281428
integrity sha512-9djBW0ZvLWHLAfFjc8zagdCXkjFesTcgDTPsvQQfZX8TJYsq/WjgeoIooC8QxRLlxH1neUK7pgNAbKKrP7t5XQ==
@@ -1453,7 +1453,7 @@
14531453
strip-ansi "6.0.1"
14541454
ts-retry-promise "^0.8.1"
14551455

1456-
"@salesforce/core@^8.10.0", "@salesforce/core@^8.11.0", "@salesforce/core@^8.11.1", "@salesforce/core@^8.11.2", "@salesforce/core@^8.11.4", "@salesforce/core@^8.5.1", "@salesforce/core@^8.8.0", "@salesforce/core@^8.9.1":
1456+
"@salesforce/core@^8.10.0", "@salesforce/core@^8.11.0", "@salesforce/core@^8.11.1", "@salesforce/core@^8.11.2", "@salesforce/core@^8.11.4", "@salesforce/core@^8.12.0", "@salesforce/core@^8.5.1", "@salesforce/core@^8.8.0":
14571457
version "8.12.0"
14581458
resolved "https://registry.yarnpkg.com/@salesforce/core/-/core-8.12.0.tgz#a458cc3e39f4e7df57d94f0deaaa0fd0660b18c9"
14591459
integrity sha512-LJIjoQ3UQJ1r/xxdQcaG5bU8MfxeO/LJhrfK/7LZeHVtp1iOIgedbwPuVNzTzYciDWh8elborarrPM4uWjtu5g==
@@ -1535,7 +1535,7 @@
15351535
debug "^4.4.1"
15361536
handlebars "^4.7.8"
15371537

1538-
"@salesforce/plugin-info@^3.4.63":
1538+
"@salesforce/plugin-info@^3.4.65":
15391539
version "3.4.65"
15401540
resolved "https://registry.yarnpkg.com/@salesforce/plugin-info/-/plugin-info-3.4.65.tgz#b2f21f16a40d1ebee874a32685b9ea3b51e8d2a1"
15411541
integrity sha512-77SzHkJrQh8IXpcJ97th6yXsAgeXPJbGJtjbHgKmf5zZKqOCuWNtMnIi2plgmoh+S9m+zS4nqlJ81o5VBu8ACg==
@@ -1597,10 +1597,10 @@
15971597
cli-progress "^3.12.0"
15981598
terminal-link "^3.0.0"
15991599

1600-
"@salesforce/source-deploy-retrieve@^12.19.6", "@salesforce/source-deploy-retrieve@^12.19.7":
1601-
version "12.19.8"
1602-
resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-12.19.8.tgz#68432867e35beb97a1572713ecbdd5e4a93bd4ce"
1603-
integrity sha512-CcjBReC3riYFYWXUaUn0Y0iis8PwEDl1dJclBv7kpTzMmxh7AP4PL0PFpL2lfD9ASdV21KhCriQo0/xO1ZhznA==
1600+
"@salesforce/source-deploy-retrieve@^12.19.7", "@salesforce/source-deploy-retrieve@^12.19.9":
1601+
version "12.19.9"
1602+
resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-12.19.9.tgz#4754aaf466ce34cb02546ec6eab9541c1dab86f9"
1603+
integrity sha512-LDM/vqedj6T/Ybs2dKShqdTUizp2psKboBo03Ak9ha006gA+5/yde7nq5zY9hRdn/aw4hs74+X0TCRcxMh4dOw==
16041604
dependencies:
16051605
"@salesforce/core" "^8.11.4"
16061606
"@salesforce/kit" "^3.2.3"
@@ -1634,15 +1634,15 @@
16341634
shelljs "^0.10.0"
16351635
sinon "^10.0.0"
16361636

1637-
"@salesforce/source-tracking@^7.3.25":
1638-
version "7.3.25"
1639-
resolved "https://registry.yarnpkg.com/@salesforce/source-tracking/-/source-tracking-7.3.25.tgz#057b70c240b450e9319dc6cd2e732d5f0aae959e"
1640-
integrity sha512-vph1inQMkwFhAqxquHy/Woq0uQqFiFyVm59DmXJLZQxj25fxqFhQsbY22jCSidEug8ctj4IyaCJB1Ot/eShozw==
1637+
"@salesforce/source-tracking@^7.4.0":
1638+
version "7.4.0"
1639+
resolved "https://registry.yarnpkg.com/@salesforce/source-tracking/-/source-tracking-7.4.0.tgz#4f4ea0769acd0fed921f25af851d668e6678da5e"
1640+
integrity sha512-anyWxkic7lIpyLq606kfjyF0CaryBJaLCQZ/YSufWEvQEJ5/DhNQotHP4+VAUxuLFCpLsK7sR0xKwwpzUAC40A==
16411641
dependencies:
16421642
"@oclif/core" "^4.2.10"
1643-
"@salesforce/core" "^8.9.1"
1643+
"@salesforce/core" "^8.12.0"
16441644
"@salesforce/kit" "^3.2.3"
1645-
"@salesforce/source-deploy-retrieve" "^12.19.6"
1645+
"@salesforce/source-deploy-retrieve" "^12.19.9"
16461646
"@salesforce/ts-types" "^2.0.12"
16471647
fast-xml-parser "^4.5.3"
16481648
graceful-fs "^4.2.11"
@@ -6766,7 +6766,7 @@ object.values@^1.2.0:
67666766
define-properties "^1.2.1"
67676767
es-object-atoms "^1.0.0"
67686768

6769-
oclif@^4.17.46:
6769+
oclif@^4.18.0:
67706770
version "4.18.0"
67716771
resolved "https://registry.yarnpkg.com/oclif/-/oclif-4.18.0.tgz#4216a87ae947ae233a92f94448e970fce621b11a"
67726772
integrity sha512-w5b35fT1tIZhJUv+GZLdEo4ZwF/wDeuNVL1cbOcgrQebcg0RMJE0ykFymVlfIPtOZqJzwfO6xeNEwqMy5fVtOw==

0 commit comments

Comments
 (0)