fix(deps): Switch back to non-shortened @heroku/functions-core dependency name (#595)

In #403 and heroku/sf-functions-core#22 various
measures were taken to try and shorten the maximum on-disk filepath of files
in the two packages, so as to prevent the CI failures seen in:
https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514

One of these measure was to use a package alias of `@hk/functions-core` for the
`@heroku/functions-core` package, so the on-disk directory path was 4 characters
shorter.

However, this change stops Dependabot from working, and looking at recent tarfile
verification logs in CI, it appears we might not need to save these four characters any
more - since none of the salesforce-core dep paths appear in the "close to the limit"
warnings.

As such, we can undo this aliasing, to fix Dependabot for this package.

@W-12466399@

Author: edmorley

package.json

@@ -12,8 +12,8 @@
     "@heroku-cli/schema": "^1.0.25",
     "@heroku/eventsource": "^1.0.7",
     "@heroku/function-toml": "^0.0.3",
+    "@heroku/functions-core": "^0.5.5",
     "@heroku/project-descriptor": "0.0.6",
-    "@hk/functions-core": "npm:@heroku/functions-core@^0.5.3",
     "@oclif/core": "^1.26.1",
     "@salesforce/core": "^3.32.12",
     "@salesforce/sf-plugins-core": "^1.22.3",

src/commands/generate/function.ts

@@ -7,7 +7,7 @@
 import herokuColor from '@heroku-cli/color';
 import { Messages } from '@salesforce/core';
 import { Errors, Flags } from '@oclif/core';
-import { generateFunction, Language } from '@hk/functions-core';
+import { generateFunction, Language } from '@heroku/functions-core';
 import Command from '../../lib/base';
 
 Messages.importMessagesDirectory(__dirname);

src/commands/run/function.ts

@@ -6,7 +6,7 @@
  */
 import * as fs from 'fs';
 import { Errors, Flags } from '@oclif/core';
-import { runFunction, RunFunctionOptions } from '@hk/functions-core';
+import { runFunction, RunFunctionOptions } from '@heroku/functions-core';
 import { cli } from 'cli-ux';
 import herokuColor from '@heroku-cli/color';
 import { AxiosResponse, AxiosError } from 'axios';

src/commands/run/function/start/container.ts

@@ -8,7 +8,7 @@ import * as path from 'path';
 import herokuColor from '@heroku-cli/color';
 import { Messages } from '@salesforce/core';
 import { Command, Flags } from '@oclif/core';
-import { getFunctionsBinary, getProjectDescriptor } from '@hk/functions-core';
+import { getFunctionsBinary, getProjectDescriptor } from '@heroku/functions-core';
 import { cli } from 'cli-ux';
 import { JsonMap } from '@salesforce/ts-types';
 

src/commands/run/function/start/local.ts

@@ -7,9 +7,9 @@
 import * as path from 'path';
 import * as process from 'process';
 import { Command, Flags } from '@oclif/core';
-import { LocalRun } from '@hk/functions-core';
+import { LocalRun } from '@heroku/functions-core';
 import { Messages } from '@salesforce/core';
-import { LangRunnerOpts } from '@hk/functions-core/dist/lang-runner';
+import { LangRunnerOpts } from '@heroku/functions-core/dist/lang-runner';
 
 Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/plugin-functions', 'run.function.start.local');

test/commands/generate/function.test.ts

@@ -6,7 +6,7 @@
  */
 import { expect, test } from '@oclif/test';
 import * as sinon from 'sinon';
-import * as library from '@hk/functions-core';
+import * as library from '@heroku/functions-core';
 import vacuum from '../../helpers/vacuum';
 
 describe('sf generate function', () => {

test/commands/run/function.test.ts

@@ -11,7 +11,7 @@ import { cli } from 'cli-ux';
 import { MockTestOrgData, testSetup } from '@salesforce/core/lib/testSetup';
 import * as sinon from 'sinon';
 
-import * as library from '@hk/functions-core';
+import * as library from '@heroku/functions-core';
 import vacuum from '../../helpers/vacuum';
 
 describe('sf run function', () => {

test/commands/run/function/start.test.ts

@@ -9,7 +9,7 @@ import { EventEmitter } from 'events';
 import { Readable } from 'stream';
 import { expect, test } from '@oclif/test';
 import * as sinon from 'sinon';
-import { LocalRun, LocalRunProcess } from '@hk/functions-core';
+import { LocalRun, LocalRunProcess } from '@heroku/functions-core';
 
 describe('sdf run function start', () => {
   let sandbox: sinon.SinonSandbox;

test/commands/run/function/start/container.test.ts

@@ -8,8 +8,8 @@ import * as events from 'events';
 import { expect, test } from '@oclif/test';
 import * as sinon from 'sinon';
 
-import * as library from '@hk/functions-core';
-import { Benny } from '@hk/functions-core';
+import * as library from '@heroku/functions-core';
+import { Benny } from '@heroku/functions-core';
 
 describe('sd function start container', () => {
   let sandbox: sinon.SinonSandbox;

test/commands/run/function/start/local.test.ts

@@ -9,9 +9,9 @@ import { ChildProcess } from 'child_process';
 import { EventEmitter } from 'events';
 import { expect, test } from '@oclif/test';
 import * as sinon from 'sinon';
-import { LocalRun, LocalRunProcess } from '@hk/functions-core';
+import { LocalRun, LocalRunProcess } from '@heroku/functions-core';
 import { SinonStub, SinonStubbedInstance } from 'sinon';
-import { LangRunnerOpts } from '@hk/functions-core/dist/lang-runner';
+import { LangRunnerOpts } from '@heroku/functions-core/dist/lang-runner';
 import Local from '../../../../../src/commands/run/function/start/local';
 
 describe('sf run function start local', () => {