Skip to content

Commit 053395f

Browse files
authored
feat(backport): support node 22+ (#292)
1 parent 0ebbd00 commit 053395f

File tree

6 files changed

+462
-5411
lines changed

6 files changed

+462
-5411
lines changed

.github/README.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# CI Info
2+
3+
[Github Workflows Readme](https://github.com/salesforcecli/github-workflows)
4+
5+
## Releasing a new version
6+
7+
[Release Workflow](https://github.com/salesforcecli/plugin-lightning-dev/actions/workflows/create-github-release.yml)
8+
9+
## Node Version Configuration
10+
11+
This repository provides flexibility to manage Node.js versions in CI workflows using repository variables.
12+
These variables can be configured at the repository level via the [Actions settings page](https://github.com/salesforcecli/plugin-lightning-dev/settings/variables/actions).
13+
These can also be supplied as arguments to individual workflows directly.
14+
15+
### `UT_DISABLE_NODE_CURRENT`
16+
17+
- Disables the latest Node.js version in GitHub Actions workflows.
18+
19+
### `UT_DISABLE_NODE_PREVIOUS`
20+
21+
- Disables the previous Node.js version in GitHub Actions workflows.
22+
23+
### `NODE_VERSION_OVERRIDE`
24+
25+
- Overrides the full set of Node.js versions used for testing and publishing.
26+
- **Default:** `'lts/*'` and `'lts/-1'`.

.github/workflows/onRelease.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,5 @@ jobs:
4949
sign: true
5050
tag: ${{ needs.getDistTag.outputs.tag || (needs.getMajorVersion.outputs.major == '1') && 'latest' || 'next' }}
5151
githubTag: ${{ github.event.release.tag_name || inputs.tag }}
52-
nodeVersion: 20.18.0
5352

5453
secrets: inherit

.github/workflows/test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,3 @@ jobs:
2626
fail-fast: false
2727
with:
2828
os: ${{ matrix.os }}
29-
nodeVersion: 20.18.0

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ To build the plugin locally, make sure to have yarn installed and run the follow
4949
# Clone the repository
5050
git clone [email protected]:salesforcecli/plugin-lightning-dev
5151

52-
# Install the dependencies and compile
52+
# Install the dependencies and compile the plugin
5353
yarn && yarn build
5454
```
5555

@@ -200,7 +200,7 @@ EXAMPLES
200200
$ sf lightning dev app --target-org myOrg --device-type ios --device-id "iPhone 15 Pro Max"
201201
```
202202

203-
_See code: [src/commands/lightning/dev/app.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.4/src/commands/lightning/dev/app.ts)_
203+
_See code: [src/commands/lightning/dev/app.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.5-alpha.0/src/commands/lightning/dev/app.ts)_
204204

205205
## `sf lightning dev site`
206206

@@ -244,6 +244,6 @@ EXAMPLES
244244
$ sf lightning dev site --name "Partner Central" --target-org myOrg
245245
```
246246

247-
_See code: [src/commands/lightning/dev/site.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.4/src/commands/lightning/dev/site.ts)_
247+
_See code: [src/commands/lightning/dev/site.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/1.9.5-alpha.0/src/commands/lightning/dev/site.ts)_
248248

249249
<!-- commandsstop -->

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
{
22
"name": "@salesforce/plugin-lightning-dev",
33
"description": "Lightning development tools for LEX, Mobile, and Experience Sites",
4-
"version": "1.9.4",
4+
"version": "1.9.5-alpha.0",
55
"author": "Salesforce",
66
"bugs": "https://github.com/forcedotcom/cli/issues",
77
"dependencies": {
88
"@inquirer/prompts": "^5.3.8",
99
"@inquirer/select": "^2.4.7",
1010
"@lwc/lwc-dev-server": "^9.5.3",
1111
"@lwc/sfdc-lwc-compiler": "^9.5.3",
12-
"@lwrjs/api": "0.14.3",
12+
"@lwrjs/api": "0.14.5",
1313
"@oclif/core": "^4.0.17",
1414
"@salesforce/core": "^8.2.7",
1515
"@salesforce/kit": "^3.1.6",
@@ -18,7 +18,6 @@
1818
"axios": "^1.7.7",
1919
"glob": "10.4.5",
2020
"lwc": "7.1.3",
21-
"lwr": "0.14.3",
2221
"node-fetch": "^3.3.2"
2322
},
2423
"devDependencies": {
@@ -34,7 +33,7 @@
3433
"typescript": "^5.5.4"
3534
},
3635
"engines": {
37-
"node": ">=18.0.0 <22"
36+
"node": ">=18.0.0"
3837
},
3938
"files": [
4039
"/lib",
@@ -219,6 +218,7 @@
219218
"exports": "./lib/index.js",
220219
"type": "module",
221220
"volta": {
222-
"node": "20.11.0"
221+
"node": "20.11.0",
222+
"yarn": "1.22.22"
223223
}
224224
}

0 commit comments

Comments
 (0)