Merge branch 'main' into pjain/siteBugFix

Author: nrkruk

.github/workflows/failureNotifications.yml

@@ -1,12 +1,12 @@
 name: failureNotifications
 on:
   workflow_dispatch:
-#  workflow_run:
-#    workflows:
-#      - publish
-#      - create-github-release
-#    types:
-#      - completed
+  workflow_run:
+    workflows:
+      - publish
+      - create-github-release
+    types:
+      - completed
 jobs:
   failure-notify:
     runs-on: ubuntu-latest

CHANGELOG.md

@@ -1,3 +1,9 @@
+## [2.3.1](https://github.com/salesforcecli/plugin-lightning-dev/compare/2.3.0...2.3.1) (2024-11-21)
+
+### Bug Fixes
+
+- sfCLI parameter ([#260](https://github.com/salesforcecli/plugin-lightning-dev/issues/260)) ([f6556b1](https://github.com/salesforcecli/plugin-lightning-dev/commit/f6556b13c0c44cf283c31a8a3e99f97dffc60bd6))
+
 # [2.3.0](https://github.com/salesforcecli/plugin-lightning-dev/compare/2.2.3...2.3.0) (2024-11-19)
 
 ### Features

README.md

@@ -200,7 +200,7 @@ EXAMPLES
     $ sf lightning dev app --target-org myOrg --device-type ios --device-id "iPhone 15 Pro Max"
 ```
 
-_See code: [src/commands/lightning/dev/app.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/2.3.0/src/commands/lightning/dev/app.ts)_
+_See code: [src/commands/lightning/dev/app.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/2.3.1/src/commands/lightning/dev/app.ts)_
 
 ## `sf lightning dev site`
 
@@ -244,6 +244,6 @@ EXAMPLES
     $ sf lightning dev site --name "Partner Central" --target-org myOrg
 ```
 
-_See code: [src/commands/lightning/dev/site.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/2.3.0/src/commands/lightning/dev/site.ts)_
+_See code: [src/commands/lightning/dev/site.ts](https://github.com/salesforcecli/plugin-lightning-dev/blob/2.3.1/src/commands/lightning/dev/site.ts)_
 
 <!-- commandsstop -->

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@salesforce/plugin-lightning-dev",
   "description": "Lightning development tools for LEX, Mobile, and Experience Sites",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "author": "Salesforce",
   "bugs": "https://github.com/forcedotcom/cli/issues",
   "dependencies": {

src/commands/lightning/dev/site.ts

@@ -7,7 +7,7 @@
 import fs from 'node:fs';
 import { SfCommand, Flags } from '@salesforce/sf-plugins-core';
 import { Messages } from '@salesforce/core';
-import { expDev, setupDev } from '@lwrjs/api';
+import { expDev, LocalDevOptions, setupDev } from '@lwrjs/api';
 import { OrgUtils } from '../../../shared/orgUtils.js';
 import { PromptUtils } from '../../../shared/promptUtils.js';
 import { ExperienceSite } from '../../../shared/experience/expSite.js';
@@ -80,7 +80,7 @@ export default class LightningDevSite extends SfCommand<void> {
 
       // Start the dev server
       const port = parseInt(process.env.PORT ?? '3000', 10);
-      const startupParams = {
+      const startupParams: LocalDevOptions = {
         sfCLI: true,
         authToken,
         open: true,