Skip to content

Commit 845e58c

Browse files
committed
fix: typescript errors not showing in CI
1 parent 0449090 commit 845e58c

File tree

3 files changed

+48
-9
lines changed

3 files changed

+48
-9
lines changed

.github/workflows/build.yml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
name: build
2+
3+
on:
4+
pull_request:
5+
push:
6+
branches:
7+
- main
8+
- '*-patch'
9+
10+
jobs:
11+
determine-node-versions:
12+
outputs:
13+
nodeVersions: ${{ steps.determine-node-versions.outputs.nodeVersions }}
14+
runs-on: ubuntu-latest
15+
steps:
16+
- uses: salesforcecli/github-workflows/.github/actions/determineNodeVersions@main
17+
id: determine-node-versions
18+
with:
19+
nodeVersionOverride: ${{ vars.NODE_VERSION_OVERRIDE }} # default is 'lts/*' and 'lts/-1'
20+
nodeDisableCurrent: ${{ vars.UT_DISABLE_NODE_CURRENT }} # default is falsy
21+
nodeDisablePrevious: ${{ vars.UT_DISABLE_NODE_PREVIOUS }} # default is falsy
22+
23+
build:
24+
needs: determine-node-versions
25+
strategy:
26+
matrix:
27+
node_version: ${{ fromJSON(needs.determine-node-versions.outputs.nodeVersions) }}
28+
fail-fast: false
29+
runs-on: ubuntu-latest
30+
steps:
31+
- uses: actions/checkout@v4
32+
33+
- uses: actions/setup-node@v4
34+
with:
35+
node-version: ${{ matrix.node_version }}
36+
37+
- run: yarn install
38+
39+
- run: yarn build

.github/workflows/failureNotifications.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
name: failureNotifications
22
on:
33
workflow_dispatch:
4-
# workflow_run:
5-
# workflows:
6-
# - publish
7-
# - create-github-release
8-
# types:
9-
# - completed
4+
workflow_run:
5+
workflows:
6+
- publish
7+
- create-github-release
8+
types:
9+
- completed
1010
jobs:
1111
failure-notify:
1212
runs-on: ubuntu-latest

src/commands/lightning/dev/site.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import fs from 'node:fs';
88
import { SfCommand, Flags } from '@salesforce/sf-plugins-core';
99
import { Messages } from '@salesforce/core';
10-
import { expDev, setupDev } from '@lwrjs/api';
10+
import { expDev, LocalDevOptions, setupDev } from '@lwrjs/api';
1111
import { OrgUtils } from '../../../shared/orgUtils.js';
1212
import { PromptUtils } from '../../../shared/promptUtils.js';
1313
import { ExperienceSite } from '../../../shared/experience/expSite.js';
@@ -80,8 +80,8 @@ export default class LightningDevSite extends SfCommand<void> {
8080

8181
// Start the dev server
8282
const port = parseInt(process.env.PORT ?? '3000', 10);
83-
const startupParams = {
84-
sfCli: true,
83+
const startupParams: LocalDevOptions = {
84+
sfCLI: true,
8585
authToken,
8686
open: true,
8787
port,

0 commit comments

Comments
 (0)