Skip to content

Commit 200a877

Browse files
fix(deps): resolving comments
1 parent 56bae79 commit 200a877

File tree

7 files changed

+18
-11
lines changed

7 files changed

+18
-11
lines changed

LICENSE.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
Copyright (c) 2018, Salesforce.com, Inc.
22
All rights reserved.
33

4-
Welcome to the Omnistudio Migration Assistant Pilot. This is a pilot tool release and your feedback is invaluable. This migration assistant which is provided for pilot evaluation purposes only and Pilot participants agree to provide feedback as requested.
5-
64
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
75

86
* Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

appveyor.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
environment:
2-
nodejs_version: "10"
2+
nodejs_version: '18'
33
cache:
44
- '%LOCALAPPDATA%\Yarn -> appveyor.yml'
55
- node_modules -> yarn.lock
@@ -16,4 +16,3 @@ build_script:
1616

1717
test_script:
1818
- yarn test
19-

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
"xml2js": "^0.5.0"
9797
},
9898
"engines": {
99-
"node": ">=12.0.0"
99+
"node": ">=18.0.0"
100100
},
101101
"files": [
102102
"/lib",
@@ -111,7 +111,7 @@
111111
"license": "BSD-3-Clause",
112112
"oclif": {
113113
"commands": "./lib/commands",
114-
"bin": "sfdx",
114+
"bin": "sf",
115115
"topics": {
116116
"omnistudio": {
117117
"subtopics": {
@@ -130,19 +130,19 @@
130130
},
131131
"repository": "salesforcecli/plugin-omnistudio-migration-tool",
132132
"scripts": {
133-
"build": "sf-build",
133+
"build": "sf-build && yarn copy-assets",
134134
"clean": "sf-clean",
135135
"clean-all": "sf-clean all",
136136
"clean:lib": "shx rm -rf lib && shx rm -rf coverage && shx rm -rf .nyc_output && shx rm -f oclif.manifest.json",
137-
"compile": "sf-compile",
137+
"compile": "sf-compile && yarn copy-assets",
138138
"copy-assets": "shx cp -r src/templates lib/ && shx cp -r src/styles lib/ && shx cp -r src/javascripts lib/",
139139
"docs": "sf-docs",
140140
"format": "sf-format",
141141
"lint": "sf-lint",
142142
"postpack": "shx rm -f oclif.manifest.json",
143143
"posttest": "yarn lint && yarn test:deprecation-policy && yarn test:command-reference",
144-
"prepack": "sf-prepack",
145-
"prepare": "sf-install",
144+
"prepack": "sf-prepack && yarn copy-assets",
145+
"prepare": "husky install",
146146
"pretest": "sf-compile-test",
147147
"test": "sf-test",
148148
"test:command-reference": "./bin/run commandreference:generate --erroronwarnings",

src/commands/omnistudio/migration/assess.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ export default class Assess extends SfCommand<AssessmentInfo> {
4747
'target-org': flags.optionalOrg({
4848
summary: 'Target org username or alias',
4949
required: true,
50+
aliases: ['targetusername', 'u'],
51+
deprecateAliases: true,
52+
makeDefault: false, // Prevent auto-resolution during command-reference generation
5053
}),
5154
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
5255
only: flags.string({

src/commands/omnistudio/migration/info.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,12 @@ export default class Info extends SfCommand<InfoResult> {
4141
public static readonly flags: any = {
4242
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
4343
'target-org': flags.optionalOrg({
44+
char: 'o',
4445
summary: 'Target org username or alias',
4546
required: true,
47+
aliases: ['targetusername', 'u'],
48+
deprecateAliases: true,
49+
makeDefault: false, // Prevent auto-resolution during command-reference generation
4650
}),
4751
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
4852
'target-dev-hub': flags.optionalHub({

src/commands/omnistudio/migration/migrate.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ export default class Migrate extends SfCommand<MigrateResult> {
7070
'target-org': flags.optionalOrg({
7171
summary: 'Target org username or alias',
7272
required: true,
73+
aliases: ['targetusername', 'u'],
74+
deprecateAliases: true,
75+
makeDefault: false, // Prevent auto-resolution during command-reference generation
7376
}),
7477
only: flags.string({
7578
char: 'o',

test/utils/reportGeneratorUtility.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ describe('reportGeneratorUtility Column Freeze Tests', () => {
491491
expect(element.style.getPropertyValue('z-index')).to.equal('20');
492492
// CSS colors are normalized to rgb format by JSDOM
493493
expect(element.style.getPropertyValue('background-color')).to.equal('rgb(243, 243, 243)');
494-
// expect(element.style.getPropertyValue('border-right')).to.equal('1px solid #e5e5e5');
494+
expect(element.style.getPropertyValue('border-right')).to.equal('1px solid rgb(229, 229, 229)');
495495
});
496496

497497
it('should apply sticky styles without border when addBorder is false', () => {

0 commit comments

Comments
 (0)