chore: resolved comments

Author: sf-aastha-paruthi

src/commands/omnistudio/migration/migrate.ts

@@ -452,11 +452,13 @@ export default class Migrate extends OmniStudioBaseCommand {
         let errors: any[] = obj.errors || [];
         errors = errors.concat(recordResults.errors || []);
 
-        obj.status = recordResults?.skipped
-          ? messages.getMessage('labelStatusSkipped')
-          : !recordResults || recordResults.hasErrors
-            ? messages.getMessage('labelStatusFailed')
-            : messages.getMessage('labelStatusComplete');
+        if (recordResults?.skipped) {
+          obj.status = messages.getMessage('labelStatusSkipped');
+        } else if (!recordResults || recordResults.hasErrors) {
+          obj.status = messages.getMessage('labelStatusFailed');
+        } else {
+          obj.status = messages.getMessage('labelStatusComplete');
+        }
         obj.errors = errors;
         obj.migratedId = recordResults.id;
         obj.warnings = recordResults.warnings;

src/migration/flexcard.ts

@@ -645,7 +645,11 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
           isDuplicate: false,
         };
 
-        if (Array.isArray(flexCardAssessmentInfo.errors) && flexCardAssessmentInfo.errors.length > 0) {
+        if (
+          flexCardAssessmentInfo.errors &&
+          Array.isArray(flexCardAssessmentInfo.errors) &&
+          flexCardAssessmentInfo.errors.length > 0
+        ) {
           value.error = flexCardAssessmentInfo.errors;
           value.migrationSuccess = false;
         } else {

src/migration/omniscript.ts

@@ -560,7 +560,11 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
           isDuplicate: false,
         };
 
-        if (Array.isArray(currentOsRecordInfo.errors) && currentOsRecordInfo.errors.length > 0) {
+        if (
+          currentOsRecordInfo.errors &&
+          Array.isArray(currentOsRecordInfo.errors) &&
+          currentOsRecordInfo.errors.length > 0
+        ) {
           value.error = currentOsRecordInfo.errors;
           value.migrationSuccess = false;
         } else {

src/utils/resultsbuilder/index.ts

@@ -251,7 +251,7 @@ export class ResultsBuilder {
       },
       assessmentDate: new Date().toString(),
       total: result.length,
-      filterGroups: [createFilterGroupParam('Filter by Status', 'status', ['Can be Automated', 'Errors'])],
+      filterGroups: [createFilterGroupParam('Filter by Status', 'status', ['Complete', 'Failed'])],
       headerGroups: [
         {
           header: [
@@ -288,7 +288,16 @@ export class ResultsBuilder {
         data: [
           createRowDataParam('name', item.name, true, 1, 1, false),
           createRowDataParam('path', item.path, false, 1, 1, false),
-          createRowDataParam('status', item.status, false, 1, 1, false, undefined, item.status),
+          createRowDataParam(
+            'status',
+            item.warnings && item.warnings.length > 0 ? 'Failed' : 'Complete',
+            false,
+            1,
+            1,
+            false,
+            undefined,
+            item.warnings && item.warnings.length > 0 ? 'Failed' : 'Complete'
+          ),
           createRowDataParam(
             'diff',
             item.name + 'diff',
@@ -301,13 +310,13 @@ export class ResultsBuilder {
           ),
           createRowDataParam(
             'errors',
-            item.warnings ? 'Error' : 'Complete',
+            item.warnings && item.warnings.length > 0 ? 'Failed' : 'Complete',
             false,
             1,
             1,
             false,
             undefined,
-            item.warnings
+            reportingHelper.decorateErrors(item.warnings)
           ),
         ],
       })),