Merge pull request #429 from sf-aastha-paruthi/u/aparuthi/flexcardupdates

@W-19821865 Flexcard Name update for standard model

Author: sf-aastha-paruthi

messages/assess.json

@@ -197,8 +197,6 @@
   "dmNameUpdateFailed": "DM reference %s can’t be updated",
   "invalidTypeAssessErrorMessage": "We couldn't assess your Omnistudio components in the %s namespace. Select the correct namespace and try again",
   "assessmentSuccessfulMessage": "Migration assessment for org %s is complete and reports are ready for review in the folder %s",
-  "needManualInterventionAsSpecialCharsInChildFlexcardName": "Child Flexcards with special characters in their names must be manually migrated.",
-  "needManualInterventionAsSpecialCharsInFlexcardName": "This Flexcard contains special characters in its name. It must be manually migrated.",
   "errorCheckingOmniStudioMetadata": "We couldn't check whether the Omnistudio Metadata is enabled: %s. Try again later.",
   "omniStudioSettingsMetadataAlreadyEnabled": "The Omnistudio Metadata setting is already enabled with standard data model. No need for migration."
 }

messages/migrate.json

@@ -247,8 +247,6 @@
   "generatedCustomLabelAssessmentReportPage": "Generated custom label assessment report page %s of %s with %s labels",
   "varDeclarationUpdated": "Variable initialization has been updated for target name",
   "migrationSuccessfulMessage": "Migration process for org %s is complete and reports are ready for review in the folder %s",
-  "needManualInterventionAsSpecialCharsInChildFlexcardName": "Need manual intervention as child flexcards have special characters in their name",
-  "needManualInterventionAsSpecialCharsInFlexcardName": "Need manual intervention as flexcard has special characters in name",
   "metadataTablesAlreadyClean": "OmniStudio metadata tables are empty",
   "startingMetadataCleanup": "Initiated cleanup process for Omnistudio metadata tables.",
   "failedToCleanTables": "Table cleanup failed: %s",

src/migration/dataraptor.ts

@@ -386,7 +386,6 @@ export class DataRaptorMigrationTool extends BaseMigrationTool implements Migrat
     const drItems = dataRaptorItemsMap.get(drName);
     if (drItems) {
       for (const drItem of drItems) {
-        // Logger.log(dataRaptor[this.namespacePrefix + 'Formula__c']);
         const formula = drItem[this.getItemFieldKey('Formula__c')];
         if (formula) {
           try {

src/migration/flexcard.ts

@@ -89,8 +89,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
 
   // Perform Records Migration from VlocityCard__c to OmniUiCard
   async migrate(): Promise<MigrationResult[]> {
-    // Get All the Active VlocityCard__c records
-    const allCards = await this.getAllActiveCards();
+    const allCards = await this.getAllCards();
 
     Logger.log(this.messages.getMessage('foundFlexCardsToMigrate', [allCards.length]));
 
@@ -156,7 +155,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
   public async assess(): Promise<FlexCardAssessmentInfo[]> {
     try {
       Logger.log(this.messages.getMessage('startingFlexCardAssessment'));
-      const flexCards = await this.getAllActiveCards();
+      const flexCards = await this.getAllCards();
       Logger.log(this.messages.getMessage('foundFlexCardsToAssess', [flexCards.length]));
 
       const flexCardsAssessmentInfos = await this.processCardComponents(flexCards);
@@ -234,20 +233,10 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
       'Ready for migration';
     flexCardAssessmentInfo.name = this.allVersions ? `${cleanedName}_${version}` : cleanedName;
     if (cleanedName !== originalName) {
-      if (!this.IS_STANDARD_DATA_MODEL) {
-        flexCardAssessmentInfo.warnings.push(
-          this.messages.getMessage('cardNameChangeMessage', [originalName, cleanedName])
-        );
-        assessmentStatus = getUpdatedAssessmentStatus(assessmentStatus, 'Warnings');
-      } else {
-        flexCardAssessmentInfo.warnings.push(
-          this.messages.getMessage('needManualInterventionAsSpecialCharsInFlexcardName')
-        );
-        flexCardAssessmentInfo.errors.push(
-          this.messages.getMessage('needManualInterventionAsSpecialCharsInFlexcardName')
-        );
-        assessmentStatus = 'Needs Manual Intervention';
-      }
+      flexCardAssessmentInfo.warnings.push(
+        this.messages.getMessage('cardNameChangeMessage', [originalName, cleanedName])
+      );
+      assessmentStatus = getUpdatedAssessmentStatus(assessmentStatus, 'Warnings');
     }
 
     // Check for duplicate names
@@ -404,23 +393,13 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
 
         // Add warning if child card name will change
         if (childCardName !== cleanedChildCardName) {
-          if (!this.IS_STANDARD_DATA_MODEL) {
-            flexCardAssessmentInfo.warnings.push(
-              this.messages.getMessage('cardNameChangeMessage', [childCardName, cleanedChildCardName])
-            );
-            flexCardAssessmentInfo.migrationStatus = getUpdatedAssessmentStatus(
-              flexCardAssessmentInfo.migrationStatus,
-              'Warnings'
-            );
-          } else {
-            flexCardAssessmentInfo.warnings.push(
-              this.messages.getMessage('needManualInterventionAsSpecialCharsInChildFlexcardName')
-            );
-            flexCardAssessmentInfo.errors.push(
-              this.messages.getMessage('needManualInterventionAsSpecialCharsInChildFlexcardName')
-            );
-            flexCardAssessmentInfo.migrationStatus = 'Needs Manual Intervention';
-          }
+          flexCardAssessmentInfo.warnings.push(
+            this.messages.getMessage('cardNameChangeMessage', [childCardName, cleanedChildCardName])
+          );
+          flexCardAssessmentInfo.migrationStatus = getUpdatedAssessmentStatus(
+            flexCardAssessmentInfo.migrationStatus,
+            'Warnings'
+          );
         }
       }
     } catch (err) {
@@ -694,8 +673,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
     }
   }
 
-  // Query all cards that are active
-  private async getAllActiveCards(): Promise<AnyJson[]> {
+  private async getAllCards(): Promise<AnyJson[]> {
     //DebugTimer.getInstance().lap('Query Vlocity Cards');
     const filters = new Map<string, any>();
 
@@ -740,7 +718,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
     }
   }
 
-  // Upload All the VlocityCard__c records to OmniUiCard
+  // Upload All the VlocityCard__c records to OmniUiCard for custom model and update references for standard
   private async uploadAllCards(
     cards: any[],
     progressBar: ReturnType<typeof createProgressBar>
@@ -789,42 +767,13 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
           }
         }
 
-        const isChildCardUpdated: boolean = this.updateChildCards(card);
-
-        if (this.IS_STANDARD_DATA_MODEL && isChildCardUpdated) {
-          originalRecords.set(recordId, card);
-
-          cardsUploadInfo.set(recordId, {
-            referenceId: recordId,
-            hasErrors: true,
-            success: false,
-            errors: [this.messages.getMessage('needManualInterventionAsSpecialCharsInChildFlexcardName')],
-            warnings: [],
-          });
-
-          return;
-        }
+        this.updateChildCards(card);
       }
 
       // Perform the transformation
       const invalidIpNames = new Map<string, string>();
       const transformedCard = this.mapVlocityCardRecord(card, cardsUploadInfo, invalidIpNames); // This only has the card structure, card definition is not there
 
-      if (this.IS_STANDARD_DATA_MODEL) {
-        if (transformedCard['Name'] != card['Name']) {
-          originalRecords.set(recordId, card);
-
-          cardsUploadInfo.set(recordId, {
-            referenceId: recordId,
-            hasErrors: true,
-            success: false,
-            errors: [this.messages.getMessage('needManualInterventionAsSpecialCharsInFlexcardName')],
-            warnings: [],
-          });
-          return;
-        }
-      }
-
       // Verify duplicated names
       let transformedCardName: string;
       if (this.allVersions) {
@@ -1064,11 +1013,9 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
     return childs;
   }
 
-  private updateChildCards(card: AnyJson): boolean {
+  private updateChildCards(card: AnyJson): void {
     const definition = JSON.parse(card[this.getFieldKey('Definition__c')]);
-    if (!definition) return false;
-
-    let hasNameChanges = false;
+    if (!definition) return;
 
     for (let state of definition.states || []) {
       if (state.childCards && Array.isArray(state.childCards)) {
@@ -1078,14 +1025,12 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
         // Check if any child card name was changed
         for (let i = 0; i < originalChildCards.length; i++) {
           if (originalChildCards[i] !== state.childCards[i]) {
-            hasNameChanges = true;
           }
         }
       }
     }
 
     card[this.getFieldKey('Definition__c')] = JSON.stringify(definition);
-    return hasNameChanges;
   }
 
   // Maps an indivitdual VlocityCard__c record to an OmniUiCard record.
@@ -1138,6 +1083,18 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
     mappedObject[CardMappings.Author__c] = this.cleanName(mappedObject[CardMappings.Author__c]);
     mappedObject[CardMappings.Active__c] = false;
 
+    if (this.IS_STANDARD_DATA_MODEL) {
+      if (mappedObject['OmniUiCardKey']) {
+        mappedObject['OmniUiCardKey'] =
+          mappedObject['Name'] +
+          '/' +
+          mappedObject[CardMappings.Author__c] +
+          '/' +
+          mappedObject[CardMappings.Version__c] +
+          '.0';
+      }
+    }
+
     // Update the datasource
     const datasource = JSON.parse(mappedObject[CardMappings.Datasource__c] || '{}');
     if (datasource.dataSource) {
@@ -1159,7 +1116,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
       mappedObject[CardMappings.Datasource__c] = JSON.stringify(datasource);
     }
 
-    const isCardActive: boolean = cardRecord[`${this.namespacePrefix}Active__c`];
+    const isCardActive: boolean = cardRecord[this.getFieldKey('Active__c')];
     this.ensureCommunityTargets(mappedObject, isCardActive);
 
     // Update all dependencies comprehensively
@@ -1671,6 +1628,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
   /**
    * Ensures that the FlexCard Definition includes required Lightning Community targets
    * Adds "lightningCommunity__Page" and "lightningCommunity__Default" if missing
+   * This is needed as vlocity wrapper can have flexcard which is unpublished but omniwapper needs published card
    */
   private ensureCommunityTargets(mappedObject: any, isCardActive: boolean): void {
     if (!isCardActive) {

src/migration/omniscript.ts

@@ -1296,7 +1296,6 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
       ? filters.set('OmniProcessId', recordId)
       : filters.set(this.namespacePrefix + 'OmniScriptId__c', recordId);
 
-    // const queryFilterStr = ` Where ${this.namespacePrefix}OmniScriptId__c = '${omniScriptData.keys().next().value}'`;
     return await QueryTools.queryWithFilter(
       this.connection,
       this.getQueryNamespace(),
@@ -1314,7 +1313,6 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
       ? filters.set('OmniProcessId', recordId)
       : filters.set(this.namespacePrefix + 'OmniScriptId__c', recordId);
 
-    // const queryFilterStr = ` Where ${this.namespacePrefix}OmniScriptId__c = '${omniScriptData.keys().next().value}'`;
     return await QueryTools.queryWithFilter(
       this.connection,
       this.getQueryNamespace(),
@@ -1540,10 +1538,10 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 
           if (
             cleanFieldName === 'ParentElementId__c' &&
-            parentElementUploadResponse.has(elementRecord[`${this.namespacePrefix}ParentElementId__c`])
+            parentElementUploadResponse.has(elementRecord[this.getElementFieldKey('ParentElementId__c')])
           ) {
             mappedObject[ElementMappings[cleanFieldName]] = parentElementUploadResponse.get(
-              elementRecord[`${this.namespacePrefix}ParentElementId__c`]
+              elementRecord[this.getElementFieldKey('ParentElementId__c')]
             ).id;
           }
         }

test/migration/flexcard-standard-datamodel.test.ts

@@ -30,9 +30,6 @@ describe('FlexCard Standard Data Model (Metadata API Disabled) - Assessment and
     mockConnection = {};
     mockMessages = {
       getMessage: (key: string, args?: string[]) => {
-        if (key === 'needManualInterventionAsSpecialCharsInFlexcardName') {
-          return 'FlexCard name contains special characters and cannot be auto-migrated';
-        }
         if (key === 'cardNameChangeMessage') {
           return `The card name '${args?.[0]}' will be changed to '${args?.[1]}'`;
         }
@@ -117,9 +114,10 @@ describe('FlexCard Standard Data Model (Metadata API Disabled) - Assessment and
       expect(result.name).to.equal('CustomerProfileCard');
       expect(result.oldName).to.equal('Customer-Profile@Card!');
 
-      // Should add warning for manual intervention due to special characters
-      expect(result.warnings).to.include('FlexCard name contains special characters and cannot be auto-migrated');
-      expect(result.migrationStatus).to.equal('Needs Manual Intervention');
+      // Should add warning about name change (name updates are now allowed, so status is Warnings not Manual Intervention)
+      expect(result.warnings).to.have.length.greaterThan(0);
+      expect(result.warnings[0]).to.include("will be changed to 'CustomerProfileCard'");
+      expect(result.migrationStatus).to.equal('Warnings');
 
       // Dependencies should still be detected for assessment
       expect(result.dependenciesDR).to.have.length.greaterThan(0);
@@ -193,7 +191,7 @@ describe('FlexCard Standard Data Model (Metadata API Disabled) - Assessment and
     it('should map OmniUiCard fields correctly for Standard Data Model', () => {
       const mockCardRecord = {
         Id: 'fc1',
-        Name: 'TestCard',
+        Name: 'TestCard!@#',
         DataSourceConfig: JSON.stringify({
           type: 'DataRaptor',
           value: { bundle: 'TestBundle' },
@@ -218,7 +216,7 @@ describe('FlexCard Standard Data Model (Metadata API Disabled) - Assessment and
       expect(result.AuthorName).to.equal('TestAuthor');
       expect(result.VersionNumber).to.equal(2);
       expect(result.OmniUiCardType).to.equal('Parent');
-      expect(result.OmniUiCardKey).to.equal('test-card-key');
+      expect(result.OmniUiCardKey).to.equal('TestCard/TestAuthor/2.0');
     });
 
     it('should process DataRaptor data source and preserve registry mapping functionality', () => {
@@ -612,7 +610,7 @@ describe('FlexCard Standard Data Model (Metadata API Disabled) - Assessment and
       expect(result.StylingConfiguration).to.equal('style-config');
       expect(result.OmniUiCardType).to.equal('Parent');
       expect(result.VersionNumber).to.equal(1);
-      expect(result.OmniUiCardKey).to.equal('card-key');
+      expect(result.OmniUiCardKey).to.equal('TestCard/TestAuthor/1.0');
     });
   });
 });

test/migration/flexcard/flexcard-angular-dependencies.test.ts

@@ -257,8 +257,8 @@ describe('FlexCard Angular Dependency Validation', () => {
         }),
       };
 
-      // Mock getAllActiveCards method
-      (cardTool as any).getAllActiveCards = () => Promise.resolve([mockFlexCardWithAngular, mockFlexCardWithLWC]);
+      // Mock getAllCards method
+      (cardTool as any).getAllCards = () => Promise.resolve([mockFlexCardWithAngular, mockFlexCardWithLWC]);
 
       // Mock uploadAllCards method to track which cards are processed
       const processedCards: any[] = [];
@@ -293,7 +293,7 @@ describe('FlexCard Angular Dependency Validation', () => {
         }),
       };
 
-      (cardTool as any).getAllActiveCards = () => Promise.resolve([mockFlexCardWithAngular]);
+      (cardTool as any).getAllCards = () => Promise.resolve([mockFlexCardWithAngular]);
       (cardTool as any).uploadAllCards = () => Promise.resolve(new Map());
 
       const result = await cardTool.migrate();