fix: addressed more comments

Author: snehaljha-sf

README.md

@@ -168,12 +168,14 @@ OPTIONS
                                                                                     os (OmniScripts), fc (FlexCards)
 
   --relatedobjects=relatedobjects                                                   specify related objects to assess:
-                                                                                    'apex' for Apex classes
-```
+                                                                                    'apex'       for Apex classes
+'lwc'        for LWC (Lightning Web Components)
+'expsites'   for Experience Sites
+'flexipage'  for Lightning record pages
 
-> **Note:** LWC (Lightning Web Components) assessment/migration functionality is temporarily disabled in the current version. LWC features will be re-enabled in a future releases.
+```
 
-> Apex migration functionality remains fully available. The `--relatedobjects` flag only accepts values ('apex')
+> **Note:** LWC migration auto-deployment needs minimum node version of 18.17.1
 
 Terms:
 Notwithstanding anything stated in the terms and conditions agreed between Salesforce (‘SFDC’) and you (‘Customer’), the use of the OmniStudio Migration Assistant (‘Assistant’) is designed to facilitate the migration and it’s going to modify your custom code and by deploying and using the Assistant you hereby provide your consent to automate the migration process and enable a smooth transition. Customer shall access and use the Assistant only as permitted to the Customer and shall not compromise, break or circumvent any technical processes or security measures associated with the services provided by SFDC.

src/commands/omnistudio/migration/migrate.ts

@@ -135,13 +135,16 @@ export default class Migrate extends OmniStudioBaseCommand {
     const preMigrate: PreMigrate = new PreMigrate(namespace, conn, this.logger, messages, this.ux);
     const isExperienceBundleMetadataAPIProgramaticallyEnabled: { value: boolean } = { value: false };
 
+    let actionItems = [];
+
     let deploymentConfig = { autoDeploy: false, authKey: undefined };
     if (relatedObjects) {
       const relatedObjectMigrationResult = await this.migrateRelatedObjects(
         relatedObjects,
         preMigrate,
         conn,
-        isExperienceBundleMetadataAPIProgramaticallyEnabled
+        isExperienceBundleMetadataAPIProgramaticallyEnabled,
+        actionItems
       );
       objectsToProcess = relatedObjectMigrationResult.objectsToProcess;
       projectPath = relatedObjectMigrationResult.projectPath;
@@ -183,7 +186,7 @@ export default class Migrate extends OmniStudioBaseCommand {
     const relatedObjectMigrationResult = omnistudioRelatedObjectsMigration.migrateAll(objectsToProcess);
 
     // POST MIGRATION
-    let actionItems = [];
+    
     const postMigrate: PostMigrate = new PostMigrate(
       this.org,
       namespace,
@@ -241,7 +244,8 @@ export default class Migrate extends OmniStudioBaseCommand {
     relatedObjects: string,
     preMigrate: PreMigrate,
     conn: Connection,
-    isExperienceBundleMetadataAPIProgramaticallyEnabled: { value: boolean }
+    isExperienceBundleMetadataAPIProgramaticallyEnabled: { value: boolean },
+    actionItems: string[]
   ): Promise<{
     objectsToProcess: string[];
     projectPath: string;
@@ -272,7 +276,7 @@ export default class Migrate extends OmniStudioBaseCommand {
         conn,
         isExperienceBundleMetadataAPIProgramaticallyEnabled
       );
-      deploymentConfig = await preMigrate.getAutoDeployConsent(objectsToProcess.includes(Constants.LWC));
+      deploymentConfig = await preMigrate.getAutoDeployConsent(objectsToProcess.includes(Constants.LWC), actionItems);
       Logger.logVerbose(
         'The objects to process after handleExpSitePrerequisite are ' + JSON.stringify(objectsToProcess)
       );

src/migration/deployer.ts

@@ -7,7 +7,8 @@ import { Logger } from '../utils/logger';
 export class Deployer {
   private readonly projectPath: string;
   private readonly authKey: string;
-  private readonly requiredNodeDependency = '@omnistudio/[email protected]';
+  private readonly omniscriptCustomizationPackage = '@omnistudio/omniscript_customization';
+  private readonly omniscriptCustomizationPackageVersion = '250.0.0';
   private readonly username: string;
   private readonly messages: Messages;
 
@@ -26,7 +27,9 @@ export class Deployer {
         sfProject.createNPMConfigFile(this.authKey);
         Logger.logVerbose(this.messages.getMessage('installingRequiredDependencies'));
         sfProject.installDependency();
-        sfProject.installDependency(this.requiredNodeDependency);
+        sfProject.installDependency(
+          `${this.omniscriptCustomizationPackage}@${this.omniscriptCustomizationPackageVersion}`
+        );
       }
       Logger.log(path.join(pwd.toString(), 'package.xml'));
       sfProject.deployFromManifest(path.join(pwd.toString(), 'package.xml'), this.username);

src/migration/premigrate.ts

@@ -54,7 +54,8 @@ export class PreMigrate extends BaseMigrationTool {
   }
 
   public async getAutoDeployConsent(
-    includeLwc: boolean
+    includeLwc: boolean,
+    actionItems: string[]
   ): Promise<{ autoDeploy: boolean; authKey: string | undefined }> {
     const askWithTimeOut = PromptUtil.askWithTimeOut(this.messages);
     let validResponse = false;
@@ -91,6 +92,7 @@ export class PreMigrate extends BaseMigrationTool {
       deploymentConfig.authKey = process.env[authEnvKey];
       if (!deploymentConfig.authKey) {
         Logger.warn(this.messages.getMessage('authKeyEnvVarNotSet'));
+        actionItems.push(this.messages.getMessage('authKeyEnvVarNotSet'));
       }
     }
 

test/migration/deployer.test.ts

@@ -60,7 +60,8 @@ describe('Deployer', () => {
       expect((deployer as any).username).to.equal(testUsername);
       expect((deployer as any).authKey).to.equal(testAuthKey);
       expect((deployer as any).messages).to.equal(messages);
-      expect((deployer as any).requiredNodeDependency).to.equal('@omnistudio/[email protected]');
+      expect((deployer as any).omniscriptCustomizationPackage).to.equal('@omnistudio/omniscript_customization');
+      expect((deployer as any).omniscriptCustomizationPackageVersion).to.equal('250.0.0');
     });
   });
 
@@ -134,8 +135,9 @@ describe('Deployer', () => {
   });
 
   describe('private properties', () => {
-    it('should have correct requiredNodeDependency', () => {
-      expect((deployer as any).requiredNodeDependency).to.equal('@omnistudio/[email protected]');
+    it('should have correct omniscript customization package properties', () => {
+      expect((deployer as any).omniscriptCustomizationPackage).to.equal('@omnistudio/omniscript_customization');
+      expect((deployer as any).omniscriptCustomizationPackageVersion).to.equal('250.0.0');
     });
   });