Merge pull request #397 from snehaljha-sf/feedback

snehaljha-sf · web-flow · commit 48d885679f1d · 2025-09-05T18:06:14.000+05:30
Feedback
diff --git a/messages/assess.json b/messages/assess.json
diff --git a/messages/migrate.json b/messages/migrate.json
diff --git a/src/migration/flexcard.ts b/src/migration/flexcard.ts
@@ -882,7 +882,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
         finalKey = finalKey.toLowerCase();
         if (storage.fcStorage.has(finalKey)) {
           // Key already exists - handle accordingly
-          Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', [finalKey]));
+          Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', ['Flexcard', finalKey]));
           value.isDuplicate = true;
           storage.fcStorage.set(finalKey, value);
         } else {
@@ -929,7 +929,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
         finalKey = finalKey.toLowerCase();
         if (storage.fcStorage.has(finalKey)) {
           // Key already exists - handle accordingly
-          Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', [finalKey]));
+          Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', ['Flexcard', finalKey]));
           value.isDuplicate = true;
           storage.fcStorage.set(finalKey, value);
         } else {
@@ -1078,7 +1078,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
               if (c && this.nameRegistry.hasFlexCardMapping(c)) {
                 return this.nameRegistry.getFlexCardCleanedName(c);
               } else {
-                Logger.logVerbose(`\n${this.messages.getMessage('componentMappingNotFound', ['FlexCard', c])}`);
+                Logger.logVerbose(`\n${this.messages.getMessage('componentMappingNotFound', ['Flexcard', c])}`);
                 return this.cleanName(c);
               }
             });
@@ -1237,7 +1237,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
           component.property.cardName = this.nameRegistry.getFlexCardCleanedName(originalCardName);
         } else {
           Logger.logVerbose(
-            `\n${this.messages.getMessage('componentMappingNotFound', ['FlexCard', originalCardName])}`
+            `\n${this.messages.getMessage('componentMappingNotFound', ['Flexcard', originalCardName])}`
           );
           component.property.cardName = this.cleanName(originalCardName);
         }
diff --git a/src/migration/omniscript.ts b/src/migration/omniscript.ts
@@ -34,7 +34,6 @@ import {
   populateRegexForFunctionMetadata,
 } from '../utils/formula/FormulaUtil';
 import { StringVal } from '../utils/StringValue/stringval';
-import { formatUnicorn } from '../utils/stringUtils';
 import { Logger } from '../utils/logger';
 import { createProgressBar } from './base';
 import { StorageUtil } from '../utils/storageUtil';
@@ -131,7 +130,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 
     let success: boolean = await NetUtils.delete(this.connection, ids);
     if (!success) {
-      throw new Error(formatUnicorn(this.messages.getMessage('couldNotTruncateOmnniProcess'), objectName));
+      throw new Error(this.messages.getMessage('couldNotTruncateOmnniProcess', [this.getName(), this.getName()]));
     }
   }
 
@@ -662,7 +661,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
         finalKey = finalKey.toLowerCase();
         if (storage.osStorage.has(finalKey)) {
           // Key already exists - handle accordingly
-          Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', [finalKey]));
+          Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', ['Omniscript', finalKey]));
           value.isDuplicate = true;
           storage.osStorage.set(finalKey, value);
         } else {
@@ -1167,7 +1166,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
           finalKey = finalKey.toLowerCase();
           if (storage.osStorage.has(finalKey)) {
             // Key already exists - handle accordingly
-            Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', [finalKey]));
+            Logger.logVerbose(this.messages.getMessage('keyAlreadyInStorage', ['Omniscript', finalKey]));
             value.isDuplicate = true;
             storage.osStorage.set(finalKey, value);
           } else {
diff --git a/src/utils/constants/documentRegistry.ts b/src/utils/constants/documentRegistry.ts
@@ -1,18 +1,6 @@
 export const documentRegistry = {
-  errorNoOrgResults:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_get_moving_run_the_omnistudio_migration_tool.htm&type=5',
-  couldNotDeactivateOmniProcesses:
-    'https://help.salesforce.com/s/articleView?id=ind.insurance_deactivate_and_activate_omniscripts_509999.htm&type=5',
-  couldNotTruncate:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_embed_an_omniscript_in_another_omniscript_20581.htm&type=5',
-  couldNotTruncateOmnniProcess:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_embed_an_omniscript_in_another_omniscript_20581.htm&type=5',
-  invalidNameTypeSubtypeOrLanguage:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   invalidOrRepeatingOmniscriptElementNames:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
-  invalidDataRaptorName:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   duplicatedCardName: 'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   duplicatedDrName: 'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   duplicatedOSName: 'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
@@ -22,31 +10,12 @@ export const documentRegistry = {
     'https://help.salesforce.com/s/articleView?id=xcloud.os_activateconfigureand_publish_flexcards_24744.htm&type=5',
   errorWhileUploadingCard:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_activateconfigureand_publish_flexcards_24744.htm&type=5',
-  errorWhileCreatingElements:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_omniscript_element_reference.htm&type=5',
-  allVersionsDescription:
-    'https://help.salesforce.com/s/articleView?id=release-notes.rn_omnistudio_migrate_all_versions.htm&release=248&type=5',
-  changeMessage: 'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   angularOSWarning:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_convert_an_angular_omniscript_to_an_lwc_omniscript.htm&type=5',
   formulaSyntaxError: 'https://help.salesforce.com/s/articleView?id=xcloud.os_formulas_and_functions_1.htm&type=5',
   fileNoOmnistudioCalls: 'https://help.salesforce.com/s/articleView?id=xcloud.os_callable_implementations.htm&type=5',
-  fileAlreadyImplementsCallable:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_callable_implementations.htm&type=5',
-  inApexDrNameWillBeUpdated:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_dataraptors_from_apex_after_migration.htm&type=5',
-  fileUpdatedToAllowRemoteCalls:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_make_a_long_running_remote_call_using_omnistudio_omnicontinuation.htm&type=5',
-  fileUpdatedToAllowCalls:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_make_a_long_running_remote_call_using_omnistudio_omnicontinuation.htm&type=5',
-  fileImplementsVlocityOpenInterface:
-    'https://help.salesforce.com/s/articleView?id=ind.v_dev_t_vlocityopeninterface_657706.htm&type=5',
-  methodCallBundleNameUpdated:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_omnistudio_custom_functions_after_migration.htm&type=5',
   cardNameChangeMessage:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
-  authordNameChangeMessage:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   omniScriptNameChangeMessage:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_omniscript_elements_with_overridden_components.htm&type=5',
   dataRaptorNameChangeMessage:
@@ -56,8 +25,6 @@ export const documentRegistry = {
   integrationProcedureManualUpdateMessage:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_dataraptors_from_apex_after_migration.htm&type=5',
   duplicateCardNameMessage: 'https://help.salesforce.com/s/articleView?id=xcloud.os_clone_a_flexcard.htm&type=5',
-  duplicateGlobalAutoNumberNameMessage:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   reservedKeysFoundInPropertySet:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   manualDeploymentSteps:
diff --git a/src/utils/constants/stringContants.ts b/src/utils/constants/stringContants.ts
@@ -15,7 +15,7 @@ export const Constants = {
   OmniScriptComponentName: 'OmniScript',
   OmniScriptPluralName: 'OmniScripts',
   FlexCardComponentName: 'Flexcard',
-  FlexCardPluralName: 'FlexCards',
+  FlexCardPluralName: 'Flexcards',
   IntegrationProcedureComponentName: 'IntegrationProcedure',
   IntegrationProcedurePluralName: 'IntegrationProcedures',
   DataRaptorComponentName: 'DataRaptor',
diff --git a/src/utils/resultsbuilder/ApexAssessmentReporter.ts b/src/utils/resultsbuilder/ApexAssessmentReporter.ts
@@ -118,19 +118,17 @@ export class ApexAssessmentReporter {
           1,
           false,
           undefined,
-          apexAssessmentInfo.infos,
-          this.getMigrationStatusCssClass(apexAssessmentInfo, true)
+          [...apexAssessmentInfo.infos, ...apexAssessmentInfo.warnings]
         ),
         createRowDataParam(
           'errors',
-          apexAssessmentInfo.warnings ? apexAssessmentInfo.warnings.join(', ') : '',
+          apexAssessmentInfo.errors ? apexAssessmentInfo.errors.join(', ') : '',
           false,
           1,
           1,
           false,
           undefined,
-          apexAssessmentInfo.warnings,
-          this.getMigrationStatusCssClass(apexAssessmentInfo, true)
+          apexAssessmentInfo.errors
         ),
       ],
     }));
diff --git a/src/utils/resultsbuilder/DRAssessmentReporter.ts b/src/utils/resultsbuilder/DRAssessmentReporter.ts
@@ -207,12 +207,7 @@ export class DRAssessmentReporter {
           1,
           false,
           undefined,
-          dataRaptorAssessmentInfo.warnings,
-          dataRaptorAssessmentInfo.migrationStatus === 'Warnings'
-            ? 'text-warning'
-            : dataRaptorAssessmentInfo.migrationStatus === 'Ready for migration'
-            ? ''
-            : 'text-error'
+          dataRaptorAssessmentInfo.warnings
         ),
         createRowDataParam(
           'customFunctionDependencies',
diff --git a/src/utils/resultsbuilder/ExperienceSiteAssessmentReporter.ts b/src/utils/resultsbuilder/ExperienceSiteAssessmentReporter.ts
@@ -121,17 +121,7 @@ export class ExperienceSiteAssessmentReporter {
           undefined,
           FileDiffUtil.getDiffHTML(experienceSiteAssessmentInfo.diff, experienceSiteAssessmentInfo.name)
         ),
-        createRowDataParam(
-          'summary',
-          '',
-          false,
-          1,
-          1,
-          false,
-          undefined,
-          experienceSiteAssessmentInfo.warnings,
-          experienceSiteAssessmentInfo.status === 'Ready for migration' ? 'text-success' : 'text-error'
-        ),
+        createRowDataParam('summary', '', false, 1, 1, false, undefined, experienceSiteAssessmentInfo.warnings),
       ],
       rowId: `${this.rowIdPrefix}${this.rowId++}`,
     }));
diff --git a/src/utils/resultsbuilder/FlexcardAssessmentReporter.ts b/src/utils/resultsbuilder/FlexcardAssessmentReporter.ts
@@ -207,12 +207,7 @@ export class FlexcardAssessmentReporter {
           1,
           false,
           undefined,
-          flexCardAssessmentInfo.warnings,
-          flexCardAssessmentInfo.migrationStatus === 'Warnings'
-            ? 'text-warning'
-            : flexCardAssessmentInfo.migrationStatus === 'Ready for migration'
-            ? ''
-            : 'text-error'
+          flexCardAssessmentInfo.warnings
         ),
         createRowDataParam(
           'omniScriptDependencies',
diff --git a/src/utils/resultsbuilder/FlexipageAssessmentReporter.ts b/src/utils/resultsbuilder/FlexipageAssessmentReporter.ts
@@ -152,12 +152,7 @@ export class FlexipageAssessmentReporter {
           1,
           false,
           undefined,
-          flexipageAssessmentInfo.errors,
-          flexipageAssessmentInfo.status === 'Needs Manual Intervention'
-            ? 'text-error'
-            : flexipageAssessmentInfo.status === 'Warnings'
-            ? 'text-warning'
-            : 'text-success'
+          flexipageAssessmentInfo.errors
         ),
       ],
       rowId: `${this.rowIdPrefix}${this.rowId++}`,
diff --git a/src/utils/resultsbuilder/GlobalAutoNumberAssessmentReporter.ts b/src/utils/resultsbuilder/GlobalAutoNumberAssessmentReporter.ts
@@ -203,8 +203,7 @@ export class GlobalAutoNumberAssessmentReporter {
             1,
             false,
             undefined,
-            allMessages,
-            this.getMigrationStatusCssClass(globalAutoNumberAssessmentInfo)
+            allMessages
           ),
         ],
       };
diff --git a/src/utils/resultsbuilder/IPAssessmentReporter.ts b/src/utils/resultsbuilder/IPAssessmentReporter.ts
@@ -108,12 +108,7 @@ export class IPAssessmentReporter {
           1,
           false,
           undefined,
-          ipAssessmentInfo.warnings,
-          ipAssessmentInfo.migrationStatus === 'Warnings'
-            ? 'text-warning'
-            : ipAssessmentInfo.migrationStatus === 'Ready for migration'
-            ? ''
-            : 'text-error'
+          ipAssessmentInfo.warnings
         ),
         createRowDataParam(
           'integrationProcedureDependencies',
diff --git a/src/utils/resultsbuilder/LWCAssessmentReporter.ts b/src/utils/resultsbuilder/LWCAssessmentReporter.ts
@@ -134,8 +134,7 @@ export class LWCAssessmentReporter {
                     1,
                     false,
                     undefined,
-                    lwcAssessmentInfo.errors,
-                    this.getMigrationStatusCssClass(lwcAssessmentInfo, true)
+                    lwcAssessmentInfo.errors
                   ),
                 ]
               : []),
diff --git a/src/utils/resultsbuilder/OSAssessmentReporter.ts b/src/utils/resultsbuilder/OSAssessmentReporter.ts
@@ -108,12 +108,7 @@ export class OSAssessmentReporter {
           1,
           false,
           undefined,
-          info.warnings,
-          info.migrationStatus === 'Warnings'
-            ? 'text-warning'
-            : info.migrationStatus === 'Ready for migration'
-            ? ''
-            : 'text-error'
+          info.warnings
         ),
         createRowDataParam(
           'omniScriptDependencies',
diff --git a/src/utils/resultsbuilder/index.ts b/src/utils/resultsbuilder/index.ts
@@ -209,8 +209,7 @@ export class ResultsBuilder {
               1,
               false,
               undefined,
-              item.errors || [],
-              item.status === 'Successfully migrated' ? '' : 'text-error'
+              item.errors || []
             ),
             createRowDataParam(
               'summary',
@@ -220,8 +219,7 @@ export class ResultsBuilder {
               1,
               false,
               undefined,
-              item.warnings || [],
-              item.status === 'Successfully migrated' ? '' : 'text-error'
+              item.warnings || []
             ),
           ],
         })),
@@ -410,8 +408,7 @@ export class ResultsBuilder {
             1,
             false,
             undefined,
-            item.warnings,
-            item.status === 'Successfully migrated' ? '' : 'text-error'
+            item.warnings
           ),
         ],
       })),
@@ -497,17 +494,7 @@ export class ResultsBuilder {
             item.status === 'Successfully migrated' ? 'text-success' : 'text-error'
           ),
           createRowDataParam('diff', '', false, 1, 1, false, undefined, FileDiffUtil.getDiffHTML(item.diff, item.name)),
-          createRowDataParam(
-            'error',
-            'error',
-            false,
-            1,
-            1,
-            false,
-            undefined,
-            item.errors,
-            item.status === 'Successfully migrated' ? '' : 'text-error'
-          ),
+          createRowDataParam('error', 'error', false, 1, 1, false, undefined, item.errors),
         ],
       })),
     };
@@ -598,27 +585,19 @@ export class ResultsBuilder {
             undefined,
             FileDiffUtil.getDiffHTML(item.diff, item.name)
           ),
-          createRowDataParam(
-            'infos',
-            item.infos ? item.infos.join(', ') : '',
-            false,
-            1,
-            1,
-            false,
-            undefined,
-            item.infos,
-            this.getStatusCssClass(item.errors, true)
-          ),
+          createRowDataParam('infos', item.infos ? item.infos.join(', ') : '', false, 1, 1, false, undefined, [
+            ...item.infos,
+            ...item.warnings,
+          ]),
           createRowDataParam(
             'warnings',
-            item.warnings.length > 0 ? 'Failed' : 'Successfully Completed',
+            item.errors.length > 0 ? 'Failed' : 'Successfully Completed',
             false,
             1,
             1,
             false,
             undefined,
-            [...item.warnings, ...item.errors],
-            this.getStatusCssClass(item.errors, true)
+            item.errors
           ),
         ],
       })),
@@ -754,8 +733,7 @@ export class ResultsBuilder {
                     1,
                     false,
                     undefined,
-                    lwcAssessmentInfo.warnings || [],
-                    this.getStatusCssClass(lwcAssessmentInfo.errors, true)
+                    lwcAssessmentInfo.warnings || []
                   ),
                   createRowDataParam(
                     'errors',
@@ -765,8 +743,7 @@ export class ResultsBuilder {
                     1,
                     false,
                     undefined,
-                    lwcAssessmentInfo.errors || [],
-                    this.getStatusCssClass(lwcAssessmentInfo.errors, true)
+                    lwcAssessmentInfo.errors || []
                   ),
                 ]
               : []),
diff --git a/test/migration/postMigrate.test.ts b/test/migration/postMigrate.test.ts
@@ -78,9 +78,7 @@ describe('PostMigrate', () => {
     // Set up default message returns
     getMessageStub.withArgs('settingDesignersToStandardModel').returns('Setting designers to standard model...');
     getMessageStub.withArgs('designersSetToStandardModel').returns('Designers set to standard model');
-    getMessageStub
-      .withArgs('errorSettingDesignersToStandardDataModel', ['Test error stack trace'])
-      .returns('Error setting designers to standard model: Test error stack trace');
+    getMessageStub.returns('Error setting designers to standard model: Test error stack trace');
     getMessageStub
       .withArgs('exceptionSettingDesignersToStandardDataModel', ['{"message":"Test exception"}'])
       .returns('Exception setting designers to standard model: {"message":"Test exception"}');
diff --git a/test/utils/XMLUtil.test.ts b/test/utils/XMLUtil.test.ts
diff --git a/test/utils/constants/documentRegistry.test.ts b/test/utils/constants/documentRegistry.test.ts
diff --git a/test/utils/storageUtil.test.ts b/test/utils/storageUtil.test.ts
