refactor: addressed comments

Author: shaurabh-tiwari-git

messages/assess.json

@@ -169,6 +169,7 @@
   "manualInterventionForExperienceSite": "We couldn’t process the %s component because no key was found.",
   "manualInterventionForExperienceSiteAsFailure": "We couldn’t process the %s component. ",
   "manualInterventionForExperienceSiteAsDuplicateKey": "We couldn’t process the %s component because a duplicate key was found. ",
+  "manualInterventionForExperienceSiteConfiguration": "We couldn’t process the %s Experience site because of some issue in the experience site configuration.",
   "updatingStorageForOmniscipt": "Preparing storage for Omniscripts",
   "keyAlreadyInStorage": "The %s %s name already exists in storage.",
   "flexcardStorageProcessingStarted": "Preparing storage for Flexcards.",

src/migration/omniscript.ts

@@ -663,7 +663,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
           const keyObject: OmniScriptStandardKey = {
             type: nameMapping.oldType,
             subtype: nameMapping.oldSubtype,
-            language: this.cleanLanguageName(nameMapping.oldLanguage),
+            language: nameMapping.oldLanguage,
           };
           StorageUtil.addStandardOmniScriptToStorage(storage, keyObject, value);
         }
@@ -1191,7 +1191,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
             const keyObject: OmniScriptStandardKey = {
               type: oldrecord[this.getFieldKey('Type__c')],
               subtype: oldrecord[this.getFieldKey('SubType__c')],
-              language: this.cleanLanguageName(oldrecord[this.getFieldKey('Language__c')]),
+              language: oldrecord[this.getFieldKey('Language__c')],
             };
             StorageUtil.addStandardOmniScriptToStorage(storage, keyObject, value);
           }

src/migration/related/ExperienceSiteMigration.ts

@@ -257,7 +257,7 @@ export class ExperienceSiteMigration extends BaseRelatedObjectMigration {
 
     if (this.IS_STANDARD_DATA_MODEL) {
       // Check for new LWC components that need reference updates
-      if (this.isOmnistudioComponent(component.componentName)) {
+      if (this.isOmnistudioStandardWrapper(component.componentName)) {
         Logger.logVerbose(`Found Omnistudio component: ${component.componentName}`);
         experienceSiteAssessmentInfo.hasOmnistudioContent = true;
 
@@ -380,7 +380,7 @@ export class ExperienceSiteMigration extends BaseRelatedObjectMigration {
   /**
    * Check if component is an Omnistudio LWC component
    */
-  private isOmnistudioComponent(componentName: string): boolean {
+  private isOmnistudioStandardWrapper(componentName: string): boolean {
     return (
       componentName === TARGET_COMPONENT_NAME_OS ||
       componentName === TARGET_COMPONENT_NAME_FC ||
@@ -424,6 +424,11 @@ export class ExperienceSiteMigration extends BaseRelatedObjectMigration {
     const currentLanguage = attributes['language'] as string;
 
     if (!currentType || !currentSubType || !currentLanguage) {
+      const warningMsg = this.messages.getMessage('manualInterventionForExperienceSiteConfiguration', [
+        `${currentType}_${currentSubType}_${currentLanguage}`,
+      ]);
+      experienceSiteAssessmentInfo.warnings.push(warningMsg);
+      experienceSiteAssessmentInfo.status = type === this.ASSESS ? 'Needs Manual Intervention' : 'Skipped';
       return;
     }
 

src/utils/storageUtil.ts

@@ -42,13 +42,6 @@ export class StorageUtil {
     return this.omnistudioAssessmentStorage;
   }
 
-  /**
-   * Serialize OmniScriptStandardKey to string for Map storage
-   */
-  public static serializeOmniScriptKey(key: OmniScriptStandardKey): string {
-    return JSON.stringify(key);
-  }
-
   /**
    * Add Standard OmniScript to storage
    */
@@ -81,6 +74,13 @@ export class StorageUtil {
     this.printStorage(this.omnistudioAssessmentStorage);
   }
 
+  /**
+   * Serialize OmniScriptStandardKey to string for Map storage
+   */
+  private static serializeOmniScriptKey(key: OmniScriptStandardKey): string {
+    return JSON.stringify(key);
+  }
+
   private static printStorage(storage: MigrationStorage): void {
     try {
       Logger.logVerbose('Printing the storage');