chore: resolved comments

Author: sf-aastha-paruthi

messages/assess.json

@@ -13,6 +13,7 @@
   "commandDescription": "If your Omnistudio components are on custom data model, assess the migration of the components from Omnistudio managed package runtime to Omnistudio standard runtime. If your Omnistudio components are on standard data model, assess the updates made to the component names and references.See: https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5",
   "errorNoOrgResults": "No records found in the org '%s' to migrate.",
   "onlyFlagDescription": "Migrate a single component: os | ip | fc | dm | autonumber | cl",
+  "invalidOnlyFlag": "Invalid parameter entered. Select a valid parameter from these options: os | ip | fc | dm | autonumber | cl",
   "couldNotTruncate": "We couldn't clear all %s records.",
   "couldNotTruncateOmnniProcess": "We couldn't clear all records of your %s because the %s is referenced in an Omniscript or a Flexcard.",
   "invalidOrRepeatingOmniscriptElementNames": "Omniscript with invalid or duplicate element names found. Rename your Omniscript elements and try again.",

src/commands/omnistudio/migration/assess.ts

@@ -281,10 +281,11 @@ export default class Assess extends OmniStudioBaseCommand {
   private async assessDataRaptors(assesmentInfo: AssessmentInfo, namespace: string, conn: Connection): Promise<void> {
     const drMigrator = new DataRaptorMigrationTool(namespace, conn, Logger, messages, this.ux);
     assesmentInfo.dataRaptorAssessmentInfos = await drMigrator.assess();
-    Logger.logVerbose(
-      messages.getMessage('assessedDataRaptorsCount', [assesmentInfo.dataRaptorAssessmentInfos.length])
+    this.logAssessmentCompletionIfNeeded(
+      'assessedDataRaptorsCount',
+      'dataRaptorAssessmentCompleted',
+      assesmentInfo.dataRaptorAssessmentInfos.length
     );
-    Logger.log(messages.getMessage('dataRaptorAssessmentCompleted'));
   }
 
   private async assessFlexCards(
@@ -294,10 +295,12 @@ export default class Assess extends OmniStudioBaseCommand {
     allVersions: boolean
   ): Promise<void> {
     const flexMigrator = new CardMigrationTool(namespace, conn, Logger, messages, this.ux, allVersions);
-    Logger.logVerbose(messages.getMessage('flexCardAssessment'));
     assesmentInfo.flexCardAssessmentInfos = await flexMigrator.assess();
-    Logger.logVerbose(messages.getMessage('assessedFlexCardsCount', [assesmentInfo.flexCardAssessmentInfos.length]));
-    Logger.log(messages.getMessage('flexCardAssessmentCompleted'));
+    this.logAssessmentCompletionIfNeeded(
+      'assessedFlexCardsCount',
+      'flexCardAssessmentCompleted',
+      assesmentInfo.flexCardAssessmentInfos.length
+    );
   }
 
   private async assessOmniScripts(
@@ -308,7 +311,6 @@ export default class Assess extends OmniStudioBaseCommand {
     exportType: OmniScriptExportType
   ): Promise<void> {
     const exportComponentType = exportType === OmniScriptExportType.IP ? 'Integration Procedures' : 'Omniscripts';
-    Logger.logVerbose(messages.getMessage('omniScriptAssessment', [exportComponentType]));
     const osMigrator = new OmniScriptMigrationTool(exportType, namespace, conn, Logger, messages, this.ux, allVersions);
     const newOmniAssessmentInfo = await osMigrator.assess(
       assesmentInfo.dataRaptorAssessmentInfos,
@@ -327,19 +329,26 @@ export default class Assess extends OmniStudioBaseCommand {
     if (exportType === OmniScriptExportType.OS) {
       // For OmniScript assessment, update osAssessmentInfos
       assesmentInfo.omniAssessmentInfo.osAssessmentInfos = newOmniAssessmentInfo.osAssessmentInfos;
-      Logger.logVerbose(
-        messages.getMessage('assessedOmniScriptsCount', [assesmentInfo.omniAssessmentInfo.osAssessmentInfos.length])
-      );
     } else {
       // For Integration Procedure assessment, update ipAssessmentInfos
       assesmentInfo.omniAssessmentInfo.ipAssessmentInfos = newOmniAssessmentInfo.ipAssessmentInfos;
-      Logger.logVerbose(
-        messages.getMessage('assessedIntegrationProceduresCount', [
-          assesmentInfo.omniAssessmentInfo.ipAssessmentInfos.length,
-        ])
+    }
+
+    if (exportType === OmniScriptExportType.OS) {
+      this.logAssessmentCompletionIfNeeded(
+        'assessedOmniScriptsCount',
+        'omniScriptAssessmentCompleted',
+        assesmentInfo.omniAssessmentInfo.osAssessmentInfos.length,
+        [exportComponentType]
+      );
+    } else {
+      this.logAssessmentCompletionIfNeeded(
+        'assessedIntegrationProceduresCount',
+        'omniScriptAssessmentCompleted',
+        assesmentInfo.omniAssessmentInfo.ipAssessmentInfos.length,
+        [exportComponentType]
       );
     }
-    Logger.log(messages.getMessage('omniScriptAssessmentCompleted', [exportComponentType]));
   }
 
   private async assessGlobalAutoNumbers(
@@ -378,4 +387,21 @@ export default class Assess extends OmniStudioBaseCommand {
       };
     }
   }
+
+  /**
+   * Logs assessment completion with count and completion message if needed
+   * Skips logging when standard data model with metadata API is enabled
+   */
+  private logAssessmentCompletionIfNeeded(
+    countMessageKey: string,
+    completionMessageKey: string,
+    count: number,
+    completionParams?: string[]
+  ): void {
+    if (isStandardDataModelWithMetadataAPIEnabled()) {
+      return;
+    }
+    Logger.logVerbose(messages.getMessage(countMessageKey, [count]));
+    Logger.log(messages.getMessage(completionMessageKey, completionParams || []));
+  }
 }

src/commands/omnistudio/migration/migrate.ts

@@ -75,6 +75,14 @@ export default class Migrate extends OmniStudioBaseCommand {
     }),
   };
 
+  // OmniStudio components that don't need migration logging when metadata API is enabled
+  private readonly OMNISTUDIO_COMPONENTS_FOR_LOGGING = [
+    Constants.Omniscript,
+    Constants.IntegrationProcedure,
+    Constants.Flexcard,
+    Constants.DataMapper,
+  ];
+
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   public async run(): Promise<any> {
     Logger.initialiseLogger(this.ux, this.logger, 'migrate', this.flags.verbose);
@@ -389,22 +397,10 @@ export default class Migrate extends OmniStudioBaseCommand {
     for (const cls of migrationObjects) {
       try {
         const componentName = cls.getName();
-        const shouldSkipLogging = this.shouldSkipMigrationLogging(componentName);
 
-        if (!shouldSkipLogging) {
-          Logger.log(messages.getMessage('migratingComponent', [componentName]));
-        }
-        debugTimer.lap('Migrating: ' + componentName);
+        this.logMigrationStart(componentName, debugTimer);
         const results = await cls.migrate();
-
-        // Skip success/failure logs for components that don't need migration when metadata API is enabled
-        if (!shouldSkipLogging) {
-          if (results.some((result) => result?.errors?.length > 0) && !isStandardDataModelWithMetadataAPIEnabled()) {
-            Logger.error(messages.getMessage('migrationFailed', [componentName]));
-          } else {
-            Logger.log(messages.getMessage('migrationCompleted', [componentName]));
-          }
-        }
+        this.logMigrationComplete(componentName, results);
 
         objectMigrationResults = objectMigrationResults.concat(
           results.map((r) => {
@@ -434,6 +430,33 @@ export default class Migrate extends OmniStudioBaseCommand {
     return objectMigrationResults;
   }
 
+  /**
+   * Log the start of component migration and track timing
+   */
+  private logMigrationStart(componentName: string, debugTimer: DebugTimer): void {
+    const shouldSkipLogging = this.shouldSkipMigrationLogging(componentName);
+
+    if (!shouldSkipLogging) {
+      Logger.log(messages.getMessage('migratingComponent', [componentName]));
+      debugTimer.lap('Migrating: ' + componentName);
+    }
+  }
+
+  /**
+   * Log the completion or failure of component migration
+   */
+  private logMigrationComplete(componentName: string, results: MigrationResult[]): void {
+    const shouldSkipLogging = this.shouldSkipMigrationLogging(componentName);
+
+    if (!shouldSkipLogging) {
+      if (results.some((result) => result?.errors?.length > 0) && !isStandardDataModelWithMetadataAPIEnabled()) {
+        Logger.error(messages.getMessage('migrationFailed', [componentName]));
+      } else {
+        Logger.log(messages.getMessage('migrationCompleted', [componentName]));
+      }
+    }
+  }
+
   /**
    * Check if migration logging should be skipped for a component
    * Returns true if Metadata API is enabled and the component doesn't need migration
@@ -444,14 +467,9 @@ export default class Migrate extends OmniStudioBaseCommand {
     }
 
     // Skip logging for OmniStudio components that don't need migration when metadata API is enabled
-    const omnistudioComponents = [
-      Constants.Omniscript,
-      Constants.IntegrationProcedure,
-      Constants.Flexcard,
-      Constants.DataMapper,
-    ];
-
-    return omnistudioComponents.some((component) => componentName.toLowerCase().includes(component.toLowerCase()));
+    return this.OMNISTUDIO_COMPONENTS_FOR_LOGGING.some((component) =>
+      componentName.toLowerCase().includes(component.toLowerCase())
+    );
   }
 
   /**

src/utils/config/OmniStudioMetadataCleanupService.ts

@@ -67,7 +67,7 @@ export class OmniStudioMetadataCleanupService {
     try {
       if (isStandardDataModelWithMetadataAPIEnabled()) {
         // When on Standard data model with Metadata API enabled, the metadata tables should not be cleaned
-        return true;
+        return false;
       }
 
       Logger.log(this.messages.getMessage('startingMetadataCleanup'));