[W-11333914] FlexCard migration changes & OmniProcessElement name validation removal (#33)

agarcia-sf · web-flow · commit 7f3695896ef9 · 2022-06-23T13:21:10.000-07:00
diff --git a/messages/migrate.json b/messages/migrate.json
@@ -21,5 +21,6 @@
   "duplicatedCardName": "Duplicated Flex Card name",
   "duplicatedDrName": "Duplicated DataRaptor name",
   "duplicatedOSName": "Duplicated OmniScript name",
-  "errorWhileActivatingOs": "Could not activate OmniScript"
+  "errorWhileActivatingOs": "Could not activate OmniScript / Integration Procedure: ",
+  "errorWhileActivatingCard": "Could not activate Card: "
 }
diff --git a/src/commands/omnistudio/migration/migrate.ts b/src/commands/omnistudio/migration/migrate.ts
@@ -12,7 +12,6 @@ import { flags } from '@salesforce/command';
 import { Messages } from '@salesforce/core';
 import '../../../utils/prototypes';
 import OmniStudioBaseCommand from '../../basecommand';
-import { MetaDataObjNameCheck } from '../../../migration/metadataobjnamecheck';
 import { DataRaptorMigrationTool } from '../../../migration/dataraptor';
 import { DebugTimer, MigratedObject, MigratedRecordInfo } from '../../../utils';
 import { MigrationResult, MigrationTool } from '../../../migration/interfaces';
@@ -58,15 +57,9 @@ export default class Migrate extends OmniStudioBaseCommand {
     // Let's time every step
     DebugTimer.getInstance().start();
 
-    const namecheck = new MetaDataObjNameCheck(namespace, conn, this.logger, messages, this.ux);
-
     // Register the migration objects
     let migrationObjects: MigrationTool[] = [];
     if (!migrateOnly) {
-      await namecheck.checkName('DRBundle__c');
-      await namecheck.checkName('OmniScript__c');
-      await namecheck.checkName('VlocityCard__c');
-
       migrationObjects = [
         new DataRaptorMigrationTool(namespace, conn, this.logger, messages, this.ux),
         new OmniScriptMigrationTool(OmniScriptExportType.All, namespace, conn, this.logger, messages, this.ux),
@@ -75,23 +68,19 @@ export default class Migrate extends OmniStudioBaseCommand {
     } else {
       switch (migrateOnly) {
         case 'os':
-          await namecheck.checkName('OmniScript__c');
           migrationObjects.push(
             new OmniScriptMigrationTool(OmniScriptExportType.OS, namespace, conn, this.logger, messages, this.ux)
           );
           break;
         case 'ip':
-          await namecheck.checkName('OmniScript__c');
           migrationObjects.push(
             new OmniScriptMigrationTool(OmniScriptExportType.IP, namespace, conn, this.logger, messages, this.ux)
           );
           break;
         case 'fc':
-          await namecheck.checkName('VlocityCard__c');
           migrationObjects.push(new CardMigrationTool(namespace, conn, this.logger, messages, this.ux));
           break;
         case 'dr':
-          await namecheck.checkName('DRBundle__c');
           migrationObjects.push(new DataRaptorMigrationTool(namespace, conn, this.logger, messages, this.ux));
           break;
         default:
@@ -169,13 +158,15 @@ export default class Migrate extends OmniStudioBaseCommand {
         status: 'Skipped',
         errors: record['errors'],
         migratedId: undefined,
+        warnings: [],
       };
 
       if (migrationResults.results.has(record['Id'])) {
         const recordResults = migrationResults.results.get(record['Id']);
         obj.status = !recordResults || recordResults.hasErrors ? 'Error' : 'Complete';
         obj.errors = obj.errors || recordResults.errors;
         obj.migratedId = recordResults.id;
+        obj.warnings = recordResults.warnings;
       }
 
       mergedResults.push(obj);
diff --git a/src/migration/flexcard.ts b/src/migration/flexcard.ts
@@ -145,14 +145,25 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
 			}
 
 			// If name has been changed, add a warning message
-			if (transformedCardName !== card[this.namespacePrefix + 'Name']) {
-				uploadResult.errors.unshift('WARNING: Card name has been modified to fit naming rules: ' + transformedCardName);
-			}
+			uploadResult.warnings = uploadResult.warnings || [];
 			if (transformedCardAuthorName !== card[this.namespacePrefix + 'Author__c']) {
-				uploadResult.errors.unshift('WARNING: Card author name has been modified to fit naming rules: ' + transformedCardAuthorName);
+				uploadResult.warnings.unshift('WARNING: Card author name has been modified to fit naming rules: ' + transformedCardAuthorName);
+			}
+			if (transformedCardName !== card['Name']) {
+				uploadResult.warnings.unshift('WARNING: Card name has been modified to fit naming rules: ' + transformedCardName);
 			}
 
 			cardsUploadInfo.set(recordId, uploadResult);
+			const updateResult = await NetUtils.updateOne(this.connection, CardMigrationTool.OMNIUICARD_NAME, recordId, uploadResult.id, {
+				[CardMappings.Active__c]: true
+			});
+
+			if (!updateResult.success) {
+				uploadResult.hasErrors = true;
+				uploadResult.errors = uploadResult.errors || [];
+
+				uploadResult.errors.push(this.messages.getMessage('errorWhileActivatingCard') + updateResult.errors);
+			}
 		}
 	}
 
@@ -237,7 +248,8 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
 
 		// Clean the name
 		mappedObject['Name'] = this.cleanName(mappedObject['Name']);
-		mappedObject['AuthorName'] = this.cleanName(mappedObject['AuthorName']);
+		mappedObject[CardMappings.Author__c] = this.cleanName(mappedObject[CardMappings.Author__c]);
+		mappedObject[CardMappings.Active__c] = false;
 
 		mappedObject['attributes'] = {
 			type: CardMigrationTool.OMNIUICARD_NAME,
diff --git a/src/migration/interfaces.ts b/src/migration/interfaces.ts
@@ -39,6 +39,7 @@ export interface UploadRecordResult {
   referenceId: string;
   id?: string;
   errors: string[];
+  warnings: string[];
   hasErrors: boolean;
   success?: boolean;
 }
diff --git a/src/migration/omniscript.ts b/src/migration/omniscript.ts
@@ -148,12 +148,6 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 			// Get All elements for each OmniScript__c record(i.e IP/OS)
 			const elements = await this.getAllElementsForOmniScript(recordId);
 
-			if (!this.areValidElements(elements)) {
-				this.setRecordErrors(omniscript, this.messages.getMessage('invalidOrRepeatingOmniscriptElementNames'));
-				originalOsRecords.set(recordId, omniscript);
-				continue;
-			}
-
 			// Perform the transformation for OS/IP Parent Record from OmniScript__c
 			const mappedOmniScript = this.mapOmniScriptRecord(omniscript);
 
@@ -174,7 +168,6 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 			mappedRecords.push(mappedOmniScript);
 
 			// Save the OmniScript__c records to Standard BPO i.e OmniProcess
-			// const osUploadResponse: Map<string, UploadRecordResult> = await this.uploadTransformedData(OmniScriptMigrationTool.OMNIPROCESS_NAME, { mappedRecords, originalRecords });
 			const osUploadResponse = await NetUtils.createOne(this.connection, OmniScriptMigrationTool.OMNIPROCESS_NAME, recordId, mappedOmniScript);
 
 			if (osUploadResponse.success) {
@@ -184,15 +177,17 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 				if (!osUploadResponse.success) {
 					osUploadResponse.errors = Array.isArray(osUploadResponse.errors) ? osUploadResponse.errors : [osUploadResponse.errors];
 				}
+        
+				osUploadResponse.warnings = osUploadResponse.warnings || [];
 
 				const originalOsName = omniscript[this.namespacePrefix + 'Type__c'] + '_' + omniscript[this.namespacePrefix + 'SubType__c'] + '_' + omniscript[this.namespacePrefix + 'Language__c'];
 				if (originalOsName !== mappedOsName) {
-					osUploadResponse.errors.unshift('WARNING: OmniScript name has been modified to fit naming rules: ' + mappedOsName);
+					osUploadResponse.warnings.unshift('WARNING: OmniScript name has been modified to fit naming rules: ' + mappedOsName);
 				}
 
 				// Upload All elements for each OmniScript__c record(i.e IP/OS)
 				await this.uploadAllElements(osUploadResponse, elements);
-
+        
 				// Get OmniScript Compiled Definitions for OmniScript Record
 				const omniscriptsCompiledDefinitions = await this.getOmniScriptCompiledDefinition(recordId);
 
@@ -206,15 +201,16 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 				if (mappedRecords[0].IsIntegrationProcedure) {
 					mappedRecords[0].Language = 'Procedure';
 				}
+        
+				const updateResult = await NetUtils.updateOne(this.connection, OmniScriptMigrationTool.OMNIPROCESS_NAME, recordId, osUploadResponse.id, {
+					[OmniScriptMappings.IsActive__c]: true
+				});
 
-				const updateResult = await this.updateData({ mappedRecords, originalRecords: originalOsRecords });
-				if (updateResult.has(osUploadResponse.id)) {
-					const res = updateResult.get(osUploadResponse.id);
-					if (!res.success) {
-						osUploadResponse.hasErrors = true;
-						osUploadResponse.errors = osUploadResponse.errors || [];
-						osUploadResponse.errors.push(this.messages.getMessage('errorWhileActivatingOs'));
-					}
+				if (!updateResult.success) {
+					osUploadResponse.hasErrors = true;
+					osUploadResponse.errors = osUploadResponse.errors || [];
+
+					osUploadResponse.errors.push(this.messages.getMessage('errorWhileActivatingOs') + updateResult.errors);
 				}
 
 				// Create the return records and response which have been processed
@@ -499,24 +495,6 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
 		return Object.keys(OmniScriptDefinitionMappings);
 	}
 
-	private areValidElements(elements: AnyJson[]): boolean {
-		const elementNames = new Set<string>();
-		for (let element of elements) {
-			let elementName: string = this.cleanName(element['Name']);
-			if (!elementName) {
-				return false;
-			}
-
-			if (elementNames.has(elementName)) {
-				return false;
-			}
-
-			elementNames.add(elementName);
-			element['Name'] = elementName;
-		}
-		return true;
-	}
-
 	private sleep() {
 		return new Promise(resolve => {
 			setTimeout(resolve, 5000);
diff --git a/src/utils/interfaces.ts b/src/utils/interfaces.ts
@@ -10,4 +10,5 @@ export interface MigratedRecordInfo {
   status: string;
   errors: string[];
   migratedId?: string;
+  warnings: string[];
 }
diff --git a/src/utils/net/index.ts b/src/utils/net/index.ts
@@ -38,7 +38,34 @@ class NetUtils {
                 referenceId,
                 hasErrors: true,
                 success: false,
-                errors: err
+                errors: err,
+                warnings: []
+            };
+        }
+    }
+
+    public static async updateOne(connection: Connection, objectName: string, referenceId: string, recordId: string, data: any): Promise<UploadRecordResult> {
+
+        try {
+            const url = 'sobjects/' + objectName + '/' + recordId;
+
+            await this.request<UploadRecordResult>(connection, url, data, RequestMethod.PATCH);
+
+            return {
+                referenceId,
+                hasErrors: false,
+                success: true,
+                errors: [],
+                warnings: []
+            }
+
+        } catch (err) {
+            return {
+                referenceId,
+                hasErrors: true,
+                success: false,
+                errors: err,
+                warnings: []
             };
         }
     }
diff --git a/src/utils/resultsbuilder/index.ts b/src/utils/resultsbuilder/index.ts
@@ -81,16 +81,16 @@ export class ResultsBuilder {
             <table class="slds-table slds-table_cell-buffer slds-table_bordered slds-table_striped slds-table_col-bordered" aria-label="Results for ${migrationResult.name}">
             <thead>
                 <tr class="slds-line-height_reset">
-                    <th class="" scope="col">
+                    <th class="" scope="col" style="width: 10%">
                         <div class="slds-truncate" title="Record ID">Record ID</div>
                     </th>
-                    <th class="" scope="col">
+                    <th class="" scope="col" style="width: 30%">
                         <div class="slds-truncate" title="Name">Name</div>
                     </th>
-                    <th class="" scope="col">
+                    <th class="" scope="col" style="width: 10%">
                         <div class="slds-truncate" title="Status">Status</div>
                     </th>
-                    <th class="" scope="col">
+                    <th class="" scope="col" style="width: 10%">
                         <div class="slds-truncate" title="New Record ID">New Record ID</div>
                     </th>
                     <th class="" scope="col">

Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,6 @@`
`21`	`21`	`"duplicatedCardName": "Duplicated Flex Card name",`
`22`	`22`	`"duplicatedDrName": "Duplicated DataRaptor name",`
`23`	`23`	`"duplicatedOSName": "Duplicated OmniScript name",`
`24`		`- "errorWhileActivatingOs": "Could not activate OmniScript"`
	`24`	`+ "errorWhileActivatingOs": "Could not activate OmniScript / Integration Procedure: ",`
	`25`	`+ "errorWhileActivatingCard": "Could not activate Card: "`
`25`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ export interface UploadRecordResult {`
`39`	`39`	`referenceId: string;`
`40`	`40`	`id?: string;`
`41`	`41`	`errors: string[];`
	`42`	`+ warnings: string[];`
`42`	`43`	`hasErrors: boolean;`
`43`	`44`	`success?: boolean;`
`44`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,5 @@ export interface MigratedRecordInfo {`
`10`	`10`	`status: string;`
`11`	`11`	`errors: string[];`
`12`	`12`	`migratedId?: string;`
	`13`	`+ warnings: string[];`
`13`	`14`	`}`