Skip to content

Commit 91768d6

Browse files
chore: flexcard assessment storage and expFlexcard fix
1 parent a5c8335 commit 91768d6

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

src/migration/flexcard.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
113113
const flexCards = await this.getAllActiveCards();
114114
Logger.log(this.messages.getMessage('foundFlexCardsToAssess', [flexCards.length]));
115115

116-
const flexCardsAssessmentInfos = this.processCardComponents(flexCards);
116+
const flexCardsAssessmentInfos = await this.processCardComponents(flexCards);
117+
this.prepareAssessmentStorageForFlexcards(flexCardsAssessmentInfos);
117118
return flexCardsAssessmentInfos;
118119
} catch (err) {
119120
if (err instanceof InvalidEntityTypeError) {
@@ -135,9 +136,6 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
135136
try {
136137
const flexCardAssessmentInfo = await this.processFlexCard(flexCard, uniqueNames);
137138
flexCardAssessmentInfos.push(flexCardAssessmentInfo);
138-
139-
// Prepare assessment storage for flexcards
140-
this.prepareAssessmentStorageForFlexcards(flexCardAssessmentInfos);
141139
} catch (e) {
142140
flexCardAssessmentInfos.push({
143141
name: flexCard['Name'],
@@ -647,8 +645,8 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
647645
isDuplicate: false,
648646
};
649647

650-
if (flexCardAssessmentInfo.warnings) {
651-
value.error = flexCardAssessmentInfo.warnings;
648+
if (Array.isArray(flexCardAssessmentInfo.errors) && flexCardAssessmentInfo.errors.length > 0) {
649+
value.error = flexCardAssessmentInfo.errors;
652650
value.migrationSuccess = false;
653651
} else {
654652
value.migrationSuccess = true;
@@ -668,9 +666,8 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
668666
Logger.logVerbose(this.messages.getMessage('errorWhileProcessingFlexcardStorage'));
669667
Logger.error(error);
670668
}
671-
672-
StorageUtil.printMigrationStorage();
673669
}
670+
StorageUtil.printAssessmentStorage();
674671
}
675672

676673
private prepareStorageForFlexcards(

src/migration/related/ExperienceSiteMigration.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ export class ExperienceSiteMigration extends BaseRelatedObjectMigration {
259259
): void {
260260
Logger.logVerbose(this.messages.getMessage('processingFlexcardComponent', [JSON.stringify(component)]));
261261
const flexcardName = targetName.substring(2); // cfCardName -> CardName
262-
const targetDataFromStorageFC: FlexcardStorage = storage.fcStorage.get(flexcardName);
262+
const targetDataFromStorageFC: FlexcardStorage = storage.fcStorage.get(flexcardName.toLowerCase());
263263

264264
Logger.logVerbose(this.messages.getMessage('targetData', [JSON.stringify(targetDataFromStorageFC)]));
265265

@@ -269,6 +269,11 @@ export class ExperienceSiteMigration extends BaseRelatedObjectMigration {
269269
experienceSiteAssessmentInfo.warnings.push(warningMsg);
270270
} else {
271271
component.componentName = TARGET_COMPONENT_NAME_FC;
272+
273+
const keysToDelete = ['target', 'layout', 'params', 'standalone'];
274+
275+
keysToDelete.forEach((key) => delete currentAttribute[key]);
276+
272277
currentAttribute['flexcardName'] = targetDataFromStorageFC.name;
273278
currentAttribute['objectApiName'] = '{!objectApiName}';
274279
currentAttribute['recordId'] = '{!recordId}';

0 commit comments

Comments
 (0)