Skip to content

Commit 9269133

Browse files
fix: updated tests
1 parent 540f475 commit 9269133

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

test/utils/config/OmniStudioMetadataCleanupService.test.ts

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ describe('OmniStudioMetadataCleanupService', () => {
3535
// Mock QueryTools.queryIds
3636
queryIdsStub = sandbox.stub(QueryTools, 'queryIds');
3737

38-
// Mock NetUtils.delete
39-
deleteStub = sandbox.stub(NetUtils, 'delete');
38+
// Mock NetUtils.deleteWithFieldIntegrityException
39+
deleteStub = sandbox.stub(NetUtils, 'deleteWithFieldIntegrityException');
4040

4141
// Setup default message responses
4242
(messages.getMessage as sinon.SinonStub)
@@ -190,7 +190,7 @@ describe('OmniStudioMetadataCleanupService', () => {
190190
.resolves([]) // OmniIntegrationProcConfig
191191
.onCall(3)
192192
.resolves(['id4', 'id5', 'id6']); // OmniDataTransformConfig
193-
deleteStub.resolves(true); // All deletions successful
193+
deleteStub.resolves({ success: true }); // All deletions successful
194194
(messages.getMessage as sinon.SinonStub)
195195
.withArgs('metadataCleanupCompleted', ['6'])
196196
.returns('The Omnistudio metadata table cleanup process is complete. Total records cleaned: 6');
@@ -214,7 +214,7 @@ describe('OmniStudioMetadataCleanupService', () => {
214214
// Arrange
215215
const service = new OmniStudioMetadataCleanupService(connection, messages);
216216
queryIdsStub.resolves([]); // All tables empty
217-
deleteStub.resolves(true);
217+
deleteStub.resolves({ success: true });
218218
(messages.getMessage as sinon.SinonStub)
219219
.withArgs('metadataCleanupCompleted', ['0'])
220220
.returns('The Omnistudio metadata table cleanup process is complete. Total records cleaned: 0');
@@ -246,11 +246,11 @@ describe('OmniStudioMetadataCleanupService', () => {
246246
.resolves(['id3']); // OmniDataTransformConfig
247247
deleteStub
248248
.onFirstCall()
249-
.resolves(true) // First deletion successful
249+
.resolves({ success: true }) // First deletion successful
250250
.onSecondCall()
251-
.resolves(false) // Second deletion fails
251+
.resolves({ success: false, statusCode: 'SOME_ERROR' }) // Second deletion fails
252252
.onThirdCall()
253-
.resolves(true); // Third deletion successful
253+
.resolves({ success: true }); // Third deletion successful
254254
(messages.getMessage as sinon.SinonStub)
255255
.withArgs('failedToCleanTables', ['OmniScriptConfig'])
256256
.returns('Table cleanup failed: OmniScriptConfig');
@@ -262,7 +262,7 @@ describe('OmniStudioMetadataCleanupService', () => {
262262
expect(result).to.be.false;
263263
expect(queryIdsStub.callCount).to.equal(4);
264264
expect(deleteStub.callCount).to.equal(3);
265-
expect(loggerErrorStub.calledOnce).to.be.true;
265+
expect(loggerErrorStub.callCount).to.equal(1);
266266
expect(loggerErrorStub.firstCall.args[0]).to.equal('Table cleanup failed: OmniScriptConfig');
267267
});
268268

@@ -280,13 +280,13 @@ describe('OmniStudioMetadataCleanupService', () => {
280280
.resolves(['id4']); // OmniDataTransformConfig
281281
deleteStub
282282
.onFirstCall()
283-
.resolves(false) // First deletion fails
283+
.resolves({ success: false, statusCode: 'SOME_ERROR' }) // First deletion fails
284284
.onSecondCall()
285-
.resolves(true) // Second deletion successful
285+
.resolves({ success: true }) // Second deletion successful
286286
.onCall(2)
287-
.resolves(false) // Third deletion fails
287+
.resolves({ success: false, statusCode: 'SOME_ERROR' }) // Third deletion fails
288288
.onCall(3)
289-
.resolves(true); // Fourth deletion successful
289+
.resolves({ success: true }); // Fourth deletion successful
290290
(messages.getMessage as sinon.SinonStub)
291291
.withArgs('failedToCleanTables', ['OmniUiCardConfig, OmniIntegrationProcConfig'])
292292
.returns('Table cleanup failed: OmniUiCardConfig, OmniIntegrationProcConfig');
@@ -298,7 +298,7 @@ describe('OmniStudioMetadataCleanupService', () => {
298298
expect(result).to.be.false;
299299
expect(queryIdsStub.callCount).to.equal(4);
300300
expect(deleteStub.callCount).to.equal(4);
301-
expect(loggerErrorStub.calledOnce).to.be.true;
301+
expect(loggerErrorStub.callCount).to.equal(1);
302302
expect(loggerErrorStub.firstCall.args[0]).to.equal(
303303
'Table cleanup failed: OmniUiCardConfig, OmniIntegrationProcConfig'
304304
);
@@ -338,11 +338,11 @@ describe('OmniStudioMetadataCleanupService', () => {
338338
.resolves(['id4', 'id5']); // OmniDataTransformConfig - 2 records
339339
deleteStub
340340
.onFirstCall()
341-
.resolves(true) // OmniUiCardConfig deletion successful
341+
.resolves({ success: true }) // OmniUiCardConfig deletion successful
342342
.onSecondCall()
343-
.resolves(false) // OmniIntegrationProcConfig deletion fails
343+
.resolves({ success: false, statusCode: 'SOME_ERROR' }) // OmniIntegrationProcConfig deletion fails
344344
.onThirdCall()
345-
.resolves(true); // OmniDataTransformConfig deletion successful
345+
.resolves({ success: true }); // OmniDataTransformConfig deletion successful
346346
(messages.getMessage as sinon.SinonStub)
347347
.withArgs('failedToCleanTables', ['OmniIntegrationProcConfig'])
348348
.returns('Table cleanup failed: OmniIntegrationProcConfig');
@@ -354,7 +354,7 @@ describe('OmniStudioMetadataCleanupService', () => {
354354
expect(result).to.be.false;
355355
expect(queryIdsStub.callCount).to.equal(4);
356356
expect(deleteStub.callCount).to.equal(3); // Only called for tables with records
357-
expect(loggerErrorStub.calledOnce).to.be.true;
357+
expect(loggerErrorStub.callCount).to.equal(1);
358358
expect(loggerErrorStub.firstCall.args[0]).to.equal('Table cleanup failed: OmniIntegrationProcConfig');
359359
});
360360
});
@@ -364,7 +364,7 @@ describe('OmniStudioMetadataCleanupService', () => {
364364
// Arrange
365365
const service = new OmniStudioMetadataCleanupService(connection, messages);
366366
queryIdsStub.resolves([]); // Empty table
367-
deleteStub.resolves(true);
367+
deleteStub.resolves({ success: true });
368368

369369
// Act
370370
const result = await service.cleanupOmniStudioMetadataTables();
@@ -381,7 +381,7 @@ describe('OmniStudioMetadataCleanupService', () => {
381381
queryIdsStub.onCall(1).resolves([]); // Other tables empty
382382
queryIdsStub.onCall(2).resolves([]);
383383
queryIdsStub.onCall(3).resolves([]);
384-
deleteStub.resolves(true);
384+
deleteStub.resolves({ success: true });
385385

386386
// Act
387387
const result = await service.cleanupOmniStudioMetadataTables();
@@ -400,15 +400,15 @@ describe('OmniStudioMetadataCleanupService', () => {
400400
queryIdsStub.onCall(1).resolves([]); // Other tables empty
401401
queryIdsStub.onCall(2).resolves([]);
402402
queryIdsStub.onCall(3).resolves([]);
403-
deleteStub.resolves(false); // Deletion fails
403+
deleteStub.resolves({ success: false, statusCode: 'SOME_ERROR' }); // Deletion fails
404404

405405
// Act
406406
const result = await service.cleanupOmniStudioMetadataTables();
407407

408408
// Assert
409409
expect(result).to.be.false;
410410
expect(deleteStub.calledOnce).to.be.true;
411-
expect(loggerErrorStub.calledOnce).to.be.true;
411+
expect(loggerErrorStub.callCount).to.equal(1);
412412
expect(loggerErrorStub.firstCall.args[0]).to.equal('Table cleanup failed: OmniUiCardConfig');
413413
});
414414
});
@@ -466,7 +466,7 @@ describe('OmniStudioMetadataCleanupService', () => {
466466
queryIdsStub.onCall(1).resolves([]);
467467
queryIdsStub.onCall(2).resolves([]);
468468
queryIdsStub.onCall(3).resolves([]);
469-
deleteStub.resolves(true);
469+
deleteStub.resolves({ success: true });
470470
(messages.getMessage as sinon.SinonStub)
471471
.withArgs('metadataCleanupCompleted', ['1000'])
472472
.returns('The Omnistudio metadata table cleanup process is complete. Total records cleaned: 1000');
@@ -497,13 +497,13 @@ describe('OmniStudioMetadataCleanupService', () => {
497497
.resolves(['id4', 'id5', 'id6']); // OmniDataTransformConfig - 3 records
498498
deleteStub
499499
.onFirstCall()
500-
.resolves(true) // OmniUiCardConfig deletion successful
500+
.resolves({ success: true }) // OmniUiCardConfig deletion successful
501501
.onSecondCall()
502-
.resolves(true) // OmniScriptConfig deletion successful
502+
.resolves({ success: true }) // OmniScriptConfig deletion successful
503503
.onCall(2)
504-
.resolves(false) // OmniDataTransformConfig deletion fails
504+
.resolves({ success: false, statusCode: 'SOME_ERROR' }) // OmniDataTransformConfig deletion fails
505505
.onCall(3)
506-
.resolves(true); // This shouldn't be called
506+
.resolves({ success: true }); // This shouldn't be called
507507
(messages.getMessage as sinon.SinonStub)
508508
.withArgs('failedToCleanTables', ['OmniDataTransformConfig'])
509509
.returns('Table cleanup failed: OmniDataTransformConfig');
@@ -515,7 +515,7 @@ describe('OmniStudioMetadataCleanupService', () => {
515515
expect(result).to.be.false;
516516
expect(queryIdsStub.callCount).to.equal(4);
517517
expect(deleteStub.callCount).to.equal(3); // Only called for tables with records
518-
expect(loggerErrorStub.calledOnce).to.be.true;
518+
expect(loggerErrorStub.callCount).to.equal(1);
519519
expect(loggerErrorStub.firstCall.args[0]).to.equal('Table cleanup failed: OmniDataTransformConfig');
520520
});
521521
});

0 commit comments

Comments
 (0)