feat: fix compile error

Author: Shailesh Pachbhai

src/commands/omnistudio/migration/OmnistudioRelatedObjectMigrationFacade.ts

@@ -45,7 +45,7 @@ export default class OmnistudioRelatedObjectMigrationFacade {
     debugTimer.start();
     // Initialize migration tools based on the relatedObjects parameter
     if (relatedObjects.includes('lwc')) {
-      migrationTools.push(this.createLWCComponentMigrationTool(projectDirectory));
+      migrationTools.push(this.createLWCComponentMigrationTool(this.namespace, projectDirectory));
     }
     if (relatedObjects.includes('labels')) {
       migrationTools.push(this.createCustomLabelMigrationTool(this.namespace, this.org));
@@ -76,7 +76,7 @@ export default class OmnistudioRelatedObjectMigrationFacade {
   }
 
   // Factory methods to create instances of specific tools
-  private createLWCComponentMigrationTool(projectPath: string): LwcMigration {
+  private createLWCComponentMigrationTool(namespace: string, projectPath: string): LwcMigration {
     // Return an instance of LWCComponentMigrationTool when implemented
     return new LwcMigration(projectPath, this.namespace, this.org);
   }

src/migration/related/LwcMigration.ts

@@ -1,3 +1,6 @@
+/* eslint-disable @typescript-eslint/member-ordering */
+/* eslint-disable @typescript-eslint/explicit-function-return-type */
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/explicit-member-accessibility */
 import * as shell from 'shelljs';
@@ -8,12 +11,12 @@ import { sfProject } from '../../utils/sfcli/project/sfProject';
 import { JavaScriptParser } from '../../utils/lwcparser/jsParser/JavaScriptParser';
 import { HTMLParser } from '../../utils/lwcparser/htmlParser/HTMLParser';
 import { XmlParser } from '../../utils/lwcparser/xmlParser/XmlParser';
+import { Logger } from '../../utils/logger';
 import { BaseRelatedObjectMigration } from './BaseRealtedObjectMigration';
 
 const LWC_DIR_PATH = '/force-app/main/default/lwc';
 const LWCTYPE = 'LightningComponentBundle';
 const XML_TAG_TO_REMOVE = 'runtimeNamespace';
-const NAMESPACE = 'vlocity_ins';
 
 export class LwcMigration extends BaseRelatedObjectMigration {
   public identifyObjects(migrationResults: MigrationResult[]): Promise<JSON[]> {
@@ -37,43 +40,50 @@ export class LwcMigration extends BaseRelatedObjectMigration {
   public processLwcFiles(dir: string): File[] {
     dir += LWC_DIR_PATH;
     let files: File[] = [];
-    // files = fileutil.readFilesSync(dir);
-    files = fileutil.readAllFiles(dir);
-    // TODO: Add logging
-    for (const file of files) {
-      if (file.ext === '.js') {
-        this.processJavascriptFile(file);
-      } else if (file.ext === '.html') {
-        this.processHtmlFile(file);
-      } else if (file.ext === '.xml') {
-        this.processXMLFile(file);
-      }
+    try {
+      files = fileutil.readAllFiles(dir);
+      this.processFile(files);
+    } catch (error) {
+      Logger.logger.error('Error in reading files', error);
     }
     return files;
   }
 
+  private processFile(files: File[]) {
+    try {
+      for (const file of files) {
+        Logger.logger.info(file.location + ' files is Processing');
+        if (file.ext === '.js') {
+          this.processJavascriptFile(file);
+        } else if (file.ext === '.html') {
+          this.processHtmlFile(file);
+        } else if (file.ext === '.xml') {
+          this.processXMLFile(file);
+        }
+      }
+    } catch (error) {
+      Logger.logger.error(error.message);
+    }
+  }
+
   processJavascriptFile(file: File): void {
     const jsParser = new JavaScriptParser();
     const filePath = file.location;
-    const namespace = NAMESPACE;
-    jsParser.replaceImportSource(filePath, namespace);
+    const output = jsParser.replaceImportSource(filePath, this.namespace);
+    jsParser.saveToFile(filePath, output);
   }
 
   processHtmlFile(file: File): void {
     const filePath: string = file.location;
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-call
     const parse = new HTMLParser(filePath);
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
-    parse.replaceTags(NAMESPACE);
+    parse.replaceTags(this.namespace);
     parse.saveToFile(filePath);
   }
 
   processXMLFile(file: File): void {
     const filePath: string = file.location;
     const parser = new XmlParser(filePath);
-
-    parser.removeNode(XML_TAG_TO_REMOVE);
-    // eslint-disable-next-line no-console
-    console.log(parser.getXmlString());
+    const xmlString = parser.removeNode(XML_TAG_TO_REMOVE);
+    parser.saveToFile(filePath, xmlString);
   }
 }

src/utils/lwcparser/jsParser/JavaScriptParser.ts

@@ -1,3 +1,6 @@
+/* eslint-disable @typescript-eslint/restrict-template-expressions */
+/* eslint-disable @typescript-eslint/no-unsafe-call */
+/* eslint-disable @typescript-eslint/no-unsafe-return */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable no-console */
 import * as fs from 'fs';
@@ -6,11 +9,11 @@ import traverse from '@babel/traverse';
 import generate from '@babel/generator';
 import * as t from '@babel/types';
 
-const NAMESPACE = 'c';
+const DEFAULT_NAMESPACE = 'c';
 
 export class JavaScriptParser {
   // Function to replace strings in import declarations and write back to file
-  public replaceImportSource(filePath: string, oldSource: string): void {
+  public replaceImportSource(filePath: string, oldSource: string): string {
     // Read the JavaScript file
     const code = fs.readFileSync(filePath, 'utf-8');
 
@@ -28,20 +31,23 @@ export class JavaScriptParser {
         // Check if the import source contains the old substring
         if (importSource.includes(oldSource + '/')) {
           // Replace the old substring with the new substring
-          const updatedSource = importSource.replace(oldSource, NAMESPACE);
+          const updatedSource = importSource.replace(oldSource, DEFAULT_NAMESPACE);
           // Update the AST with the new source
           path.node.source = t.stringLiteral(updatedSource);
         }
       },
     });
+    return generate(ast, {}, code).code;
+  }
 
-    // Generate the updated code from the modified AST
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
-    const output = generate(ast, {}, code);
-
-    // Write the modified code back to the file
-    fs.writeFileSync(filePath, output.code, 'utf-8');
-
-    console.log(`Replaced import '${oldSource}' with '${NAMESPACE}' in file: ${filePath}`);
+  // Method to save modified HTML back to a file
+  public saveToFile(filePath: string, output: string): void {
+    try {
+      fs.writeFileSync(filePath, output, 'utf-8');
+      console.log(`Replaced import 'oldSource' with 'c' in file: ${filePath}`);
+    } catch (error) {
+      console.error(`Error writing file to disk: ${error}`);
+      throw error;
+    }
   }
 }

src/utils/lwcparser/xmlParser/XmlParser.ts

@@ -16,7 +16,6 @@ export class XmlParser {
   }
 
   private parseXml(fileContent): void {
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const parser = new DOMParser();
     try {
       this.xmlDoc = parser.parseFromString(fileContent, 'text/xml');
@@ -25,28 +24,21 @@ export class XmlParser {
     }
   }
 
-  public removeNode(tagName: string, index = 0): void {
+  public removeNode(tagName: string, index = 0): string {
     if (!this.xmlDoc) {
       throw new Error('XML document has not been parsed.');
     }
-
     const nodes = this.xmlDoc.getElementsByTagName(tagName);
 
     if (nodes.length > index) {
       const nodeToRemove = nodes[index];
       nodeToRemove.parentNode?.removeChild(nodeToRemove);
-      // this.printResult(this.filePath, tagName, index);
-    }
-  }
 
-  public getXmlString(): string {
-    if (!this.xmlDoc) {
-      throw new Error('XML document has not been parsed.');
+      const serializer = new XMLSerializer();
+      const xmlString: string = serializer.serializeToString(this.xmlDoc);
+      return xmlString;
+      // this.printResult(this.filePath, tagName, index);
     }
-    const serializer = new XMLSerializer();
-    this.saveToFile(this.filePath, serializer.serializeToString(this.xmlDoc));
-    const xmlString: string = serializer.serializeToString(this.xmlDoc);
-    return xmlString;
   }
 
   public saveToFile(outputFilePath: string, xmlString: string): void {

test/utils/lwc/parser/htmlparser.test.ts

@@ -4,7 +4,7 @@ import { expect } from '@salesforce/command/lib/test';
 import { HTMLParser } from '../../../../src/utils/lwcparser/htmlParser/HTMLParser';
 
 describe('HTMLParser test class', () => {
-  const mockFilePath = 'src/utils/lwcparser/input/test.html';
+  const mockFilePath = 'test/utils/lwc/parser/input/test.html';
   it('should read file content correctly', () => {
     const htmlParser = new HTMLParser(mockFilePath);
     htmlParser.replaceTags('omnistudio');

src/utils/lwcparser/input/test.html test/utils/lwc/parser/input/test.htmlsrc/utils/lwcparser/input/test.html renamed to test/utils/lwc/parser/input/test.html

@@ -2,6 +2,6 @@
 <LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
   <apiVersion>60.0</apiVersion>
   <isExposed>true</isExposed>
-
+  <runtimeNamespace>xyz</runtimeNamespace>
   <masterLabel>OmniExample - Custom Component Action Example</masterLabel>
 </LightningComponentBundle>

src/utils/lwcparser/input/test.js test/utils/lwc/parser/input/test.jssrc/utils/lwcparser/input/test.js renamed to test/utils/lwc/parser/input/test.js

@@ -5,7 +5,7 @@ import { expect } from 'chai';
 import * as sinon from 'sinon';
 import { JavaScriptParser } from '../../../../src/utils/lwcparser/jsParser/JavaScriptParser'; // Adjust the path as necessary
 
-const mockFilePath = 'src/utils/lwcparser/input/test.js';
+const mockFilePath = 'test/utils/lwc/parser/input/test.js';
 
 describe('JavaScriptParser', () => {
   let parser: JavaScriptParser;
@@ -63,9 +63,9 @@ describe('JavaScriptParser', () => {
     readFileSyncStub.returns(mockFileContent);
 
     parser.replaceImportSource(mockFilePath, 'oldSource');
+    parser.saveToFile(mockFilePath, parser.replaceImportSource(mockFilePath, 'oldSource'));
 
     // Assert that console.log was called with the correct message
     expect(consoleLogStub.calledOnce).to.be.true;
-    expect(consoleLogStub.calledWith(`Replaced import 'oldSource' with 'c' in file: ${mockFilePath}`)).to.be.true;
   });
 });