fix: added comments

Author: snehaljha-sf

messages/assess.json

@@ -33,8 +33,7 @@
   "invalidNamespace": "The namespace you have passed is not valid namespace, the valid namespace of your org is ",
   "noPackageInstalled": "No package installed on given org.",
   "alreadyStandardModel": "The org is already on standard data model.",
-  "invalidRelatedObjectsOptionGA": "Invalid option provided for -r: %s. Valid options are apex, lwc, expsites, flexipage.",
-  "invalidRelatedObjectsOption": "Invalid option provided for -r: %s. Valid option is apex.",
+  "invalidRelatedObjectsOption": "Invalid option provided for -r: %s. Valid options are apex, lwc, expsites, flexipage.",
   "formulaSyntaxError": "There was some problem while updating the formula syntax, please check the all the formula's syntax once : %s",
   "errorDuringFlexCardAssessment": "Error during FlexCard assessment",
   "errorDuringOmniScriptAssessment": "Error during OmniScript assessment",

messages/migrate.json

@@ -34,8 +34,7 @@
   "invalidNamespace": "The namespace you have passed is not valid namespace, the valid namespace of your org is ",
   "noPackageInstalled": "No package installed on given org.",
   "alreadyStandardModel": "The org is already on standard data model.",
-  "invalidRelatedObjectsOptionGA": "Invalid option provided for -r: %s. Valid options are apex, lwc, expsites, flexipage.",
-  "invalidRelatedObjectsOption": "Invalid option provided for -r: %s. Valid option is apex.",
+  "invalidRelatedObjectsOption": "Invalid option provided for -r: %s. Valid options are apex, lwc, expsites, flexipage.",
   "userConsentMessage": "By proceeding further, you hereby consent to the use, accept changes to your custom code and the accompanying terms and conditions associated with the use of the OmniStudio Migration Tool. Do you want to proceed? [y/n]",
   "userDeclinedConsent": "User declined consent, will not process %s .",
   "userConsentedToProceed": "User consented to proceed",

src/commands/omnistudio/migration/assess.ts

@@ -76,7 +76,7 @@ export default class Assess extends OmniStudioBaseCommand {
     const apiVersion = conn.getApiVersion();
     const orgs: OmnistudioOrgDetails = await OrgUtils.getOrgDetails(conn);
 
-    if (!orgs.hasValidNamespace && this.flags.namespace) {
+    if (!orgs.hasValidNamespace) {
       Logger.warn(messages.getMessage('invalidNamespace') + orgs.packageDetails.namespace);
     }
 
@@ -146,7 +146,7 @@ export default class Assess extends OmniStudioBaseCommand {
       // Validate input
       for (const obj of objectsToProcess) {
         if (!validOptions.includes(obj)) {
-          Logger.error(messages.getMessage('invalidRelatedObjectsOptionGA', [String(obj)]));
+          Logger.error(messages.getMessage('invalidRelatedObjectsOption', [String(obj)]));
           process.exit(1);
         }
       }

src/commands/omnistudio/migration/migrate.ts

@@ -79,7 +79,6 @@ export default class Migrate extends OmniStudioBaseCommand {
   }
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  // eslint-disable-next-line complexity
   public async runMigration(): Promise<any> {
     const migrateOnly = (this.flags.only || '') as string;
     const allVersions = this.flags.allversions || (false as boolean);
@@ -266,7 +265,7 @@ export default class Migrate extends OmniStudioBaseCommand {
     // Validate input
     for (const obj of objectsToProcess) {
       if (!validOptions.includes(obj)) {
-        Logger.error(messages.getMessage('invalidRelatedObjectsOptionGA', [obj]));
+        Logger.error(messages.getMessage('invalidRelatedObjectsOption', [obj]));
         process.exit(1);
       }
     }

src/migration/omniscript.ts

@@ -206,8 +206,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
     flexCardAssessmentInfos: FlexCardAssessmentInfo[]
   ): Promise<OmniAssessmentInfo> {
     try {
-      const exportComponentType =
-        this.exportType === OmniScriptExportType.IP ? 'Integration Procedures' : 'Omniscripts';
+      const exportComponentType = this.getName() as ComponentType;
       Logger.log(this.messages.getMessage('startingOmniScriptAssessment', [exportComponentType]));
       const omniscripts = await this.getAllOmniScripts();
       Logger.log(this.messages.getMessage('foundOmniScriptsToAssess', [omniscripts.length, exportComponentType]));
@@ -242,8 +241,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
     const existingDataRaptorNames = new Set(dataRaptorAssessmentInfos.map((info) => info.name));
     const existingFlexCardNames = new Set(flexCardAssessmentInfos.map((info) => info.name));
 
-    const progressBarType: ComponentType =
-      this.exportType === OmniScriptExportType.IP ? 'Integration Procedures' : 'Omniscripts';
+    const progressBarType: ComponentType = this.getName() as ComponentType;
     const progressBar = createProgressBar('Assessing', progressBarType);
     let progressCounter = 0;
     progressBar.start(omniscripts.length, progressCounter);
@@ -304,9 +302,6 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
       }
       if (omniAssessmentInfo.type === 'OmniScript') {
         const type = omniscript[this.namespacePrefix + 'IsLwcEnabled__c'] ? 'LWC' : 'Angular';
-        if (type === 'Angular') {
-          omniAssessmentInfo.warnings.unshift(this.messages.getMessage('angularOSWarning'));
-        }
         const osAssessmentInfo: OSAssessmentInfo = {
           name: omniAssessmentInfo.name,
           type: type,
@@ -664,7 +659,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
     // Variables to be returned After Migration
     let originalOsRecords = new Map<string, any>();
     let osUploadInfo = new Map<string, UploadRecordResult>();
-    const exportComponentType = this.exportType === OmniScriptExportType.IP ? 'Integration Procedures' : 'Omniscripts';
+    const exportComponentType = this.getName() as ComponentType;
     Logger.log(this.messages.getMessage('foundOmniScriptsToMigrate', [omniscripts.length, exportComponentType]));
     const progressBarType: ComponentType = exportComponentType;
     const progressBar = createProgressBar('Migrating', progressBarType);