Fix: remove cleanning of global auto number (#349)

Author: rajender-kumar-salesforce

messages/assess.json

@@ -102,7 +102,6 @@
   "integrationProcedureNameChangeMessage": "Integration Procedure reference %s will be changed to %s during migration.",
   "integrationProcedureManualUpdateMessage": "Integration Procedure reference %s may need manual updates after migration.",
   "duplicateCardNameMessage": "Potential duplicate: Another card has the same name %s after name cleaning. This may cause conflicts during migration",
-  "globalAutoNumberNameChangeMessage": "GlobalAutoNumber name will be changed from %s to %s to follow API naming standards",
   "duplicateGlobalAutoNumberNameMessage": "Potential duplicate: Another Global Auto Number has the same name %s after name cleaning. This may cause conflicts during migration",
   "existingApexPrompt": "Do you have a sfdc project that already contains the APEX classes retrieved from your org? [y/n]",
   "enterExistingProjectPath": "Enter the path to the project folder that contains the retrieved APEX classes:",

messages/migrate.json

@@ -144,7 +144,6 @@
   "startingPostMigrationCleanup": "Starting post-migration cleanup for Global Auto Number...",
   "postMigrationCleanupCompleted": "Post-migration cleanup completed successfully.",
   "errorDuringPostMigrationCleanup": "We’ve encountered an error during the post-migration cleanup. Try again later.",
-  "globalAutoNumberNameChangeMessage": "Global Auto Number name has been modified to fit naming rules: %s",
   "duplicatedGlobalAutoNumberName": "Duplicated Global Auto Number name",
   "errorWhileUploadingGlobalAutoNumber": "An error occurred while uploading Global Auto Number: ",
   "startingGlobalAutoNumberAssessment": "Starting Global Auto Number assessment...",

src/migration/globalautonumber.ts

@@ -238,16 +238,8 @@ export class GlobalAutoNumberMigrationTool extends BaseMigrationTool implements
           if (!uploadResult.success) {
             uploadResult.errors = Array.isArray(uploadResult.errors) ? uploadResult.errors : [uploadResult.errors];
           }
-
-          // Check for name changes
           uploadResult.warnings = uploadResult.warnings || [];
-          if (transformedName !== autonumber['Name']) {
-            uploadResult.newName = transformedName;
-            uploadResult.warnings.unshift(
-              this.messages.getMessage('globalAutoNumberNameChangeMessage', [transformedName])
-            );
-          }
-
+          uploadResult.newName = transformedName;
           globalAutoNumberUploadInfo.set(recordId, uploadResult);
         }
       } catch (err) {
@@ -333,23 +325,13 @@ export class GlobalAutoNumberMigrationTool extends BaseMigrationTool implements
       errors: [],
     };
 
-    // Check for name changes due to API naming requirements
-    const originalName: string = globalAutoNumberName;
-    const cleanedName: string = this.cleanName(originalName);
-    if (cleanedName !== originalName) {
-      globalAutoNumberAssessmentInfo.name = cleanedName;
-      globalAutoNumberAssessmentInfo.warnings.push(
-        this.messages.getMessage('globalAutoNumberNameChangeMessage', [originalName, cleanedName])
-      );
-    }
-
     // Check for duplicate names
-    if (uniqueNames.has(cleanedName)) {
+    if (uniqueNames.has(globalAutoNumberName)) {
       globalAutoNumberAssessmentInfo.errors.push(
-        this.messages.getMessage('duplicateGlobalAutoNumberNameMessage', [cleanedName])
+        this.messages.getMessage('duplicateGlobalAutoNumberNameMessage', [globalAutoNumberName])
       );
     }
-    uniqueNames.add(cleanedName);
+    uniqueNames.add(globalAutoNumberName);
     return globalAutoNumberAssessmentInfo;
   }
 
@@ -378,9 +360,6 @@ export class GlobalAutoNumberMigrationTool extends BaseMigrationTool implements
       }
     });
 
-    // Set essential default values (following same pattern as other entities)
-    mappedObject['Name'] = this.cleanName(mappedObject['Name']);
-
     // BATCH framework requires that each record has an "attributes" property
     mappedObject['attributes'] = {
       type: GlobalAutoNumberMigrationTool.OMNI_GLOBAL_AUTO_NUMBER_NAME,

src/utils/constants/documentRegistry.ts

@@ -52,12 +52,10 @@ export const documentRegistry = {
   dataRaptorNameChangeMessage:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_dataraptors_from_apex_after_migration.htm&type=5',
   integrationProcedureNameChangeMessage:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_integration_procedures_after_migration.htm&type=5',
+    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_dataraptors_from_apex_after_migration.htm&type=5',
   integrationProcedureManualUpdateMessage:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_integration_procedures_after_migration.htm&type=5',
+    'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_update_references_to_dataraptors_from_apex_after_migration.htm&type=5',
   duplicateCardNameMessage: 'https://help.salesforce.com/s/articleView?id=xcloud.os_clone_a_flexcard.htm&type=5',
-  globalAutoNumberNameChangeMessage:
-    'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
   duplicateGlobalAutoNumberNameMessage:
     'https://help.salesforce.com/s/articleView?id=xcloud.os_omnistudio_naming_conventions.htm&type=5',
 };

test/migration/globalautonumber.test.ts

@@ -160,12 +160,12 @@ describe('GlobalAutoNumberMigrationTool', () => {
       expect(getMessageStub.called).to.be.true;
     });
 
-    it('should handle name changes in assessment', async () => {
+    it('should preserve names with special characters in assessment', async () => {
       // Arrange
       const mockGlobalAutoNumbers = [
         {
           Id: '001',
-          Name: 'Test-GAN-1', // Name with special characters
+          Name: 'Test-GAN-1', // Name with special characters should be preserved
           Increment__c: 1,
           LastGeneratedNumber__c: 100,
           LeftPadDigit__c: 5,
@@ -178,17 +178,15 @@ describe('GlobalAutoNumberMigrationTool', () => {
       sandbox.stub(QueryTools, 'queryAll').resolves(mockGlobalAutoNumbers);
       getMessageStub.withArgs('startingGlobalAutoNumberAssessment').returns('Starting assessment...');
       getMessageStub.withArgs('foundGlobalAutoNumbersToAssess', [1]).returns('Found 1 Global Auto Number');
-      getMessageStub
-        .withArgs('globalAutoNumberNameChangeMessage', ['Test-GAN-1', 'TestGAN1'])
-        .returns('Name will be changed');
-      // No migration info message expected since it was removed
 
       // Act
       const result = await globalAutoNumberMigrationTool.assess();
 
       // Assert
       expect(result).to.be.an('array').with.length(1);
-      expect(result[0].warnings).to.include('Name will be changed');
+      expect(result[0].name).to.equal('Test-GAN-1'); // Name should be preserved
+      expect(result[0].oldName).to.equal('Test-GAN-1');
+      expect(result[0].warnings).to.be.empty; // No warnings since no name changes
     });
 
     it('should handle errors during assessment', async () => {
@@ -416,9 +414,6 @@ describe('GlobalAutoNumberMigrationTool', () => {
       sandbox.stub(QueryTools, 'queryAll').resolves(mockGlobalAutoNumbers);
       getMessageStub.withArgs('startingGlobalAutoNumberAssessment').returns('Starting assessment...');
       getMessageStub.withArgs('foundGlobalAutoNumbersToAssess', [1]).returns('Found 1 Global Auto Number');
-      getMessageStub
-        .withArgs('globalAutoNumberNameChangeMessage', ['TestGAN1', 'TestGAN1'])
-        .returns('Name will be changed');
       getMessageStub.withArgs('unexpectedError').returns('Unexpected error');
 
       // Act
@@ -487,7 +482,7 @@ describe('GlobalAutoNumberMigrationTool', () => {
       // The method removes everything after the first __, so Increment__c becomes 'c'
       // This causes fields to not be mapped properly
       expect(result).to.deep.include({
-        Name: 'TestGAN1', // Cleaned name
+        Name: 'Test-GAN-1', // Name should be preserved with special characters
         attributes: {
           type: 'OmniGlobalAutoNumber',
           referenceId: '001',

test/utils/constants/documentRegistry.test.ts

@@ -36,8 +36,8 @@ const titles = {
   omniScriptNameChangeMessage:
     'Update Omniscript Custom Lightning Web Components and Omniscript Elements Overridden with Customized Components',
   dataRaptorNameChangeMessage: 'Update References to Omnistudio Components After Migration',
-  integrationProcedureNameChangeMessage: 'Update Integration Procedure Type and Subtype After Migration',
-  integrationProcedureManualUpdateMessage: 'Update Integration Procedure Type and Subtype After Migration',
+  integrationProcedureNameChangeMessage: 'Update References to Omnistudio Components After Migration',
+  integrationProcedureManualUpdateMessage: 'Update References to Omnistudio Components After Migration',
   duplicateCardNameMessage: 'Clone a Flexcard',
 };