chore: upgrading salesforce/core to latest

Author: sf-pallavi-das

package.json

@@ -6,12 +6,15 @@
   "bugs": "https://github.com/forcedotcom/cli/issues",
   "dependencies": {
     "@apexdevtools/apex-parser": "^4.1.0",
+    "@babel/parser": "^7.25.6",
+    "@babel/traverse": "^7.25.6",
     "@babel/types": "^7.25.6",
     "@oclif/command": "^1",
     "@oclif/config": "^1",
     "@oclif/errors": "^1",
-    "@salesforce/command": "^4.2.1",
-    "@salesforce/core": "^2.37.1",
+    "@salesforce/command": "^5.3.9",
+    "@salesforce/core": "^8.23.4",
+    "@salesforce/sf-plugins-core": "^12.1.0",
     "@types/jsdom": "^21.1.7",
     "@types/lodash.chunk": "^4.2.9",
     "@types/shelljs": "^0.8.15",
@@ -22,9 +25,7 @@
     "lodash.chunk": "^4.2.0",
     "open": "^8.4.2",
     "shelljs": "^0.8.5",
-    "tslib": "^2",
-    "@babel/parser": "^7.25.6",
-    "@babel/traverse": "^7.25.6"
+    "tslib": "^2"
   },
   "devDependencies": {
     "@oclif/dev-cli": "^1",
@@ -37,7 +38,7 @@
     "@salesforce/prettier-config": "^0.0.3",
     "@salesforce/ts-sinon": "^1",
     "@types/babel__traverse": "^7.20.6",
-    "@types/jsforce": "^1.11.5",
+    "@types/jsforce": "^1.11.6",
     "@types/xmldom": "^0.1.34",
     "@typescript-eslint/eslint-plugin": "^4.2.0",
     "@typescript-eslint/parser": "^4.2.0",
@@ -65,6 +66,7 @@
     "typescript": "^4.9.5"
   },
   "resolutions": {
+    "@salesforce/core": "^8.23.4",
     "nanoid": "^3.3.8",
     "marked": "^4.0.10",
     "semver": "^7.5.2",
@@ -130,18 +132,18 @@
   },
   "repository": "salesforcecli/plugin-omnistudio-migration-tool",
   "scripts": {
-    "build": "sf-build && yarn copy-assets",
+    "build": "sf-build",
     "clean": "sf-clean",
     "clean-all": "sf-clean all",
     "clean:lib": "shx rm -rf lib && shx rm -rf coverage && shx rm -rf .nyc_output && shx rm -f oclif.manifest.json",
-    "compile": "sf-compile && yarn copy-assets",
+    "compile": "sf-compile",
     "copy-assets": "shx cp -r src/templates lib/ && shx cp -r src/styles lib/ && shx cp -r src/javascripts lib/",
     "docs": "sf-docs",
     "format": "sf-format",
     "lint": "sf-lint",
     "postpack": "shx rm -f oclif.manifest.json",
     "posttest": "yarn lint && yarn test:deprecation-policy && yarn test:command-reference",
-    "prepack": "sf-prepack && yarn copy-assets",
+    "prepack": "sf-prepack",
     "prepare": "sf-install",
     "pretest": "sf-compile-test",
     "test": "sf-test",

src/commands/omnistudio/migration/info.ts

@@ -6,7 +6,7 @@
  */
 import * as os from 'os';
 import { flags, SfdxCommand } from '@salesforce/command';
-import { Messages, SfdxError } from '@salesforce/core';
+import { Messages, SfError } from '@salesforce/core';
 import { AnyJson } from '@salesforce/ts-types';
 import { Logger } from '../../../utils/logger';
 
@@ -80,7 +80,7 @@ export default class Org extends SfdxCommand {
     // Organization will always return one result, but this is an example of throwing an error
     // The output and --json will automatically be handled for you.
     if (!result.records || result.records.length <= 0) {
-      throw new SfdxError(messages.getMessage('errorNoOrgResults', [this.org.getOrgId()]));
+      throw new SfError(messages.getMessage('errorNoOrgResults', [this.org.getOrgId()]));
     }
 
     // Organization always only returns one result

src/migration/base.ts

@@ -46,11 +46,11 @@ export class BaseMigrationTool {
   protected readonly connection: Connection;
   protected readonly namespacePrefix: string;
   protected readonly logger: Logger;
-  protected readonly messages: Messages;
+  protected readonly messages: Messages<string>;
   protected readonly ux: UX;
   protected readonly nameRegistry: NameMappingRegistry;
 
-  public constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages, ux: UX) {
+  public constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages<string>, ux: UX) {
     this.namespace = namespace;
     this.connection = connection;
     this.logger = logger;

src/migration/customLabels.ts

@@ -59,7 +59,7 @@ export interface CustomLabelRecord {
 }
 
 export class CustomLabelsMigrationTool extends BaseMigrationTool implements MigrationTool {
-  public constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages, ux: UX) {
+  public constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages<string>, ux: UX) {
     super(namespace, connection, logger, messages, ux);
   }
 

src/migration/deployer.ts

@@ -12,11 +12,11 @@ export class Deployer {
   private readonly omniscriptCustomizationPackage = '@omnistudio/omniscript_customization';
   private readonly omniscriptCustomizationPackageVersion = '250.0.0';
   private readonly username: string;
-  private readonly messages: Messages;
+  private readonly messages: Messages<string>;
   private readonly omniscriptPackageConfig: OmniscriptPackageConfig;
   private omniscriptPackageManager?: OmniscriptPackageManager;
 
-  public constructor(projectPath: string, messages: Messages, username: string, authKey: string) {
+  public constructor(projectPath: string, messages: Messages<string>, username: string, authKey: string) {
     this.projectPath = projectPath;
     this.username = username;
     this.messages = messages;

src/migration/flexcard.ts

@@ -36,7 +36,7 @@ export class CardMigrationTool extends BaseMigrationTool implements MigrationToo
     namespace: string,
     connection: Connection,
     logger: Logger,
-    messages: Messages,
+    messages: Messages<string>,
     ux: UX,
     allVersions: boolean
   ) {

src/migration/globalautonumber.ts

@@ -19,7 +19,7 @@ export class GlobalAutoNumberMigrationTool extends BaseMigrationTool implements
   private prefManager: OmnistudioSettingsPrefManager;
   private globalAutoNumberSettings: AnyJson[] | null = null;
 
-  constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages, ux: UX) {
+  constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages<string>, ux: UX) {
     super(namespace, connection, logger, messages, ux);
     this.prefManager = new OmnistudioSettingsPrefManager(this.connection, this.messages);
   }

src/migration/omniscript.ts

@@ -71,7 +71,7 @@ export class OmniScriptMigrationTool extends BaseMigrationTool implements Migrat
     namespace: string,
     connection: Connection,
     logger: Logger,
-    messages: Messages,
+    messages: Messages<string>,
     ux: UX,
     allVersions: boolean
   ) {

src/migration/postMigrate.ts

@@ -2,7 +2,7 @@
 
 import { Connection, Messages, Org } from '@salesforce/core';
 import { UX } from '@salesforce/command';
-import { ExecuteAnonymousResult } from 'jsforce';
+import type { ExecuteAnonymousResult } from '@jsforce/jsforce-node/lib/api/tooling';
 import { Logger } from '../utils/logger';
 import { AnonymousApexRunner } from '../utils/apex/executor/AnonymousApexRunner';
 import { Constants } from '../utils/constants/stringContants';
@@ -30,7 +30,7 @@ export class PostMigrate extends BaseMigrationTool {
     namespace: string,
     connection: Connection,
     logger: Logger,
-    messages: Messages,
+    messages: Messages<string>,
     ux: UX,
     relatedObjectsToProcess: string[],
     deploymentConfig?: { autoDeploy: boolean; authKey: string | undefined },

src/migration/premigrate.ts

@@ -13,7 +13,7 @@ const authEnvKey = 'OMA_AUTH_KEY';
 
 export class PreMigrate extends BaseMigrationTool {
   // Source Custom Object Names
-  public constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages, ux: UX) {
+  public constructor(namespace: string, connection: Connection, logger: Logger, messages: Messages<string>, ux: UX) {
     super(namespace, connection, logger, messages, ux);
   }