Skip to content

Commit ea4ecdc

Browse files
authored
Merge pull request #325 from shaurabh-tiwari-git/mvpP1issuesfix
@W-18480490 Mvp P1 Issues Fix
2 parents 788e3b6 + 075525e commit ea4ecdc

File tree

4 files changed

+29
-10
lines changed

4 files changed

+29
-10
lines changed

src/commands/omnistudio/migration/migrate.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,6 @@ export default class Migrate extends OmniStudioBaseCommand {
164164
objectMigrationResults = await this.migrateObjects(migrationObjects, debugTimer);
165165
}
166166

167-
// Stop the debug timer
168-
const timer = DebugTimer.getInstance().stop();
169-
170167
const omnistudioRelatedObjectsMigration = new OmnistudioRelatedObjectMigrationFacade(
171168
namespace,
172169
migrateOnly,
@@ -193,9 +190,6 @@ export default class Migrate extends OmniStudioBaseCommand {
193190
actionItems
194191
);
195192

196-
// save timer to debug logger
197-
Logger.logVerbose(timer.toString());
198-
199193
// Return results needed for --json flag
200194
return { objectMigrationResults };
201195
}

src/templates/assessmentReport.template

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,12 @@
185185
<c:if exp={Array.isArray($cell.title)}>
186186
<ul>
187187
<c:for items=(cell.title) var="value">
188-
<li><a href="(cell.uri)">{{value}}</a></li>
188+
<li><a href="(cell.uri)" target="_blank">{{value}}</a></li>
189189
</c:for>
190190
</ul>
191191
</c:if>
192192
<c:if exp={!Array.isArray($cell.title)}>
193-
<a href="(cell.uri)">{{cell.title}}</a>
193+
<a href="(cell.uri)" target="_blank">{{cell.title}}</a>
194194
</c:if>
195195
</td>
196196
</c:if>

src/utils/resultsbuilder/ApexAssessmentReporter.ts

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,27 @@ export class ApexAssessmentReporter {
5555
rowId: `${this.rowIdPrefix}${this.rowId++}`,
5656
data: [
5757
createRowDataParam('name', apexAssessmentInfo.name, true, 1, 1, false),
58-
createRowDataParam('fileReference', apexAssessmentInfo.path, false, 1, 1, false),
58+
createRowDataParam(
59+
'fileReference',
60+
apexAssessmentInfo.name,
61+
false,
62+
1,
63+
1,
64+
true,
65+
apexAssessmentInfo.path,
66+
apexAssessmentInfo.name + '.cls'
67+
),
68+
createRowDataParam(
69+
'status',
70+
apexAssessmentInfo.warnings.length > 0 ? 'Has Warnings' : 'Can be Automated',
71+
false,
72+
1,
73+
1,
74+
false,
75+
undefined,
76+
undefined,
77+
apexAssessmentInfo.warnings.length > 0 ? 'text-error' : 'text-success'
78+
),
5979
createRowDataParam(
6080
'diff',
6181
apexAssessmentInfo.name + 'diff',
@@ -119,6 +139,11 @@ export class ApexAssessmentReporter {
119139
colspan: 1,
120140
rowspan: 1,
121141
},
142+
{
143+
name: 'Assessment Status',
144+
colspan: 1,
145+
rowspan: 2,
146+
},
122147
{
123148
name: 'Diff',
124149
colspan: 1,

src/utils/resultsbuilder/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ export class ResultsBuilder {
244244
rowId: `${this.rowClass}${this.rowId++}`,
245245
data: [
246246
createRowDataParam('name', item.name, true, 1, 1, false),
247-
createRowDataParam('path', item.path, false, 1, 1, false),
247+
createRowDataParam('path', item.name, false, 1, 1, true, item.path, item.name + '.cls'),
248248
createRowDataParam(
249249
'diff',
250250
item.name + 'diff',

0 commit comments

Comments
 (0)