Merge pull request #199 from salesforcecli:bm/W-9740004

chore: remove deprecation message

Author: mshanemc

messages/list.json

@@ -15,6 +15,5 @@
   "deleteOrgs": "You have %s expired or deleted local scratch org authorizations. To remove authorizations for inactive orgs, run force:org:list --clean.",
   "noOrgsFound": "No orgs can be found.",
   "noOrgsFoundAction": "Use one of the auth commands or force:org:create to add or create a scratch org.",
-  "scratchOrgRemoveConnectedStatusProperty": "Starting in API version 52, the JSON output of this command no longer returns the property connectedStatus for scratch orgs.",
   "noResultsFound": "No non-scratch orgs found."
 }

src/commands/force/org/list.ts

@@ -77,7 +77,6 @@ export class OrgListCommand extends SfdxCommand {
         ? groupedSortedOrgs.scratchOrgs
         : groupedSortedOrgs.scratchOrgs.filter(identifyActiveOrgByStatus),
     };
-    this.ux.warn(messages.getMessage('scratchOrgRemoveConnectedStatusProperty'));
     this.ux.styledHeader('Orgs');
 
     this.printOrgTable(result.nonScratchOrgs, this.flags.skipconnectionstatus);

src/shared/orgListUtil.ts

@@ -272,8 +272,6 @@ export class OrgListUtil {
         scratchOrgInfo.expirationDate = updatedOrgInfo.ExpirationDate;
         scratchOrgInfo.isExpired = updatedOrgInfo.Status === 'Deleted';
         scratchOrgInfo.namespace = updatedOrgInfo.Namespace;
-        // the old toolbelt code always said Unknown.  I'd love to get rid of it.
-        scratchOrgInfo.connectedStatus = 'Unknown';
       } else {
         const logger = await OrgListUtil.retrieveLogger();
         logger.warn(`Can't find ${scratchOrgInfo.username} in the updated contents`);

test/shared/orgListUtil.test.ts

@@ -176,8 +176,6 @@ describe('orgListUtil tests', () => {
       expect(retrieveScratchOrgInfoFromDevHubStub.calledOnce).to.be.true;
       expect(spies.get('reduceScratchOrgInfo').calledOnce).to.be.true;
       expect(orgGroups.scratchOrgs[0].signupUsername).to.equal(orgAuthConfigFields.username);
-      // current default on every scratch org, warning in v51, deprecation in v52
-      expect(orgGroups.scratchOrgs[0].connectedStatus).to.equal('Unknown');
       expect(orgGroups.scratchOrgs[0]).to.include.keys([
         'signupUsername',
         'createdBy',