fix: use Aliases.parseAndUpdate

Author: maggiben

src/commands/force/org/beta/create.ts

@@ -263,10 +263,8 @@ export class Create extends SfdxCommand {
 
   private async setAliasAndDefaultUsername(username: string): Promise<void> {
     if (this.flags.setalias) {
-      const alias = await Aliases.create(Aliases.getDefaultOptions());
-      alias.set(this.flags.setalias, username);
-      const result = await alias.write();
-      this.logger.debug('Set Alias: %s result: %s', this.flags.setalias, result);
+      await Aliases.parseAndUpdate([`${this.flags.setalias as string}=${username}`]);
+      this.logger.debug('Set Alias: %s result: %s', this.flags.setalias);
     }
     if (this.flags.setdefaultusername) {
       let config: Config;

test/commands/force/org/scratchOrgCreate.test.ts

@@ -184,7 +184,7 @@ describe('org:create', () => {
         '--type',
         'scratch',
         '--setalias',
-        'sandboxAlias',
+        'scratchOrgAlias',
         '--setdefaultusername',
         '--definitionfile',
         definitionfile,
@@ -198,7 +198,7 @@ describe('org:create', () => {
         ...CREATE_RESULT,
         username: 'newScratchUsername',
       });
-      const aliasStub = stubMethod(sandbox, Aliases.prototype, 'set');
+      const aliasStub = stubMethod(sandbox, Aliases, 'parseAndUpdate');
       const configStub = stubMethod(sandbox, Config.prototype, 'set');
       await command.runIt();
       expect(prodOrg.firstCall.args[0]).to.deep.equal({
@@ -216,7 +216,7 @@ describe('org:create', () => {
         retry: 0,
         orgConfig: {},
       });
-      expect(aliasStub.firstCall.args).to.deep.equal(['sandboxAlias', 'newScratchUsername']);
+      expect(aliasStub.firstCall.args).to.deep.equal([['scratchOrgAlias=newScratchUsername']]);
       expect(configStub.firstCall.args).to.deep.equal(['defaultusername', 'newScratchUsername']);
     });