test: expect nonZero exit code (#884)

Author: mdonnalley

package.json

@@ -14,7 +14,7 @@
   },
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^5.0.2",
-    "@salesforce/cli-plugins-testkit": "^5.0.5",
+    "@salesforce/cli-plugins-testkit": "^5.1.0",
     "@salesforce/dev-scripts": "^7.1.1",
     "@salesforce/plugin-command-reference": "^3.0.49",
     "@salesforce/ts-sinon": "1.4.19",

test/nut/scratchCreate.nut.ts

@@ -41,20 +41,20 @@ describe('env create scratch NUTs', () => {
 
   describe('flag failures', () => {
     it('non-existent config file', () => {
-      execCmd('env:create:scratch -f badfile.json', { ensureExitCode: 1 });
+      execCmd('env:create:scratch -f badfile.json', { ensureExitCode: 'nonZero' });
     });
     it('wait zero', () => {
-      execCmd('env:create:scratch -f config/project-scratch-def.json --wait 0', { ensureExitCode: 1 });
+      execCmd('env:create:scratch -f config/project-scratch-def.json --wait 0', { ensureExitCode: 'nonZero' });
     });
     it('no edition or config', () => {
-      execCmd('env:create:scratch', { ensureExitCode: 1 });
+      execCmd('env:create:scratch', { ensureExitCode: 'nonZero' });
     });
     it('days out of bounds', () => {
-      execCmd('env:create:scratch -f config/project-scratch-def.json -d 50', { ensureExitCode: 1 });
+      execCmd('env:create:scratch -f config/project-scratch-def.json -d 50', { ensureExitCode: 'nonZero' });
     });
     it('prompts for client secret if client id present and times out', () => {
       const error = execCmd('env:create:scratch --edition developer --client-id someConnectedApp', {
-        ensureExitCode: 1,
+        ensureExitCode: 'nonZero',
       }).shellOutput;
       expect(error.stdout).to.include(messages.getMessage('prompt.secret'));
       expect(error.stderr).to.include(`Timed out after ${secretTimeout} ms.`);

yarn.lock

@@ -962,12 +962,12 @@
   resolved "https://registry.yarnpkg.com/@pkgjs/parseargs/-/parseargs-0.11.0.tgz#a77ea742fab25775145434eb1d2328cf5013ac33"
   integrity sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg==
 
-"@salesforce/cli-plugins-testkit@^5.0.5":
-  version "5.0.5"
-  resolved "https://registry.yarnpkg.com/@salesforce/cli-plugins-testkit/-/cli-plugins-testkit-5.0.5.tgz#54a4ec57a10b10b3e3040cfb754972666a3ec100"
-  integrity sha512-TketFUfimWg7T0LJGaXtfelvp6Zy3i2sYwuULSBYiyPceqUTZJXPXNzbHC987b6E3OcT4K6mIxLiVbF//kzvMQ==
+"@salesforce/cli-plugins-testkit@^5.1.0":
+  version "5.1.0"
+  resolved "https://registry.yarnpkg.com/@salesforce/cli-plugins-testkit/-/cli-plugins-testkit-5.1.0.tgz#8d9caa22ea9e99879629206892afb26bcd540cef"
+  integrity sha512-P5tYlNqE87lX9Yp2aAsK75PICoAbmrSK3LEqiIVbtn75PN3OKiD1JEEX2ZDu+HWtO4/nxPtO4JFvX5j00EZGBA==
   dependencies:
-    "@salesforce/core" "^6.2.0"
+    "@salesforce/core" "^6.2.2"
     "@salesforce/kit" "^3.0.15"
     "@salesforce/ts-types" "^2.0.9"
     "@types/shelljs" "^0.8.15"
@@ -1001,7 +1001,7 @@
     semver "^7.5.4"
     ts-retry-promise "^0.7.1"
 
-"@salesforce/core@^6.1.3", "@salesforce/core@^6.2.0":
+"@salesforce/core@^6.1.3", "@salesforce/core@^6.2.0", "@salesforce/core@^6.2.2":
   version "6.2.2"
   resolved "https://registry.yarnpkg.com/@salesforce/core/-/core-6.2.2.tgz#c390c7c407e8916ad85a3e300d9d9e4fecfba207"
   integrity sha512-R2ptk/+KSWDJOqdInxfzPTLF3V//vFtD4vQcjWIK9NaGCCq4ZwiF2gMpkBcKgDQneLUmva2NcmnzF3c51zQp5A==