Merge pull request #668 from salesforcecli/sm/deprecate-force-org-create

feat: gentle deprecation warning for force:org:create

Author: mshanemc

messages/create.md

@@ -4,7 +4,7 @@ Create a scratch org or sandbox.
 
 # deprecation
 
-The force:org:create command is deprecated. Use org:create:scratch or org:create:sandbox.
+The force:org:create command has been replaced. Try org:create:scratch or org:create:sandbox.
 
 # description
 

src/commands/force/org/create.ts

@@ -54,11 +54,10 @@ export class Create extends SfCommand<CreateResult> {
   public static readonly description = messages.getMessage('description');
   public static readonly examples = messages.getMessages('examples');
 
-  // waiting for oclif bug fix around missing config.id.
-  // public static state = 'deprecated';
-  // public static deprecationOptions = {
-  //   message: messages.getMessage('deprecation'),
-  // };
+  public static state = 'deprecated';
+  public static deprecationOptions = {
+    message: messages.getMessage('deprecation'),
+  };
 
   // needed to allow varargs
   public static readonly strict = false;

test/unit/force/org/scratchOrgCreate.test.ts

@@ -289,12 +289,9 @@ describe('org:create', () => {
         warnings,
       });
       await runCreateCommand(['--type', 'scratch', '--definitionfile', definitionfile, '-v', testHub.username]);
-      expect(sfCommandUxStubs.warn.callCount).to.equal(2);
-      expect(sfCommandUxStubs.warn.callCount).to.equal(2);
-      expect(sfCommandUxStubs.warn.firstCall.firstArg).to.equal(warnings[0]);
-      expect(sfCommandUxStubs.warn.firstCall.firstArg).to.equal(warnings[0]);
-      expect(sfCommandUxStubs.warn.secondCall.firstArg).to.equal(warnings[1]);
-      expect(sfCommandUxStubs.warn.secondCall.firstArg).to.equal(warnings[1]);
+      expect(sfCommandUxStubs.warn.callCount).to.be.greaterThanOrEqual(2);
+      expect(sfCommandUxStubs.warn.getCalls().flatMap((c) => c.args)).to.have.include(warnings[0]);
+      expect(sfCommandUxStubs.warn.getCalls().flatMap((c) => c.args)).to.have.include(warnings[1]);
     });
   });