fix: remove default license type from sbox create so config file can specify it

Author: mshanemc

messages/clone.md

@@ -46,10 +46,6 @@ Sets the streaming client socket timeout, in minutes. If the streaming client so
 
 The sandbox org cloning process %s is in progress. Run "sfdx force:org:status -n %s" to check for status. If the org is ready, checking the status also logs the requesting user in to the sandbox org and authorizes the org for use with Salesforce CLI.
 
-# missingLicenseType
-
-The sandbox license type is required, but you didn't provide a value. Specify the license type in the sandbox definition file with the "licenseType" option, or specify the option as a name-value pair at the command-line. See https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_sandbox_definition.htm for more information.
-
 # commandOrganizationTypeNotSupport
 
 The only supported org type is: %s

messages/create.md

@@ -104,10 +104,6 @@ The sandbox org creation process %s is in progress. Run "sfdx force:org:status -
 
 This command requires a username. Specify it with the -u parameter or with the "sfdx config:set defaultusername=<username>" command.
 
-# missingLicenseType
-
-The sandbox license type is required, but you didn't provide a value. Specify the license type in the sandbox definition file with the "licenseType" option, or specify the option as a name-value pair at the command-line. See https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_sandbox_definition.htm for more information.
-
 # dnsTimeout
 
 The sandbox was successfully created and authenticated. However, the sandbox DNS records aren't ready yet and so the sandbox may not be available. Run "org:list" and check if the sandbox is listed correctly. If it isn't listed, run "force:org:status" to view its status and, if necessary, authenticate to it again. If this issue happens frequently, try setting the SFDX_DNS_TIMEOUT environment variable to a larger number; the default value is 3 seconds.

src/commands/org/create/sandbox.ts

@@ -11,17 +11,11 @@ import { Ux } from '@salesforce/sf-plugins-core/lib/ux';
 import * as Interfaces from '@oclif/core/lib/interfaces';
 import { createSandboxRequest } from '../../../shared/sandboxRequest';
 import { SandboxCommandBase } from '../../../shared/sandboxCommandBase';
+import { SandboxLicenseType } from '../../../shared/orgTypes';
 
 Messages.importMessagesDirectory(__dirname);
 const messages = Messages.loadMessages('@salesforce/plugin-org', 'create.sandbox');
 
-export enum SandboxLicenseType {
-  developer = 'Developer',
-  developerPro = 'Developer_Pro',
-  partial = 'Partial',
-  full = 'Full',
-}
-
 const getLicenseTypes = (): string[] => Object.values(SandboxLicenseType);
 
 type SandboxConfirmData = SandboxRequest & { CloneSource?: string };
@@ -99,7 +93,6 @@ export default class CreateSandbox extends SandboxCommandBase<SandboxProcessObje
       char: 'l',
       summary: messages.getMessage('flags.licenseType.summary'),
       exclusive: ['definition-file', 'clone'],
-      default: SandboxLicenseType.developer,
     }),
     'target-org': Flags.requiredOrg({
       char: 'o',

src/shared/orgTypes.ts

@@ -98,3 +98,10 @@ export interface ScratchCreateResponse {
   warnings: string[];
   orgId?: string;
 }
+
+export enum SandboxLicenseType {
+  developer = 'Developer',
+  developerPro = 'Developer_Pro',
+  partial = 'Partial',
+  full = 'Full',
+}

src/shared/sandboxRequest.ts

@@ -7,9 +7,9 @@
 import * as fs from 'fs';
 import { Logger, SandboxRequest, Messages, SfError, Lifecycle } from '@salesforce/core';
 import { lowerToUpper } from './utils';
+import { SandboxLicenseType } from './orgTypes';
 
 Messages.importMessagesDirectory(__dirname);
-const messages = Messages.loadMessages('@salesforce/plugin-org', 'create');
 const cloneMessages = Messages.loadMessages('@salesforce/plugin-org', 'clone');
 
 export const generateSboxName = async (): Promise<string> => {
@@ -72,7 +72,7 @@ export async function createSandboxRequest(
     return { sandboxReq, srcSandboxName: SourceSandboxName };
   } else {
     if (!sandboxReq.LicenseType) {
-      throw new SfError(messages.getMessage('missingLicenseType'));
+      return { sandboxReq: { ...sandboxReq, LicenseType: SandboxLicenseType.developer } };
     }
     return { sandboxReq };
   }