fix: only local config

Author: maggiben

src/commands/force/org/beta/create.ts

@@ -269,15 +269,14 @@ export class Create extends SfdxCommand {
       this.logger.debug('Set Alias: %s result: %s', this.flags.setalias, result);
     }
     if (this.flags.setdefaultusername) {
-      let config: Config;
       try {
-        config = await Config.create({ isGlobal: false });
-      } catch {
-        config = await Config.create({ isGlobal: true });
+        const config = await Config.create({ isGlobal: false });
+        const result = config.set(Config.DEFAULT_USERNAME, username);
+        await config.write();
+        this.logger.debug('Set defaultUsername: %s result: %s', this.flags.setdefaultusername, result);
+      } catch (error) {
+        this.logger.debug('Set defaultUsername failed with error: %s', error);
       }
-      const result = config.set(Config.DEFAULT_USERNAME, username);
-      await config.write();
-      this.logger.debug('Set defaultUsername: %s result: %s', this.flags.setdefaultusername, result);
     }
   }
   private async createScratchOrg(): Promise<ScratchOrgProcessObject> {

test/commands/force/org/scratchOrgCreate.test.ts

@@ -199,7 +199,13 @@ describe('org:create', () => {
         username: 'newScratchUsername',
       });
       const aliasStub = stubMethod(sandbox, Aliases.prototype, 'set');
-      const configStub = stubMethod(sandbox, Config.prototype, 'set');
+      const setStub = sandbox.spy();
+      const writeStub = sandbox.spy();
+      const configCreateStub = stubMethod(sandbox, Config, 'create').withArgs({ isGlobal: false }).resolves({
+        set: setStub,
+        write: writeStub,
+      });
+      // const configStub = stubMethod(sandbox, Config.prototype, 'set');
       await command.runIt();
       expect(prodOrg.firstCall.args[0]).to.deep.equal({
         apiversion: undefined,
@@ -217,7 +223,10 @@ describe('org:create', () => {
         orgConfig: {},
       });
       expect(aliasStub.firstCall.args).to.deep.equal(['sandboxAlias', 'newScratchUsername']);
-      expect(configStub.firstCall.args).to.deep.equal(['defaultusername', 'newScratchUsername']);
+      expect(configCreateStub.calledOnce).to.be.true;
+      expect(writeStub.calledOnce).to.be.true;
+      expect(configCreateStub.firstCall.firstArg).to.deep.equal({ isGlobal: false });
+      expect(setStub.firstCall.args).to.deep.equal(['defaultusername', 'newScratchUsername']);
     });
 
     it('will test json output', async () => {