refactor: use best practices

Author: mdonnalley

package.json

@@ -6,10 +6,10 @@
   "main": "lib/index.js",
   "bugs": "https://github.com/forcedotcom/cli/issues",
   "dependencies": {
-    "@oclif/core": "^2.1.0",
+    "@oclif/core": "^2.2.1",
     "@salesforce/core": "^3.33.1",
     "@salesforce/kit": "^1.8.5",
-    "@salesforce/sf-plugins-core": "^2.1.1",
+    "@salesforce/sf-plugins-core": "^2.2.0",
     "open": "8.4.1",
     "tslib": "^2"
   },
@@ -222,4 +222,4 @@
       "output": []
     }
   }
-}
+}

src/commands/force/org/clone.ts

@@ -15,7 +15,6 @@ import {
 } from '@salesforce/sf-plugins-core';
 import {
   SfError,
-  Config,
   Lifecycle,
   Messages,
   OrgTypes,
@@ -112,7 +111,7 @@ export class OrgCloneCommand extends SfCommand<SandboxProcessObject> {
             logger.debug('Set Alias: %s result: %s', flags.setalias, result);
           }
           if (flags.setdefaultusername) {
-            const globalConfig: Config = this.configAggregator.getGlobalConfig();
+            const globalConfig = this.configAggregator.getGlobalConfig();
             globalConfig.set(OrgConfigProperties.TARGET_ORG, results.sandboxRes.authUserName);
             const result = await globalConfig.write();
             logger.debug('Set defaultUsername: %s result: %s', flags.setdefaultusername, result);

src/commands/force/org/create.ts

@@ -214,7 +214,7 @@ export class Create extends SfCommand<CreateResult> {
     try {
       return await this.flags['target-org'].createSandbox(sandboxReq, { wait });
     } catch (e) {
-      // guaranteed to be SfdxError from core;
+      // guaranteed to be SfError from core;
       const err = e as SfError;
       if (err?.message.includes('The org cannot be found')) {
         // there was most likely an issue with DNS when auth'ing to the new sandbox, but it was created.

src/commands/org/display.ts

@@ -79,15 +79,12 @@ export class OrgDisplayCommand extends SfCommand<OrgDisplayReturn> {
       alias: await getAliasByUsername(fields.username),
     };
     this.warn(sharedMessages.getMessage('SecurityWarning'));
-
-    if (!flags.json) {
-      this.print(returnValue);
-    }
+    this.print(returnValue);
     return returnValue;
   }
 
   private print(result: OrgDisplayReturn): void {
-    this.log('');
+    this.log();
     const tableRows = Object.entries(result)
       .filter(([, value]) => value !== undefined && value !== null) // some values won't exist
       .sort() // this command always alphabetizes the table rows