Merge pull request #856 from salesforcecli/devScripts2023-11-05

refactor: devScripts update

Author: svc-cli-bot

package.json

@@ -7,49 +7,28 @@
   "bugs": "https://github.com/forcedotcom/cli/issues",
   "dependencies": {
     "@oclif/core": "^2.15.0",
-    "@salesforce/core": "^5.3.9",
-    "@salesforce/kit": "^3.0.9",
+    "@salesforce/core": "^5.3.18",
+    "@salesforce/kit": "^3.0.15",
     "@salesforce/sf-plugins-core": "^3.1.28",
-    "@salesforce/source-deploy-retrieve": "^9.7.28",
+    "@salesforce/source-deploy-retrieve": "^9.8.4",
     "open": "^8.4.2",
     "tslib": "^2"
   },
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^4.0.14",
     "@salesforce/cli-plugins-testkit": "^4.4.7",
-    "@salesforce/dev-config": "^4.1.0",
-    "@salesforce/dev-scripts": "^5.12.2",
+    "@salesforce/dev-scripts": "^6.0.3",
     "@salesforce/plugin-command-reference": "^3.0.46",
-    "@salesforce/plugin-source": "^2.10.46",
-    "@salesforce/prettier-config": "^0.0.3",
     "@salesforce/ts-sinon": "1.4.19",
     "@swc/core": "1.3.39",
     "@types/shelljs": "^0.8.14",
-    "@typescript-eslint/eslint-plugin": "^5.61.0",
-    "@typescript-eslint/parser": "^5.61.0",
-    "chai": "^4.3.10",
-    "eslint": "^8.52.0",
-    "eslint-config-prettier": "^8.10.0",
-    "eslint-config-salesforce": "^2.0.2",
-    "eslint-config-salesforce-license": "^0.2.0",
-    "eslint-config-salesforce-typescript": "^2.0.0",
-    "eslint-plugin-header": "^3.1.1",
-    "eslint-plugin-import": "2.28.1",
-    "eslint-plugin-jsdoc": "^46.8.2",
     "eslint-plugin-sf-plugin": "^1.16.13",
-    "husky": "^7.0.4",
-    "mocha": "^10.2.0",
     "moment": "^2.29.1",
-    "nyc": "^15.1.0",
     "oclif": "^3.17.2",
-    "prettier": "^2.8.8",
-    "pretty-quick": "^3.1.0",
     "shelljs": "^0.8.5",
     "shx": "0.3.4",
-    "sinon": "10.0.0",
     "ts-node": "^10.9.1",
-    "typescript": "^5.2.2",
-    "wireit": "^0.14.1"
+    "typescript": "^5.2.2"
   },
   "engines": {
     "node": ">=16.0.0"
@@ -75,8 +54,7 @@
     "devPlugins": [
       "@oclif/plugin-help",
       "@oclif/plugin-command-snapshot",
-      "@salesforce/plugin-command-reference",
-      "@salesforce/plugin-source"
+      "@salesforce/plugin-command-reference"
     ],
     "topics": {
       "org": {

src/commands/force/org/clone.ts

@@ -86,7 +86,7 @@ export class OrgCloneCommand extends SfCommand<SandboxProcessObject> {
     const varargs = parseVarArgs(args, argv as string[]);
 
     const lifecycle = Lifecycle.getInstance();
-    if (flags.type === OrgTypes.Sandbox) {
+    if (flags.type === OrgTypes.Sandbox.toString()) {
       lifecycle.on(SandboxEvents.EVENT_ASYNC_RESULT, async (results: SandboxProcessObject) =>
         // Keep all console output in the command
         Promise.resolve(

src/commands/org/open.ts

@@ -86,7 +86,7 @@ export class OrgOpenCommand extends SfCommand<OrgOpenOutput> {
     const containerMode = new Env().getBoolean('SFDX_CONTAINER_MODE');
 
     // security warning only for --json OR --url-only OR containerMode
-    if (flags['url-only'] || flags.json || containerMode) {
+    if (flags['url-only'] || Boolean(flags.json) || containerMode) {
       this.warn(sharedMessages.getMessage('SecurityWarning'));
       this.log('');
     }