Merge pull request #358 from salesforcecli/cd/org-create-duration-default

fix: set scratch org duration to 7days by default

Author: mshanemc

src/commands/force/org/beta/create.ts

@@ -90,6 +90,7 @@ export class Create extends SfdxCommand {
       description: messages.getMessage('flags.durationDays'),
       min: 1,
       max: 30,
+      default: 7,
     }),
     retry: flags.number({
       hidden: true,

test/commands/force/org/sandboxCreate.test.ts

@@ -89,7 +89,7 @@ describe('org:create', () => {
     it('will warn the user when --clientid is passed', async () => {
       const commmand = await createCommand(['--type', 'sandbox', '--clientid', '123', '-u', 'testProdOrg']);
       await commmand.runIt();
-      expect(uxWarnStub.calledOnce).to.be.true;
+      expect(uxWarnStub.calledTwice).to.be.true;
       expect(uxWarnStub.firstCall.args[0]).to.equal(
         '-i | --clientid is not supported for the sandbox org create command. Its value, 123, has been ignored.'
       );
@@ -99,7 +99,7 @@ describe('org:create', () => {
     it('will warn the user when --nonamespace is passed', async () => {
       const commmand = await createCommand(['--type', 'sandbox', '--nonamespace', '-u', 'testProdOrg']);
       await commmand.runIt();
-      expect(uxWarnStub.calledOnce).to.be.true;
+      expect(uxWarnStub.calledTwice).to.be.true;
       expect(uxWarnStub.firstCall.args[0]).to.equal(
         '-n | --nonamespace is not supported for the sandbox org create command. Its value, true, has been ignored.'
       );
@@ -108,7 +108,7 @@ describe('org:create', () => {
     it('will warn the user when --noancestors is passed', async () => {
       const commmand = await createCommand(['--type', 'sandbox', '--noancestors', '-u', 'testProdOrg']);
       await commmand.runIt();
-      expect(uxWarnStub.calledOnce).to.be.true;
+      expect(uxWarnStub.calledTwice).to.be.true;
       expect(uxWarnStub.firstCall.args[0]).to.equal(
         '-c | --noancestors is not supported for the sandbox org create command. Its value, true, has been ignored.'
       );

test/commands/force/org/scratchOrgCreate.test.ts

@@ -111,7 +111,7 @@ describe('org:create', () => {
         apiversion: undefined,
         clientSecret: undefined,
         connectedAppConsumerKey: undefined,
-        durationDays: undefined,
+        durationDays: 7,
         noancestors: undefined,
         nonamespace: undefined,
         wait: {
@@ -167,7 +167,7 @@ describe('org:create', () => {
         clientSecret,
         connectedAppConsumerKey,
         definitionfile,
-        durationDays: undefined,
+        durationDays: 7,
         noancestors: undefined,
         nonamespace: undefined,
         wait: {
@@ -212,7 +212,7 @@ describe('org:create', () => {
         clientSecret: undefined,
         connectedAppConsumerKey: undefined,
         definitionfile,
-        durationDays: undefined,
+        durationDays: 7,
         noancestors: undefined,
         nonamespace: undefined,
         wait: {
@@ -254,7 +254,7 @@ describe('org:create', () => {
         clientSecret: undefined,
         connectedAppConsumerKey: undefined,
         definitionfile,
-        durationDays: undefined,
+        durationDays: 7,
         noancestors: undefined,
         nonamespace: undefined,
         wait: {
@@ -285,7 +285,7 @@ describe('org:create', () => {
         clientSecret: undefined,
         connectedAppConsumerKey: undefined,
         definitionfile,
-        durationDays: undefined,
+        durationDays: 7,
         noancestors: undefined,
         nonamespace: undefined,
         wait: {