chore: resolve review comments

Author: peternhale

src/commands/force/org/clone.ts

@@ -121,10 +121,10 @@ export class OrgCloneCommand extends SfCommand<SandboxProcessObject> {
       });
 
       const { sandboxReq, srcSandboxName } = await createSandboxRequest(true, flags.definitionfile, logger, varargs);
-
       logger.debug('Calling clone with SandboxRequest: %s and SandboxName: %s ', sandboxReq, srcSandboxName);
       flags['target-org'].getConnection(flags['api-version']);
-      return flags['target-org'].cloneSandbox(sandboxReq, srcSandboxName, { wait: flags.wait });
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+      return flags['target-org'].cloneSandbox(sandboxReq, srcSandboxName!, { wait: flags.wait });
     } else {
       throw new SfError(
         messages.getMessage('commandOrganizationTypeNotSupport', [OrgTypes.Sandbox]),

src/commands/org/list.ts

@@ -51,7 +51,6 @@ export class OrgListCommand extends SfCommand<OrgListResult> {
 
   private flags!: Interfaces.InferredFlags<typeof OrgListCommand.flags>;
 
-  // eslint-disable-next-line sf-plugin/should-parse-flags
   public async run(): Promise<OrgListResult> {
     const [{ flags }, fileNames] = await Promise.all([this.parse(OrgListCommand), getAuthFileNames()]);
     this.flags = flags;

src/shared/sandboxRequest.ts

@@ -20,18 +20,6 @@ export const generateSboxName = async (): Promise<string> => {
   return generated;
 };
 
-export async function createSandboxRequest(
-  isClone: true | boolean,
-  definitionFile: string | undefined,
-  logger?: Logger | undefined,
-  properties?: Record<string, string | undefined>
-): Promise<{ sandboxReq: SandboxRequest; srcSandboxName: string }>;
-export async function createSandboxRequest(
-  isClone: false,
-  definitionFile: string | undefined,
-  logger?: Logger | undefined,
-  properties?: Record<string, string | undefined>
-): Promise<{ sandboxReq: SandboxRequest }>;
 export async function createSandboxRequest(
   isClone = false,
   definitionFile: string | undefined,