Skip to content

Commit 2fb3217

Browse files
fix: add retrieve via packageNames param
1 parent abba216 commit 2fb3217

File tree

4 files changed

+63
-455
lines changed

4 files changed

+63
-455
lines changed

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
"devDependencies": {
1616
"@oclif/dev-cli": "^1",
1717
"@oclif/plugin-command-snapshot": "^2.0.0",
18-
"@salesforce/dev-config": "^2.1.0",
1918
"@salesforce/cli-plugins-testkit": "^0.0.8",
19+
"@salesforce/dev-config": "^2.1.0",
2020
"@salesforce/dev-scripts": "^0.7.0",
2121
"@salesforce/plugin-command-reference": "^1.3.0",
2222
"@salesforce/prettier-config": "^0.0.2",
@@ -25,24 +25,24 @@
2525
"@typescript-eslint/parser": "^4.2.0",
2626
"chai": "^4.2.0",
2727
"cz-conventional-changelog": "^3.3.0",
28-
"eslint": "^7.20.0",
28+
"eslint": "^6.8.0",
2929
"eslint-config-prettier": "^6.11.0",
3030
"eslint-config-salesforce": "^0.1.0",
3131
"eslint-config-salesforce-license": "^0.1.0",
3232
"eslint-config-salesforce-typescript": "^0.2.0",
3333
"eslint-plugin-header": "^3.0.0",
3434
"eslint-plugin-import": "^2.20.2",
35-
"eslint-plugin-jsdoc": "^32.0.2",
35+
"eslint-plugin-jsdoc": "^27.0.3",
3636
"eslint-plugin-prettier": "^3.1.3",
3737
"husky": "^4.2.5",
3838
"lint-staged": "^10.2.2",
39-
"mocha": "^8.3.0",
39+
"mocha": "^7.2.0",
4040
"nyc": "^15.1.0",
4141
"prettier": "^2.0.5",
42-
"pretty-quick": "^3.1.0",
42+
"pretty-quick": "^2.0.1",
4343
"shx": "0.3.3",
4444
"sinon": "^9.0.2",
45-
"ts-node": "^9.1.1",
45+
"ts-node": "^8.10.2",
4646
"typescript": "^4.1.3"
4747
},
4848
"config": {

src/commands/force/source/retrieve.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,7 @@ export class retrieve extends SourceCommand {
7676
usernameOrConnection: this.org.getUsername(),
7777
merge: true,
7878
output: (this.flags.sourcepath as string) ?? defaultPackage.path,
79-
// TODO: fix this once wait has been updated in library
80-
// wait: (this.flags.wait as Duration).milliseconds,
81-
// TODO: implement retrieve via package name
82-
// package: options.packagenames
79+
packageNames: asArray<string>(this.flags.packagenames),
8380
})
8481
.start();
8582

@@ -89,6 +86,7 @@ export class retrieve extends SourceCommand {
8986
if (results.status === 'InProgress') {
9087
throw new SfdxError(messages.getMessage('retrieveTimeout', [(this.flags.wait as Duration).minutes]));
9188
}
89+
this.ux.logJson(mdapiResult.getFileResponses());
9290
// this.printTable(results, true);
9391

9492
return results;

src/sourceCommand.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ export abstract class SourceCommand extends SfdxCommand {
4242
}
4343

4444
if (options.packagenames) {
45-
// retrieve only
46-
// TODO: @W-8908888@
45+
// return ComponentSet and use packageNames in the library via `.retrieve` options
46+
setAggregator.push(...new ComponentSet([]));
4747
}
4848

4949
if (options.manifest) {

0 commit comments

Comments
 (0)