Merge pull request nextcloud#54624 from nextcloud/fix/missing-variable

fix(theming): add missing `color-text-success` variable

Author: susnux

apps/theming/css/default.css

@@ -19,6 +19,7 @@
   --color-text-maxcontrast-default: #6b6b6b;
   --color-text-maxcontrast-background-blur: #595959;
   --color-text-error: #c90000;
+  --color-text-success: #066e03;
   /** @deprecated use ` --color-main-text` instead */
   --color-text-light: var(--color-main-text);
   /** @deprecated use `--color-text-maxcontrast` instead */

apps/theming/lib/Themes/DarkHighContrastTheme.php

@@ -67,8 +67,7 @@ public function getCSSVariables(): array {
 				'--color-text-maxcontrast' => $colorMainText,
 				'--color-text-maxcontrast-background-blur' => $colorMainText,
 				'--color-text-error' => $this->util->lighten($colorError, 65),
-				'--color-text-light' => $colorMainText,
-				'--color-text-lighter' => $colorMainText,
+				'--color-text-success' => $this->util->lighten($colorSuccess, 65),
 
 				'--color-error' => $colorError,
 				'--color-error-rgb' => join(',', $this->util->hexToRGB($colorError)),

apps/theming/lib/Themes/DarkTheme.php

@@ -83,8 +83,7 @@ public function getCSSVariables(): array {
 				'--color-text-maxcontrast-default' => $colorTextMaxcontrast,
 				'--color-text-maxcontrast-background-blur' => $this->util->lighten($colorTextMaxcontrast, 6),
 				'--color-text-error' => $colorErrorElement,
-				'--color-text-light' => 'var(--color-main-text)', // deprecated
-				'--color-text-lighter' => 'var(--color-text-maxcontrast)', // deprecated
+				'--color-text-success' => $this->util->lighten($colorSuccessElement, 10),
 
 				'--color-error' => $colorError,
 				'--color-error-hover' => $this->util->lighten($colorError, 10),

apps/theming/lib/Themes/DefaultTheme.php

@@ -129,6 +129,7 @@ public function getCSSVariables(): array {
 			'--color-text-maxcontrast-default' => $colorTextMaxcontrast,
 			'--color-text-maxcontrast-background-blur' => $this->util->darken($colorTextMaxcontrast, 7),
 			'--color-text-error' => $colorErrorElement,
+			'--color-text-success' => $this->util->darken($colorSuccessElement, 10),
 			'--color-text-light' => 'var(--color-main-text)', // deprecated
 			'--color-text-lighter' => 'var(--color-text-maxcontrast)', // deprecated
 

apps/theming/lib/Themes/HighContrastTheme.php

@@ -70,8 +70,7 @@ public function getCSSVariables(): array {
 				'--color-text-maxcontrast' => $colorMainText,
 				'--color-text-maxcontrast-background-blur' => $colorMainText,
 				'--color-text-error' => $this->util->darken($colorError, 65),
-				'--color-text-light' => $colorMainText,
-				'--color-text-lighter' => $colorMainText,
+				'--color-text-success' => $this->util->darken($colorSuccess, 70),
 
 				'--color-error' => $colorError,
 				'--color-error-rgb' => join(',', $this->util->hexToRGB($colorError)),

apps/theming/tests/Themes/AccessibleThemeTestCase.php

@@ -150,6 +150,7 @@ public static function dataAccessibilityPairs(): array {
 			'error-text-on-background' => [
 				[
 					'--color-text-error',
+					'--color-text-success',
 				],
 				[
 					'--color-main-background',