Merge pull request #315 from gdebrauwer/empty-response-to-json

Bugfix: empty response body to json should not fail

Author: Sammyjo20

src/Http/Response.php

@@ -191,7 +191,7 @@ public function getSenderException(): ?Throwable
     public function json(string|int|null $key = null, mixed $default = null): mixed
     {
         if (! isset($this->decodedJson)) {
-            $this->decodedJson = json_decode($this->body(), true, 512, JSON_THROW_ON_ERROR);
+            $this->decodedJson = json_decode($this->body() ?: '[]', true, 512, JSON_THROW_ON_ERROR);
         }
 
         if (is_null($key)) {

tests/Unit/ResponseTest.php

@@ -153,6 +153,16 @@
     expect($response->collect('age'))->toBeEmpty();
 });
 
+test('the json method will return empty array if body is empty', function () {
+    $mockClient = new MockClient([
+        MockResponse::make('', 404),
+    ]);
+
+    $response = connector()->send(new UserRequest, $mockClient);
+
+    expect($response->json())->toBe([]);
+});
+
 test('the toPsrResponse method will return a guzzle response', function () {
     $mockClient = new MockClient([
         MockResponse::make(['name' => 'Sam', 'work' => 'Codepotato'], 500),