Merge pull request #326 from saloonphp/fix/mock-client-assertions-with-fixtures

Fix | MockClient assertions with fixtures

Author: Sammyjo20

src/Http/Middleware/DetermineMockResponse.php

@@ -53,7 +53,7 @@ public function __invoke(PendingRequest $pendingRequest): PendingRequest
         // middleware on the response to record the response.
 
         if (is_null($mockResponse) && $mockObject instanceof Fixture) {
-            $pendingRequest->middleware()->onResponse(new RecordFixture($mockObject), 'recordFixture', PipeOrder::FIRST);
+            $pendingRequest->middleware()->onResponse(new RecordFixture($mockObject, $mockClient), 'recordFixture', PipeOrder::FIRST);
         }
 
         return $pendingRequest;

src/Http/Middleware/RecordFixture.php

@@ -7,6 +7,7 @@
 use Saloon\Http\Response;
 use Saloon\Http\Faking\Fixture;
 use Saloon\Data\RecordedResponse;
+use Saloon\Http\Faking\MockClient;
 use Saloon\Contracts\ResponseMiddleware;
 
 class RecordFixture implements ResponseMiddleware
@@ -16,12 +17,18 @@ class RecordFixture implements ResponseMiddleware
      */
     protected Fixture $fixture;
 
+    /**
+     * Mock Client
+     */
+    protected MockClient $mockClient;
+
     /**
      * Constructor
      */
-    public function __construct(Fixture $fixture)
+    public function __construct(Fixture $fixture, MockClient $mockClient)
     {
         $this->fixture = $fixture;
+        $this->mockClient = $mockClient;
     }
 
     /**
@@ -37,5 +44,7 @@ public function __invoke(Response $response): void
         $this->fixture->store(
             RecordedResponse::fromResponse($response)
         );
+
+        $this->mockClient->recordResponse($response);
     }
 }

tests/Feature/MockRequestTest.php

@@ -729,3 +729,13 @@ function (PendingRequest $pendingRequest): MockResponse {
     expect($middlewareC)->toBeTrue();
     expect($middlewareD)->toBeTrue();
 });
+
+test('fixtures are still recorded on the first request', function () {
+    $mockClient = new MockClient([
+        MockResponse::fixture('user'), // Test Exact Route
+    ]);
+
+    connector()->send(new UserRequest, $mockClient);
+
+    $mockClient->assertSent(UserRequest::class);
+});