enhance: UrlHelper join method handle endpoint URL string

Author: ashleyhood

src/Helpers/URLHelper.php

@@ -27,6 +27,10 @@ public static function matches(string $pattern, string $value): bool
      */
     public static function join(string $baseUrl, string $endpoint): string
     {
+        if (static::isValidUrl($endpoint)) {
+            return $endpoint;
+        }
+
         if ($endpoint !== '/') {
             $endpoint = ltrim($endpoint, '/ ');
         }
@@ -35,11 +39,13 @@ public static function join(string $baseUrl, string $endpoint): string
 
         $baseEndpoint = rtrim($baseUrl, '/ ');
 
-        $endpointIsNotUrl = empty(filter_var($endpoint, FILTER_VALIDATE_URL));
-        $glue = $endpointIsNotUrl ? '/' : null;
-
-        $baseEndpoint = $requiresTrailingSlash ? $baseEndpoint . $glue : $baseEndpoint;
+        $baseEndpoint = $requiresTrailingSlash ? $baseEndpoint . '/' : $baseEndpoint;
 
         return $baseEndpoint . $endpoint;
     }
+
+    public static function isValidUrl(string $url): bool
+    {
+        return ! empty(filter_var($url, FILTER_VALIDATE_URL));
+    }
 }

tests/Unit/URLHelperTest.php

@@ -12,4 +12,5 @@
     ['https://google.com//', '//search', 'https://google.com/search'],
     ['', 'https://google.com/search', 'https://google.com/search'],
     ['', 'google.com/search', '/google.com/search'],
+    ['https://google.com', 'https://api.google.com/search', 'https://api.google.com/search'],
 ]);