Skip to content

Commit df1ce97

Browse files
authored
Merge pull request #139 from Sammyjo20/feature/v2-beta-improvements
Feature | V2 Beta improvements
2 parents a862c51 + 1f09ff6 commit df1ce97

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+11
-1374
lines changed

src/Http/Pool.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ class Pool implements PoolContract
5353
* Constructor
5454
*
5555
* @param \Saloon\Http\Connector $connector
56-
* @param callable|iterable $requestPayload
56+
* @param callable|iterable $requests
5757
* @param int|callable $concurrency
5858
* @param callable|null $responseHandler
5959
* @param callable|null $exceptionHandler
6060
*/
61-
public function __construct(Connector $connector, callable|iterable $requestPayload = [], int|callable $concurrency = 5, callable|null $responseHandler = null, callable|null $exceptionHandler = null)
61+
public function __construct(Connector $connector, callable|iterable $requests = [], int|callable $concurrency = 5, callable|null $responseHandler = null, callable|null $exceptionHandler = null)
6262
{
6363
$this->connector = $connector;
64-
$this->setRequests($requestPayload);
64+
$this->setRequests($requests);
6565
$this->concurrency = $concurrency;
6666
$this->responseHandler = $responseHandler;
6767
$this->exceptionHandler = $exceptionHandler;

src/Http/Senders/SimulatedSender.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
namespace Saloon\Http\Senders;
66

77
use Throwable;
8-
use Saloon\Http\Response;
98
use Saloon\Contracts\Sender;
109
use Saloon\Contracts\PendingRequest;
1110
use Saloon\Http\Faking\MockResponse;

src/Traits/Plugins/AcceptsJson.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
trait AcceptsJson
1010
{
1111
/**
12+
* Boot AcceptsJson Plugin
13+
*
1214
* @param PendingRequest $pendingRequest
1315
* @return void
1416
*/

src/Traits/Plugins/AcceptsXml.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
trait AcceptsXml
1010
{
1111
/**
12-
* Boot the AcceptsXml trait.
12+
* Boot AcceptsXml Plugin
1313
*
1414
* @param PendingRequest $pendingRequest
1515
* @return void

src/Traits/Plugins/AlwaysThrowsOnErrors.php renamed to src/Traits/Plugins/AlwaysThrowOnErrors.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@
77
use Saloon\Contracts\Response;
88
use Saloon\Contracts\PendingRequest;
99

10-
trait AlwaysThrowsOnErrors
10+
trait AlwaysThrowOnErrors
1111
{
1212
/**
13-
* Always throw if there is something wrong with the request.
13+
* Boot AlwaysThrowOnErrors Plugin
1414
*
1515
* @param PendingRequest $pendingRequest
1616
* @return void
1717
*/
18-
public static function bootAlwaysThrowsOnErrors(PendingRequest $pendingRequest): void
18+
public static function bootAlwaysThrowOnErrors(PendingRequest $pendingRequest): void
1919
{
2020
$pendingRequest->middleware()->onResponse(fn (Response $response) => $response->throw());
2121
}

src/Traits/Plugins/DisablesSSLVerification.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/Traits/Plugins/WithDebugData.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

tests/Fixtures/Collections/GuessedGroup.php

Lines changed: 0 additions & 17 deletions
This file was deleted.

tests/Fixtures/Collections/UserGroup.php

Lines changed: 0 additions & 20 deletions
This file was deleted.

tests/Fixtures/Connectors/ExtendedConnector.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)