Merge pull request #21 from ajthinking/main

Add default defineEndpoint in base SaloonRequest

Author: Sammyjo20

src/Http/SaloonRequest.php

@@ -136,6 +136,16 @@ public function getFullRequestUrl(): string
         return $baseEndpoint . $requestEndpoint;
     }
 
+    /**
+     * Define the endpoint for the request.
+     *
+     * @return string
+     */
+    public function defineEndpoint(): string
+    {
+        return '';
+    }	
+
     /**
      * Check if a trait exists on the connector.
      *

tests/Resources/Requests/DefaultEndpointRequest.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Sammyjo20\Saloon\Tests\Resources\Requests;
+
+use Sammyjo20\Saloon\Constants\Saloon;
+use Sammyjo20\Saloon\Http\SaloonRequest;
+use Sammyjo20\Saloon\Tests\Resources\Connectors\TestConnector;
+
+class DefaultEndpointRequest extends SaloonRequest
+{
+    /**
+     * Define the method that the request will use.
+     *
+     * @var string|null
+     */
+    protected ?string $method = Saloon::POST;
+
+    /**
+     * The connector.
+     *
+     * @var string|null
+     */
+    protected ?string $connector = TestConnector::class;
+}

tests/Unit/RequestTest.php

@@ -10,6 +10,7 @@
 use Sammyjo20\Saloon\Tests\Resources\Connectors\ExtendedConnector;
 use Sammyjo20\Saloon\Tests\Resources\Requests\InvalidResponseClass;
 use Sammyjo20\Saloon\Exceptions\SaloonInvalidResponseClassException;
+use Sammyjo20\Saloon\Tests\Resources\Requests\DefaultEndpointRequest;
 use Sammyjo20\Saloon\Tests\Resources\Requests\InvalidConnectorRequest;
 use Sammyjo20\Saloon\Exceptions\SaloonNoMockResponsesProvidedException;
 use Sammyjo20\Saloon\Tests\Resources\Requests\ExtendedConnectorRequest;
@@ -113,3 +114,7 @@
 
     expect($invalidConnectorClassRequest->getResponseClass());
 });
+
+test('defineEndpoint method may be omited in request class to use the base url')
+	->expect(new DefaultEndpointRequest)
+	->getFullRequestUrl()->toBe(apiUrl());