Skip to content

Commit c0ce2eb

Browse files
authored
Merge pull request #3 from ryanwalder/fix-debian-directory-bug
Add `zones_directory` variable to map
2 parents d51c30c + 2e8643f commit c0ce2eb

File tree

3 files changed

+27
-8
lines changed

3 files changed

+27
-8
lines changed

bind/config.sls

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,17 @@ named_directory:
4545
- require:
4646
- pkg: bind
4747
48+
bind_zones_directory:
49+
file.directory:
50+
- name: {{ map.named_directory }}/{{ map.zones_directory }}
51+
- user: {{ salt['pillar.get']('bind:config:user', map.user) }}
52+
- group: {{ salt['pillar.get']('bind:config:group', map.group) }}
53+
- mode: 775
54+
- makedirs: True
55+
- require:
56+
- pkg: bind
57+
- file: named_directory
58+
4859
bind_config:
4960
file.managed:
5061
- name: {{ map.config }}
@@ -120,6 +131,7 @@ bind_options_config:
120131
- context:
121132
key_directory: {{ map.key_directory }}
122133
named_directory: {{ map.named_directory }}
134+
zones_directory: {{ map.zones_directory }}
123135
- require:
124136
- pkg: bind
125137
- watch_in:
@@ -197,7 +209,7 @@ bind_rndc_client_config:
197209
{% if file and zone_data['type'] == 'master' -%}
198210
zones{{ dash_view }}-{{ zone }}{{ '.include' if serial_auto else ''}}:
199211
file.managed:
200-
- name: {{ map.named_directory }}/{{ file }}{{ '.include' if serial_auto else ''}}
212+
- name: {{ map.named_directory }}/{{ map.zones_directory }}/{{ file }}{{ '.include' if serial_auto else ''}}
201213
- source: {{ zone_source }}
202214
- template: jinja
203215
{% if zone_records != {} %}
@@ -214,6 +226,7 @@ zones{{ dash_view }}-{{ zone }}{{ '.include' if serial_auto else ''}}:
214226
- service: bind
215227
- require:
216228
- file: named_directory
229+
- file: bind_zones_directory
217230
218231
{% if serial_auto %}
219232
zones{{ dash_view }}-{{ zone }}:
@@ -222,9 +235,9 @@ zones{{ dash_view }}-{{ zone }}:
222235
- update: True
223236
- zone: zones{{ dash_view }}-{{ zone }}
224237
- watch:
225-
- file: {{ map.named_directory }}/{{ file }}.include
238+
- file: {{ map.named_directory }}/{{ map.zones_directory }}/{{ file }}.include
226239
file.managed:
227-
- name: {{ map.named_directory }}/{{ file }}
240+
- name: {{ map.named_directory }}/{{ map.zones_directory }}/{{ file }}
228241
- require:
229242
- module: zones{{ dash_view }}-{{ zone }}
230243
- source: {{ zone_source }}
@@ -233,7 +246,7 @@ zones{{ dash_view }}-{{ zone }}:
233246
- context:
234247
zone: zones{{ dash_view }}-{{ zone }}
235248
soa: {{ salt['pillar.get']("bind:available_zones:" + zone + ":soa") }}
236-
include: {{ file }}.include
249+
include: {{ map.named_directory }}/{{ map.zones_directory }}/{{ file }}.include
237250
{% endif %}
238251
- user: {{ salt['pillar.get']('bind:config:user', map.user) }}
239252
- group: {{ salt['pillar.get']('bind:config:group', map.group) }}
@@ -242,11 +255,12 @@ zones{{ dash_view }}-{{ zone }}:
242255
- service: bind
243256
- require:
244257
- file: named_directory
258+
- file: bind_zones_directory
245259
{% endif %}
246260
{% if zone_data['dnssec'] is defined and zone_data['dnssec'] -%}
247261
signed{{ dash_view }}-{{ zone }}:
248262
cmd.run:
249-
- cwd: {{ map.named_directory }}
263+
- cwd: {{ map.named_directory }}/{{ map.zones_directory }}
250264
- name: zonesigner -zone {{ zone }} {{ file }}
251265
- prereq:
252266
- file: zones{{ dash_view }}-{{ zone }}

bind/files/named.conf.local.jinja

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ zone "{{ key }}" {
2121
};
2222
{% else -%}
2323
{% if args['dnssec'] is defined and args['dnssec'] -%}
24-
file "{{ map.named_directory }}/{{ file }}.signed";
24+
file "{{ map.named_directory }}/{{ map.zones_directory }}/{{ file }}.signed";
2525
{% else -%}
26-
file "{{ map.named_directory }}/{{ file }}";
26+
file "{{ map.named_directory }}/{{ map.zones_directory }}/{{ file }}";
2727
{%- endif %}
2828
{% if args['auto-dnssec'] is defined -%}
2929
auto-dnssec {{ args['auto-dnssec'] }};

bind/map.jinja

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
'default_zones_config': '/etc/bind/named.conf.default-zones',
1313
'logging_config': '/etc/bind/named.conf.logging',
1414
'rndc_client_config': '/etc/bind/rndc.conf',
15-
'named_directory': '/var/cache/bind/zones',
15+
'named_directory': '/var/cache/bind',
16+
'zones_directory': 'zones',
1617
'chroot_dir': '',
1718
'log_dir': '/var/log/bind9',
1819
'log_mode': '644',
@@ -36,6 +37,7 @@
3637
'local_config': '/etc/named.conf.local',
3738
'default_config': '/etc/sysconfig/named',
3839
'named_directory': '/var/named',
40+
'zones_directory': 'zones',
3941
'chroot_dir': '',
4042
'log_dir': '/var/log/named',
4143
'log_mode': '640',
@@ -63,6 +65,7 @@
6365
'config': '/etc/named.conf',
6466
'local_config': '/etc/named.conf.local',
6567
'named_directory': '/var/named',
68+
'zones_directory': 'zones',
6669
'chroot_dir': '',
6770
'log_dir': '/var/log/named',
6871
'log_mode': '640',
@@ -82,6 +85,7 @@
8285
'config': '/usr/local/etc/namedb/named.conf',
8386
'local_config': '/usr/local/etc/namedb/named.conf.local',
8487
'named_directory': '/usr/local/etc/namedb/working',
88+
'zones_directory': 'zones',
8589
'chroot_dir': '',
8690
'log_dir': '/var/log/named',
8791
'log_mode': '660',
@@ -102,6 +106,7 @@
102106
'local_config': '/etc/named.d/named.conf.local',
103107
'default_config': '/etc/sysconfig/named',
104108
'named_directory': '/var/lib/named',
109+
'zones_directory': 'zones',
105110
'chroot_dir': '/var/lib/named',
106111
'log_dir': '/var/log',
107112
'log_mode': '660',

0 commit comments

Comments
 (0)