Skip to content

Commit 03b12c2

Browse files
Merge pull request #41 from smitelli/master
Add a falsy default to each instance of pillar.get
2 parents ae373af + d68c7b1 commit 03b12c2

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

node/config.sls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{% from "node/map.jinja" import npmrc with context %}
2-
{% set config = salt['pillar.get']('npm:config') %}
2+
{% set config = salt['pillar.get']('npm:config', '') %}
33
{% if config %}
44
{{ npmrc }}:
55
file.managed:

node/init.sls

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{% set pillar_get = salt['pillar.get'] -%}
22
include:
3-
{% if pillar_get('node:install_from_source') %}
3+
{% if pillar_get('node:install_from_source', '') %}
44
- .source
5-
{% elif pillar_get('node:install_from_binary') %}
5+
{% elif pillar_get('node:install_from_binary', '') %}
66
- .binary
77
{% else %}
88
- .pkg

node/map.jinja

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% set pillar_get = salt['pillar.get'] -%}
22

3-
{% if pillar_get('node:install_from_source') %}
3+
{% if pillar_get('node:install_from_source', '') %}
44
{% set default_npm_prefix = '/usr/local' %}
55
{% else %}
66
{% set default_npm_prefix = '/usr' %}
@@ -22,20 +22,20 @@
2222
'npm_pkg': 'npm',
2323
},
2424
'Debian': {
25-
'node_pkg': 'nodejs' if grains['osrelease']|float < 8 or pillar_get('node:install_from_ppa') else 'nodejs-legacy',
26-
'npm_pkg': 'nodejs' if pillar_get('node:install_from_ppa') else 'npm',
25+
'node_pkg': 'nodejs' if grains['osrelease']|float < 8 or pillar_get('node:install_from_ppa', '') else 'nodejs-legacy',
26+
'npm_pkg': 'nodejs' if pillar_get('node:install_from_ppa', '') else 'npm',
2727
},
2828
'Ubuntu': {
2929
'node_pkg': 'nodejs',
30-
'npm_pkg': 'nodejs' if pillar_get('node:install_from_ppa') else 'npm',
30+
'npm_pkg': 'nodejs' if pillar_get('node:install_from_ppa', '') else 'npm',
3131
},
3232
'Raspbian': {
3333
'node_pkg': 'nodejs',
34-
'npm_pkg': 'nodejs' if pillar_get('node:install_from_ppa') else 'npm',
34+
'npm_pkg': 'nodejs' if pillar_get('node:install_from_ppa', '') else 'npm',
3535
},
36-
}, grain='os', merge=pillar_get('node:lookup')) %}
36+
}, grain='os', merge=pillar_get('node:lookup', '')) %}
3737

38-
{% if pillar_get('node:install_from_source') or (grains['os_family'] == 'Debian' and grains['osrelease']|float < 8 and not pillar_get('node:install_from_ppa')) %}
38+
{% if pillar_get('node:install_from_source', '') or (grains['os_family'] == 'Debian' and grains['osrelease']|float < 8 and not pillar_get('node:install_from_ppa', '')) %}
3939
{% set npm_requirement = npm_src_requirement %}
4040
{% else %}
4141
{% set npm_requirement = 'pkg: {0}'.format(node['npm_pkg']) %}
@@ -48,4 +48,4 @@
4848
'RedHat': {
4949
'pkgs': ['git', 'curl', 'gcc','openssl-devel','pkgconfig', 'gcc-c++', 'make', 'automake']
5050
},
51-
}, grain='os_family', merge=pillar_get('from_src_requirements:lookup'), default='Debian') %}
51+
}, grain='os_family', merge=pillar_get('from_src_requirements:lookup', ''), default='Debian') %}

node/pkg.sls

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{%- from "node/map.jinja" import node, npm_bin with context %}
22
3-
{%- if grains['os_family'] in ['Ubuntu', 'Debian'] and salt['pillar.get']('node:install_from_ppa') %}
3+
{%- if grains['os_family'] in ['Ubuntu', 'Debian'] and salt['pillar.get']('node:install_from_ppa', '') %}
44
nodejs.ppa:
55
pkg.installed:
66
- name: apt-transport-https
@@ -21,6 +21,6 @@ nodejs:
2121
pkg.installed:
2222
- name: {{ node.node_pkg }}
2323
- reload_modules: true
24-
{%- if salt['pillar.get']('node:version') %}
25-
- version: {{ salt['pillar.get']('node:version') }}
24+
{%- if salt['pillar.get']('node:version', '') %}
25+
- version: {{ salt['pillar.get']('node:version', '') }}
2626
{%- endif %}

0 commit comments

Comments
 (0)